Updated comment. We are keeping track of maximum number of retries per command
via
retries/allowed in struct scsi_cmnd. Corrected comment positioning.
Signed-off-by: Petros Koutoupis
diff -uNpr linux-4.14-rc7.orig/drivers/scsi/scsi_error.c
linux-4.14-rc7/drivers/scsi/scsi_error.c
--- linux
abled
conditional above, under the assumption that if the media supports Type-2
then it should also support the 32-byte commands. Thoughts?
Signed-off-by: Petros Koutoupis
--- scsi-devel/drivers/scsi/sd.c.orig 2016-05-12 23:21:04.31400 -0500
+++ scsi-devel/drivers/scsi/sd.c2016-05-25
On Sun, 2016-05-22 at 10:20 -0700, James Bottomley wrote:
> On Sat, 2016-05-21 at 20:58 -0500, Petros Koutoupis wrote:
> > This change is purely cosmetic but we should adjust device type 0x14
> > to reflect the definition given in the SCSI specification standard
> > (SPC -
of that command set with a few zone specific additions. Please
refer to the ZBC for details.
Signed-off-by: Petros Koutoupis
--- linux/drivers/scsi/scsi_common.c.orig 2016-05-12 12:23:04.45000
-0500
+++ linux/drivers/scsi/scsi_common.c2016-05-12 12:29:08.38200 -0500
@@ -14,27
On Thu, 2016-05-12 at 09:35 +0300, Dan Carpenter wrote:
> On Wed, May 11, 2016 at 08:49:51PM -0500, Petros Koutoupis wrote:
> > Sumit,
> >
> > I will resubmit the patch with all the recommendations. Thank you. In case
> > you are interested, I have a crash file showcas
On Wed, 2016-05-11 at 15:11 +0530, Sumit Saxena wrote:
> > -Original Message-
> > From: Petros Koutoupis [mailto:pet...@petroskoutoupis.com]
> > Sent: Tuesday, May 10, 2016 2:59 AM
> > To: Sumit Saxena; Dan Carpenter; Finn Thain
> > Cc: kashyap.
On Mon, 2016-05-09 at 15:18 +0530, Sumit Saxena wrote:
> >
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, May 09, 2016 1:36 PM
> > To: Finn Thain
> > Cc: Petros Koutoupis; kashyap.de...@avagotech
hit the continue.
Signed-off-by: Petros Koutoupis
Acked-by: Don Brace
--- linux/drivers/scsi/hpsa.c.orig 2016-04-27 21:43:44.463140419 -0500
+++ linux/drivers/scsi/hpsa.c 2016-04-27 22:45:31.015140419 -0500
@@ -1637,9 +1637,8 @@ static void hpsa_figure_phys_disk_ptrs(s
for
On Mon, 2016-05-09 at 11:35 +1000, Julian Calaby wrote:
> Hi Petros,
>
> On Mon, May 9, 2016 at 2:34 AM, Petros Koutoupis
> wrote:
> > On Sun, 2016-05-08 at 22:22 +1000, Finn Thain wrote:
> >> On Sun, 8 May 2016, Petros Koutoupis wrote:
> >>
> &g
On Sun, 2016-05-08 at 22:22 +1000, Finn Thain wrote:
> On Sun, 8 May 2016, Petros Koutoupis wrote:
>
> > >
> > > That contains a tautology.
> > >
> >
> > How so?
>
> if (x)
> /* ... */
> else if (!x && (whatever))
>
.
Signed-off-by: Petros Koutoupis
--- linux/drivers/scsi/megaraid/megaraid_sas_fusion.c.orig 2016-05-07
09:12:56.748969851 -0500
+++ linux/drivers/scsi/megaraid/megaraid_sas_fusion.c 2016-05-07
09:15:29.612967113 -0500
@@ -2277,6 +2277,10 @@ complete_cmd_fusion(struct megasas_insta
On Sun, 2016-05-08 at 13:32 +1000, Finn Thain wrote:
> On Sat, 7 May 2016, Petros Koutoupis wrote:
>
> > The current state of the code checks to see if the reference to
> > scsi_cmnd is not null, but it never checks to see if it is null and
> > always assumes it is valid
The current state of the code checks to see if the reference to scsi_cmnd is
not null, but it never checks to see if it is null and always assumes it is
valid
before its use in below switch statement. This patch addresses that.
--- linux/drivers/scsi/megaraid/megaraid_sas_fusion.c.orig 2016-
The device ID obtained from the inquiry can only be of a single type. The
original
code places a check for TYPE_ZBC right after the check for TYPE_DISK. Logically,
if the first if statement sees a device of a TYPE_DISK and moves on to the
second
statement checking if not TYPE_ZBC, it will always
14 matches
Mail list logo
