James Bottomley wrote:
On Sun, 2008-01-06 at 04:02 +0100, Richard Knutsson wrote:
Hi all
drivers/scsi/scsi_typedefs.h is about ready to be removed, only the
'struct scsi_cmnd' typedef Scsi_Cmnd is left.
This set converts all the Scsi_Cmnd's, except in:
Changelogs
Doc
Convert glue-include "scsi.h" to (and friends).
(binary sizes)
allyesconfig: before: 260132
after: 260048
allmodconfig: before: 261740
after: 261656
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Do not have the hardware, but since it co
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index cf4c219..341ed5a 100644
--- a/include/scsi/scsi_tcq.h
+++ b/include/scsi/scsi
Change to the correct argument-name.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index cf4c219..341ed5a 100644
--- a/include/scsi/scsi_tcq.h
+++ b/include/scsi/scsi_tcq.h
@@ -86,7 +86,7 @@ static inlin
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-error.
diff --git a/drivers/scsi/wd7000.c b/dri
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-warnings.
diff --git a/drivers/scsi/sun3x_esp.c
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/sym53c416.c b/drivers/scsi/sym53c416.c
index 9
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors.
diff --git a/drivers/scsi/oktagon_esp.c b
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/pas16.h b/drivers/scsi/pas16.h
index 8dc5b1a..
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/nsp32_debug.c b/drivers/scsi/nsp32_debug.c
index e
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning).
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning).
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors.
diff --git a/drivers/scsi/megaraid.c b/drive
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning, and
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/mca_53c9x.c b/drivers/scsi/mca_53c9x.c
index d
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors.
diff --git a/drivers/scsi/mac_esp.c b/driv
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index 7
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvs
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/gdth_proc.c b/drivers/scsi/gdth_proc.c
index d
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index b253b8c..3c3e2
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/dtc.h b/drivers/scsi/dtc.h
index 0b205f8..524b
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/cyberstormII.c b/drivers/scsi/cyberstormII.c
in
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/fastlane.c b/drivers/scsi/fastlane.c
index 4
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/cyberstorm.c b/drivers/scsi/cyberstorm.c
index c
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/blz2060.c b/drivers/scsi/blz2060.c
index b6203ec..
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-warnings.
diff --git a/drivers/scsi/atari_scsi.c
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/blz1230.c b/drivers/scsi/blz1230.c
index 23f7c24..
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning).
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning)
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning)
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 9
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning)
so if replying, please Cc: me.
Yours,
Richard Knutsson
PS
If someone know of a tool to chain-mail patches and still be able to customize
the mail-addresses between them, please let me know.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
diff --git a/drivers/scsi/3w-.c b/drivers/scsi/3w-.c
index 5971
Matthew Wilcox wrote:
On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote:
I just don't see the reason why expressing a boolean as an integer. Some
advantage?
This is C, not Java, or some other highly-typed language.
if (int) and if (ptr) are perfectly acceptable
Denys Vlasenko wrote:
On Tuesday 30 October 2007 10:54, Richard Knutsson wrote:
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Diffed against linus-git
Checked with script/checkpatch.pl
diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h
index 451accd..6
Matthew Wilcox wrote:
On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote:
Matthew Wilcox wrote:
On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote:
Convert to use the generic boolean.
- u8 initialized;
- u8 in_use; /* is
Matthew Wilcox wrote:
On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote:
Convert to use the generic boolean.
- u8 initialized;
- u8 in_use; /* is the management node open*/
+ bool initialized:8;
+ bool in_use:8; /* is the
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Diffed against linus-git
Checked with script/checkpatch.pl
diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h
index 451accd..6f56528 100644
--- a/drivers/scsi/lpfc/lpfc_hw.h
+++ b/drivers/scsi/lpfc/lpfc_hw.h
@@ -3
Convert to use the generic boolean.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Diffed against linus-git
Checked with script/checkpatch.pl
(warned about long lines, but it is not introduced by this patch)
dpt_i2o.c | 22 +++---
dpti.h|9 ++---
2
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
got some warnings on some builds, none related to this patch
Diffed against Linus' git-tree.
aic7xxx_old.c
aintainer(s)/ML,
and send them your way if they are not picked up (is one week enough, or
should it be longer?)
Regards
Richard Knutsson
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
James Bottomley wrote:
On Tue, 2007-05-01 at 14:16 -0400, Robert P. J. Day wrote:
On Tue, 1 May 2007, Richard Knutsson wrote:
Remove the unused header drivers/scsi/pci2000.h
i have the same patch in my pending patch directory, dated march 10,
so i know i submitted it, but i
Remove the unused header drivers/scsi/pci2000.h
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
'grep -nr "pci2000"' on the whole tree results only in a reference to pci2000.h
Diffed against Linus' git-tree.
diff --git a/drivers/scsi/pci2000.h b/drivers/s
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Only included by drivers/scsi/eata_pio.c and it only uses FALSE/TRUE
in comments.
diff --git a/drivers/scsi/eata_generic.h b/drivers/scsi/eata_generic.h
index 635c148..5016af5 100644
--- a/drivers/scsi/eata_generic.h
+++ b/driver
James Bottomley wrote:
On Fri, 2007-02-16 at 19:04 +0100, Richard Knutsson wrote:
James Bottomley wrote:
On Mon, 2007-02-12 at 12:27 -0800, Andrew Morton wrote:
Given that we now have a standard kernel-wide, c99-friendly way of
expressing true and false, I'd suggest
obviously not a boolean, while:
u8 a:1;
...
if (a)
is, and a should be "bool a:1;" (imho)
Richard Knutsson
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
struct megasas_instance {
atomic_t fw_outstanding;
u32 hw_crit_error;
+ u8 is_busy;
Why not "bool is_busy:8;"? It obviously is a boolean. I would also think
false/true would be more descriptive then 0/1.
Richard Knutsson
-
To unsubscribe from this list: send the l
Convert pci_module_init() to pci_register_driver().
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with "allyes", "allmod" & "allno" on i386
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index fa5382e..ce8845e 1
Convert pci_module_init() to pci_register_driver().
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with "allyes", "allmod" & "allno" on i386
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 808a1b8..0aa3304 10
James Bottomley wrote:
On Sat, 2007-02-10 at 18:46 +0100, Richard Knutsson wrote:
Convert:
FALSE -> false
TRUE -> true
Actually, downcasing true and false in this driver is pretty much a
retrograde step. The reason for their being uppercased is that they
represent constant
James Bottomley wrote:
On Sat, 2007-02-10 at 18:46 +0100, Richard Knutsson wrote:
Convert:
FALSE -> false
TRUE -> true
Actually, downcasing true and false in this driver is pretty much a
retrograde step. The reason for their being uppercased is that they
represent constant
Convert:
FALSE -> false
TRUE -> true
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with "allyes", "allmod" & "allno" on i386
Whitespace cleaning on affected lines
drivers/scsi/aic7xxx_old.c | 242
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
PS
The mailing-list is marked as S: instead of L:
DS
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 77d9d38..4fd4960 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -5072,7 +5072,7 @@ stat
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index fa5382e..ce8845e 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2681,7 +2681,7 @@ static int __init dc390_module_init(void)
58 matches
Mail list logo
