Re: can all 53c7xx-related stuff be removed?

2008-02-09 Thread Robert P. J. Day
On Sat, 9 Feb 2008, Matthew Wilcox wrote: > On Sat, Feb 09, 2008 at 02:12:07PM -0500, Robert P. J. Day wrote: > > On Sat, 9 Feb 2008, Matthew Wilcox wrote: > > > On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote: > > > > just an observation that,

Re: can all 53c7xx-related stuff be removed?

2008-02-09 Thread Robert P. J. Day
On Sat, 9 Feb 2008, Matthew Wilcox wrote: > On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote: > > just an observation that, even though 53c7xx content has been > > officially removed, there are still a few droppings hanging around the > > tree: > > E

can all 53c7xx-related stuff be removed?

2008-02-09 Thread Robert P. J. Day
the Amiga. $ rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.ca Fedora Cookbook:http

[PATCH] SCSI: Standardize include of linux header file to use "<>".

2007-11-28 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- outside of UML code, there are few instances throughout the tree that don't use the recommended format of "<>" for linux header files. diff --git a/drivers/scsi/aic94xx/aic94xx_dump.c b/drivers/scsi/aic94xx/a

[PATCH] Documentation: Remove references to dead "st0x" and "tmc8xx" parms.

2007-11-14 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- as best i can tell, those kernel parms don't exist anymore. Documentation/kernel-parameters.txt |6 -- drivers/scsi/seagate.c | 11 --- 2 files changed, 17 deletions(-) diff --git a/Documenta

Re: [PATCH] SCSI: Use is_power_of_2() macro for simplicity.

2007-11-07 Thread Robert P. J. Day
On Tue, 6 Nov 2007, Matthew Wilcox wrote: > On Tue, Nov 06, 2007 at 10:20:46AM -0500, Robert P. J. Day wrote: > > @@ -1656,7 +1657,7 @@ static inline int reconnect_target(struct NCR_ESP > > *esp, struct ESP_regs *eregs) > > if(!(it & me)) > >

Re: [PATCH] SCSI: Use is_power_of_2() macro for simplicity.

2007-11-06 Thread Robert P. J. Day
On Tue, 6 Nov 2007, Matthew Wilcox wrote: > On Tue, Nov 06, 2007 at 11:09:51AM -0500, Robert P. J. Day wrote: > > > > bits &= ~esp->scsi_id_mask; > > > > - if (!bits || (bits & (bits - 1))) > >

Re: [PATCH] SCSI: Use is_power_of_2() macro for simplicity.

2007-11-06 Thread Robert P. J. Day
On Tue, 6 Nov 2007, Matthew Wilcox wrote: > On Tue, Nov 06, 2007 at 10:20:46AM -0500, Robert P. J. Day wrote: > > @@ -1656,7 +1657,7 @@ static inline int reconnect_target(struct NCR_ESP > > *esp, struct ESP_regs *eregs) > > if(!(it & me)) > >

[PATCH] SCSI: Use is_power_of_2() macro for simplicity.

2007-11-06 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- drivers/scsi/NCR53C9x.c |3 ++- drivers/scsi/esp_scsi.c |3 ++- drivers/scsi/iscsi_tcp.c |3 ++- drivers/scsi/libiscsi.c |3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/NCR53C

SCSI-related dead CONFIGs?

2007-11-02 Thread Robert P. J. Day
t;> SCSI_NCR53C8XX_TAGGED_QUEUE drivers/scsi/ncr53c8xx.h:116:#elif defined CONFIG_SCSI_NCR53C8XX_TAGGED_QUEUE >>>>> WD33C93_PIO drivers/scsi/wd33c93.h:193:#ifdef CONFIG_WD33C93_PIO drivers/scsi/wd33c93.c:174:#ifdef CONFIG_WD33C93_PIO drivers/scsi/wd33c93.c:232:#else /* CON

[PATCH] SCSI: Remove apparently unused traces of SCSI_QLOGIC_FC content.

2007-10-26 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- i can't find any historical evidence that the related content has been removed, but nothing in the tree seems to need this Kconfig entry (and, as randy dunlap noticed, the dependency of SCSI_QLOGIC_FC doesn't even exist,

Re: single unused scsi-related CONFIG variable

2007-10-26 Thread Robert P. J. Day
On Fri, 26 Oct 2007, Randy Dunlap wrote: > On Fri, 26 Oct 2007 14:18:05 -0400 (EDT) Robert P. J. Day wrote: > > > > > drivers/scsi/Kconfig:1322:config SCSI_QLOGIC_FC_FIRMWARE > > config SCSI_QLOGIC_FC_FIRMWARE > bool "Include loadable firmware in driver&qu

single unused scsi-related CONFIG variable

2007-10-26 Thread Robert P. J. Day
drivers/scsi/Kconfig:1322:config SCSI_QLOGIC_FC_FIRMWARE rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca

[PATCH] Documentation: Delete final reference to "sg_def_reserved_size" kernel parm.

2007-08-30 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- given the following: $ grep -rw sg_def_reserved_size * Documentation/kernel-parameters.txt:sg_def_reserved_size= [SCSI] $ that kernel parameter looks exceedingly dead. diff --git a/Documentation/kernel-parameters.

[PATCH] SCSI: Remove references to dead "st0x" and "tmc8xx" kernel parms.

2007-08-29 Thread Robert P. J. Day
Since these two kernel parameters don't appear to be supported, remove the useless references to them. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |6 -- drivers/scsi/seagate.c | 11 --- 2 files

[PATCH] Documentation: Drop reference to dead "sg_def_reserved_size".

2007-06-15 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- this entry looks suitably dead, yes? probably the first in a regular series of removals. diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 5d0283c..496cef8 100644 --- a/Documentation/

[PATCH] IDE: Remove references to the non-existent CONFIG_SCSI_EATA_DMA variable.

2007-06-03 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index 3cebed7..969e385 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c @@ -144,7 +144,7 @@ static inline void do_identify (ide_drive_t *drive,

[PATCH] Remove dead references to MODULE_PARM macro.

2007-05-27 Thread Robert P. J. Day
Remove the useless references to the obsolete MODULE_PARM macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- just spending a few minutes cleaning the tree of the few remaining references to MODULE_PARM. diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c index 0

Re: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Robert P. J. Day
ere a qualitative difference between these two macros? is there *supposed* to be? if there isn't, one would think that just one variation would be sufficient. rday -- ============ Robert P. J. Day Linux Consulting, Training and A

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-13 Thread Robert P. J. Day
On Sun, 13 May 2007, James Bottomley wrote: > On Sun, 2007-05-13 at 12:20 -0400, Robert P. J. Day wrote: > > since this thread looks like it's going to get away from me in a > > hurry :-), my only point in asking was to point out that that lone > > module was the only

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-13 Thread Robert P. J. Day
On Sun, 13 May 2007, James Bottomley wrote: > On Sun, 2007-05-13 at 12:06 -0400, Dave Jones wrote: > > On Sun, May 13, 2007 at 11:22:55AM -0400, Robert P. J. Day wrote: > > > > > > not a big deal, but is there a reason that a "make defconfig" on my &g

Re: [PATCH] SCSI: Remove redundant GFP_KERNEL type flag in kmalloc().

2007-05-04 Thread Robert P. J. Day
On Fri, 4 May 2007, Andrew Morton wrote: > > Please be careful to add the appropriate cc's. > > On Mon, 30 Apr 2007 04:37:22 -0400 (EDT) "Robert P. J. Day" <[EMAIL > PROTECTED]> wrote: > > > > > Remove the apparently redundant GFP_KERNEL type fl

Re: dead CONFIG_ variables: drivers/scsi/

2007-05-03 Thread Robert P. J. Day
On Thu, 3 May 2007, Russell King wrote: > On Thu, May 03, 2007 at 06:10:28AM -0400, Robert P. J. Day wrote: > > > > $ ../dead_config.sh drivers/scsi > > == ACORNSCSI_CONSTANTS == > > drivers/scsi/arm/acornscsi.c:106:#undef CONFIG_ACORNSCSI_CON

dead CONFIG_ variables: drivers/scsi/

2007-05-03 Thread Robert P. J. Day
lse /* CONFIG_WD33C93_PIO */ drivers/scsi/wd33c93.c:297:#endif /* CONFIG_WD33C93_PIO */ drivers/scsi/wd33c93.h:193:#ifdef CONFIG_WD33C93_PIO rday -- ==== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Onta

Re: [PATCH] drivers/scsi/pci2000.h: Remove unused file

2007-05-01 Thread Robert P. J. Day
day -- ==== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page - To unsubscribe from this list: send the line "uns

Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-27 Thread Robert P. J. Day
SCSI-related), but is it official policy to support code based on its release number in the 2.5 series of releases? unless you have a good reason, wouldn't it make more sense to compare against (2,6,0) rather than, say, (2,5,73)? just an observation. rday -- ===

Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code

2007-04-26 Thread Robert P. J. Day
urce tree, and simply uses that kind of preprocessor check to make sure it's being compiled appropriately? or are you doing something more sophisticated than simply checking the kernel version being tested? rday -- Ro

Re: some PCMCIA SCSI drivers can be built *only* as modules

2007-03-26 Thread Robert P. J. Day
On Mon, 26 Mar 2007, Christoph Hellwig wrote: > > > it would seem to make no sense that the "depends on" clause > > > for this option includes "m", forcing this (and all other four > > > entries in that Kconfig file, by the way) to be built as > > > modules, while the help text for all five entr