RE: [PATCH -next] scsi: fnic: Remove set but not used variable 'vdev'

Looks good to me. Acked-by: Satish Kharat Satish Kharat TECHNICAL LEADER.ENGINEERING satis...@cisco.com Tel: +1 408 526 7504 Cisco Systems, Inc. 3800 Zanker Road SAN JOSE 95134 United States cisco.com Think before you print. This email may contain confidential and privileged material for the

RE: [PATCH 3/7] scsi: fnic: no need to check return value of debugfs_create functions

Looks good to me. Acked-by: Satish Kharat Satish Kharat TECHNICAL LEADER.ENGINEERING satis...@cisco.com -Original Message- From: Greg Kroah-Hartman Sent: Tuesday, January 22, 2019 7:09 AM To: James Bottomley ; Martin Petersen Cc: linux-ker...@vger.kernel.org; linux-scsi

[PATCH 6/6] scsi: fnic: Updating fnci driver version to 1.6.0.47

With this (the devamd2) and the previous patch series 'fnic driver updates' (link below) the fnic driver version is 1.6.0.47 https://marc.info/?l=linux-scsi&m=154751555007972&w=2 Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- 1 file changed, 1 insert

[PATCH 0/6] fnic devcmd2 changes

Devcmd2 is a newer firmware interface exported by newer Cisco VIC devices. This series of patches is to enable the devcmd2 interface for fnic. Satish Kharat (6): scsi: fnic: fnic devcmd2 interface definitions scsi: fnic: fnic devcmd2 controller definitions scsi: fnic: Adds devcmd2

[PATCH 5/6] scsi: fnic: Enabeling fnic devcmd2 interface

This patch adds changes to check if fnic devcmd2 interfaces is exported by the firmware. If devcmd2 interfaces is exported it initializes and starts using it else falls back to fnic devcm1 interface. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_main.c | 11 ++- drivers/scsi

[PATCH 1/6] scsi: fnic: fnic devcmd2 interface definitions

This patch adds the fnic devcmd2 command structre and the command result structure definitions. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_devcmd.h | 158 +- drivers/scsi/fnic/vnic_resource.h | 7 ++ 2 files changed, 163 insertions(+), 2 deletions

[PATCH 2/6] scsi: fnic: fnic devcmd2 controller definitions

This patch adds the fnic devcmd2 controller definition. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_dev.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c index

[PATCH 4/6] scsi: fnic: Adding devcmd2 init and posting interfaces

This patch adds fnic devcmd-2 interfaces for initialization and posting commands to fw. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_dev.c | 223 ++- 1 file changed, 219 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers

[PATCH 3/6] scsi: fnic: Adds devcmd2 initialization helpers

This patch adds the devcmd2 wq initalization and devcm2 ring allocation helper interfaces used by devcmd2 init. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_wq.c | 66 + drivers/scsi/fnic/vnic_wq.h | 8 + 2 files changed, 74 insertions

[PATCH v2 01/10] scsi: fnic: support to display 20G port speed

This patch is to add finc 20G port speed display in sysfs Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_fcs.c | 4 drivers/scsi/fnic/fnic_io.h | 3 ++- drivers/scsi/fnic/fnic_main.c | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/fnic

[PATCH v2 00/10] fnic driver updates

The following patches are bug fixes and update for the fnic driver. Satish Kharat (10): scsi: fnic: support to display 20G port speed scsi: fnic: change fnic queue depth to 256 scsi: fnic: vnic_rq_clean changing BUG_ON to WARN_ON scsi: fnic: usign fnic_lock to gaurd fnic->state_fl

[PATCH v2 03/10] scsi: fnic: vnic_rq_clean changing BUG_ON to WARN_ON

rq->ctrl not enabled when this is called is bad but not fatal and can continue. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_rq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/vnic_rq.c b/drivers/scsi/fnic/vnic_rq.c index fd2068f5a

[PATCH v2 09/10] scsi: fnic: RQ enable and then post descriptors

This change is the do RQ enable before positing descriptor. This is needed for later hw revisions. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_main.c | 5 ++--- drivers/scsi/fnic/vnic_devcmd.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic

[PATCH v2 07/10] scsi: fnic: Warn when calling io done for IO not issued to fw

The change is to print warning when scsi done is called for an IO that has not yet been issued to the fw. Also adding sc and tag to debug print when IO is cleaned up. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[PATCH v2 08/10] scsi: fnic: delaying vnic dev enable till after req intr

doing vnic_device_enable before this could cause interrupts to happen before they are setup. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index

[PATCH v2 06/10] scsi: fnic: fnic stats for max CQs processed and ISR time

This change is to add fnic stats for the max number of CQs (corresponding to copy WQ) processed in a given interrupt, max time taken by the ISR. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 19 +++ drivers/scsi/fnic/fnic_stats.h | 3 +++ drivers/scsi/fnic

[PATCH v2 02/10] scsi: fnic: change fnic queue depth to 256

This patches changes the default lun queuedepth for fnic to 256 Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h index d094ba59ed15..5c9402c811c9 100644 --- a/drivers

[PATCH v2 10/10] scsi: fnic: Impose upper limit on max. # of CQs processed per intr

This change is to impose an upper limit on the max number of CQ entries (corresponding to the copy wq) processed in an interrupt. Using module param to set the limit. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 ++ drivers/scsi/fnic/fnic_isr.c | 6 +++--- drivers/scsi

[PATCH v2 04/10] scsi: fnic: usign fnic_lock to gaurd fnic->state_flags

Need to use fnic_lock as well as host lock in that order to set state flags. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index

[PATCH v2 05/10] scsi: fnic: Add fnic port speed stat to finc debug stats

This patch adds the current fnic port speed stat to fnic debug stats. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_fcs.c | 6 ++ drivers/scsi/fnic/fnic_stats.h | 1 + drivers/scsi/fnic/fnic_trace.c | 5 + 3 files changed, 12 insertions(+) diff --git a/drivers/scsi/fnic

[PATCH 1/1] scsi:fnic: delaying vnic dev enable till after req intr

doing vnic_device_enable before this could cause interrupts to happen before they are setup. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index

[PATCH 1/1] scsi : fnic: RQ enable and then post descriptors

This change is the do RQ enable before positing descriptor needed for later hw versions. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_main.c | 5 ++--- drivers/scsi/fnic/vnic_devcmd.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic

[PATCH] scsi:fnic: fnic stats for max CQs processed and ISR time

This change is to add fnic stats for the max number of CQs (corresponding to copy WQ) processed in a given interrupt, max time taken by the ISR. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 19 +++ drivers/scsi/fnic/fnic_stats.h | 3 +++ drivers/scsi/fnic

[PATCH 1/1] scsi : fnic : vnic_rq_clean changing BUG_ON to WARN_ON

rq->ctrl not enabled when this is called is bad but not fatal and can continue. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_rq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/vnic_rq.c b/drivers/scsi/fnic/vnic_rq.c index fd2068f5a

[PATCH] scsi:fnic: Warn when calling io done for IO not issued to fw

The change is to print warning when scsi done is called for an IO that has not yet been issued to the fw. Also adding sc and tag to debug print when IO is cleaned up. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[PATCH] scsi : fnic: Impose upper limit on max. # of CQs processed per intr.

This change is to impose an upper limit on the max number of CQ entries (corresponding to the copy wq) processed in an interrupt. Using module param to set the limit. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 ++ drivers/scsi/fnic/fnic_isr.c | 6 +++--- drivers/scsi

[PATCH 1/1] scsi : fnic : support to display 20G port speed

This patch is to add finc 20G port speed display in sysfs Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_fcs.c | 4 drivers/scsi/fnic/fnic_io.h | 3 ++- drivers/scsi/fnic/fnic_main.c | 3 +++ 4 files changed, 10 insertions(+), 2 deletions

[PATCH 1/1] scsi : fnic : usign fnic_lock to gaurd fnic->state_flags

Need to use fnic_lock as well as host lock in that order to set state flags. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index

[PATCH 1/1] scsi : fnic : change fnic queue depth to 256

This patches changes the default lun queuedepth for fnic to 256 Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h index d094ba59ed15..5c9402c811c9 100644 --- a/drivers

[PATCH] scsi:fnic: Add fnic port speed stat to finc debug stats

This patch adds the current fnic port speed stat to fnic debug stats. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_fcs.c | 6 ++ drivers/scsi/fnic/fnic_stats.h | 1 + drivers/scsi/fnic/fnic_trace.c | 5 + 3 files changed, 12 insertions(+) diff --git a/drivers/scsi/fnic

RE: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

Looks good to me. Acked-by: Satish Kharat -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, January 17, 2018 7:17 AM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) ; James E.J. Bottomley ; Martin K. Petersen Cc

[PATCH 1/1] fnic:correct speed display and add support for 25,40 and 100G

Setting speed based on the vinc device parameter read during linkup. Also adding support to display 25,40 and 100G Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic_fcs.c | 24 drivers/scsi/fnic/fnic_io.h | 9 + drivers

[PATCH 1/1] fnic: Zero io_cmpl_skip on fw reset completion

io_cmpl_skip keep track of number of completions to skip when stats are reset. If a fw_reset happens immediately after stats reset it could put it out of sync so need to reset io_cmpl_skip when fw reset is completed. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi

[PATCH 1/1] fnic:added timestamp reporting in fnic debug stats

Added the timestamps for 1. current timestamp 2. last fnic stats read timestamp 3. last fnic stats reset timestamp and the deltas since last stats read and last reset in fnic stats. fnic stats uses debugfs Signed-off-by: Sesidhar Baddela Signed-off-by: Satish Kharat --- drivers/scsi/fnic

[PATCH 1/1] fnic:changing queue command to return result DID_IMM_RETRY when rport is init

-off-by: Satish Kharat --- drivers/scsi/fnic/fnic_scsi.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index d048f3b..cc48cb8 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic

RE: [PATCH 1/1] fnic: Adding Check Condition counter to misc fnicstats

ion and basic IO test, this patch looks good. Thanks, Satish Kharat -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Wednesday, March 01, 2017 7:04 PM To: Satish Kharat (satishkh) Cc: linux-scsi@vger.kernel.org; Sesidhar Baddela (sebaddel) Subject: R

[PATCH 1/1] fnic: bug fix for fip.fip_subcode in fnic_fcoe_send_vlan_req

This is a bug introduced when they moved the fip subcodes to central place. Was sending FIP_SC_VL_NOTE in fip.fip_subcode for VLAN request in fnic_fcoe_send_vlan_req. Change is to use FIP_SC_VL_REQ instead. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic

[PATCH 1/1] fnic: minor cleanup in fnic_fcpio_itmf_cmpl_handler, removing else case

Getting rid of else case to make the flow look bit more simpler logical Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic

[PATCH 1/1] fnic: Ratelimit printks to avoid flooding when vlan is not set by the switch.i

From: Satish Kharat This is to avoid the log from being filled with vlan discovery messages when there is no vlan configured on the switch. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic_fcs.c | 21 + 1 file changed, 13 insertions

[PATCH 1/1] fnic: Fix for "Number of Active IOs" in fnicstats becoming negative

Fixing the IO stats updation (Active IOs and IO completion) to fix "Number of Active IOs" becoming negative in the fnistats output. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic_scsi.c | 15 ++- 1 file changed, 10 insertions(+), 5

[PATCH 1/1] fnic: Adding debug IO and Abort latency counter to fnic stats

her debug stat. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_scsi.c | 43 ++ drivers/scsi/fnic/fnic_stats.h | 15 ++ drivers/scsi/fnic/fnic_trace.c |

[PATCH 1/1] fnic: Avoid false out-of-order detection for aborted command

If SCSI-ML has already issued abort on a command i.e FNIC_IOREQ_ABTS_PENDING is set and we get a IO completion avoid this being flagged as out-of-order completion by setting the FNIC_IO_DONE flag in fnic_fcpio_icmnd_cmpl_handler Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela

[PATCH 1/1] fnic: Adding Check Condition counter to misc fnicstats

Just a simple counter of number of check conditions encountered on that host. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic_scsi.c | 3 +++ drivers/scsi/fnic/fnic_stats.h | 1 + drivers/scsi/fnic/fnic_trace.c | 2 ++ 3 files changed, 6 insertions

[PATCH 1/1] scsi:fnic Avoid sending reset to fnic firmware when another reset is already in progress

This fix is to avoid calling fnic_fw_reset_handler through fnic_host_reset when a finc reset is alreay in progress. Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic.h | 1 + drivers/scsi/fnic/fnic_scsi.c | 16 2 files changed, 17

[PATCH] fnic: Correcting rport check location in fnic_queuecommand_lck

Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- drivers/scsi/fnic/fnic_scsi.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index bfaba06..2544a37 100644 --- a

[PATCH 1/1] [fnic, snic] Updating maintainers list for Cisco FNI and SNIC drivers

Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b3a7774..11fdf45 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3149,15 +3149,15 @@ S: Supported F

[PATCH v1 1/3] Fix to cleanup aborted IO to avoid device being offlined by mid-layer

successful. The start_time assignment is moved because of the new goto. Fnic driver version changed from 1.6.0.17a to 1.6.0.19, version 1.6.0.18 has been skipped Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela Reviewed-by: Ewan D. Milne --- * v1 - Moved CMD_ABTS_STATUS assignment

[PATCH v1 3/3] Using rport->dd_data to check rport online instead of rport_lookup.

scsi_cmnd error code is expected to be in the left 16 bits of the result field. Changed to correct this. Fnic driver version changed from 1.6.0.20 to 1.6.0.21 Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- * v1 - DID_NO_CONNECT left shifted 16 bits before assigning to sc

Re: [PATCH 1/5] Fix to cleanup aborted IO to avoid device being offlined by mid-layer

device. Also if the original I/O is not found in fnic firmware, we will consider the abort as successful. The start_time assignment is moved because of the new goto. Fnic driver version changed from 1.6.0.17a to 1.6.0.19, version 1.6.0.18 has been skipped Signed-off-by: Satish Kharat --- drivers

[PATCH v1 2/3] Cleanup the I/O pending with fw and has timed out and is used to issue LUN reset

1. Fnic driver version changed from 1.6.0.19 to 1.6.0.20 Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- * v1 - new_sc is set to 1 in cases like lunreset from sg_reset --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_scsi.c | 38

[PATCH 4/5] Setting scsi host template to indicate that fnic does not support multiqueue

Fnic does not support mutiqueue. Setting the scsi_host_template in fnic_host_template to indicate that. Changing fnic_version from 1.6.0.21 to 1.6.0.22 Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_main.c | 1 + 2 files changed, 2 insertions

[PATCH 1/5] Fix to cleanup aborted IO to avoid device being offlined by mid-layer

successful. Fnic driver version changed from 1.6.0.17a to 1.6.0.19, version 1.6.0.18 has been skipped Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_scsi.c | 32 +++- 2 files changed, 28 insertions(+), 6 deletions(-) diff

[PATCH 5/5] Leftshift returned scsi_cmnd error code 16 bits

The the scsi_cmnd error code is expected to be in the left 16 bits of the result field. Change is to correct this. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 2/5] Cleanup the I/O that has timed out and is used to issue LUN reset

In case of LUN reset, the device reset command is issued with one of the I/Os that has timed out on that LUN. The change is to also return this I/O with error status set to DID_RESET. Fnic driver version changed from 1.6.0.19 to 1.6.0.20 Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h

[PATCH 3/5] Using rport->dd_data to check rport online instead of rport_lookup.

driver version changed from 1.6.0.20 to 1.6.0.21 Signed-off-by: Satish Kharat --- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_scsi.c | 20 +++- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h