Aw: [ANNOUNCE v2]: Broadcom (Emulex) FC Target driver - efct

2018-12-20 Thread Sebastian Herbszt
Hello James, > I noticed this version does only build here on kernel 4.18. I pushed the > required changes for kernel 4.19 to my repository [1]. this patch [1] is required on 32 bit to fix WARNING: "__udivdi3" [efct.ko] undefined! It seems v2 contains some regressions: My simple setup triggere

Aw: [ANNOUNCE v2]: Broadcom (Emulex) FC Target driver - efct

2018-12-19 Thread Sebastian Herbszt
Hello James, > I'd like to announce the availability of the Broadcom (Emulex) FC target > driver - efct. > > This is the 2nd round of announcement.   In the first round, after > discussion with community members, it was decided that the driver would > consist of the following: >   - A SLI4-librar

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-06-14 Thread Sebastian Herbszt
Hannes Reinecke wrote: > On 06/13/2017 01:08 AM, James Smart wrote: [snip] > > Questions: > > a) How best to deal with overlapping pci id's ? E.g. if we do (1) > > and we have an initiator and target driver, there is a lot of > > adapters that are fully functional for target operation, but were

[PATCH] efct: fix compilation warning about atomic_t usage

2017-03-15 Thread Sebastian Herbszt
Use kref_read() instead of accessing the counter inside a kref. Signed-off-by: Sebastian Herbszt --- efct/efct_ddump.c | 5 ++--- efct/efct_hw.c| 6 +++--- efct/efct_io.c| 3 +-- efct/efct_lio.c | 2 +- efct/efct_scsi.c | 4 ++-- 5 files changed, 9 insertions(+), 11 deletions

[PATCH] efct: add missing include file

2017-03-15 Thread Sebastian Herbszt
After the split of linux/sched.h, linux/sched/signal.h is required. Signed-off-by: Sebastian Herbszt --- efct/efct_os.h | 1 + 1 file changed, 1 insertion(+) diff --git a/efct/efct_os.h b/efct/efct_os.h index 16f7dc3..5ae269e 100644 --- a/efct/efct_os.h +++ b/efct/efct_os.h @@ -56,6 +56,7

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-03-05 Thread Sebastian Herbszt
Nicholas A. Bellinger wrote: > Hi James & Co, > > Adding target-devel and Sebastian CC' > > On Mon, 2017-02-27 at 15:28 -0800, James Smart wrote: > > I'd like to announce the availability of the Broadcom (Emulex) FC > > Target driver - efct. > > This driver has been part of the Emulex OneCore Sto

Re: [PATCH v2 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

2016-12-29 Thread Sebastian Herbszt
James, thank you for taking the time to answer me. James Smart wrote: > Sebastian, > > "not portable" isn't the right way to describe it. It's not a > chip-architecture issue, but rather that some oem platforms have > side-band management that overrides anything that could have been > done in

Re: [PATCH v2 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

2016-12-28 Thread Sebastian Herbszt
James Smart wrote: > I competes, without reasonable solutions to resolve which should be > what at what time, with things like fabric-assigned wwn's as well as > platform-oem name assignments via platform mechanisms. Too many > admin planes competing. > > -- james FA-WWN seems to be fabric (and

Re: [PATCH v2 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

2016-12-22 Thread Sebastian Herbszt
James Smart wrote: > Deprecate lpfc_soft_wwn parameter. > No longer allow override of hw-assigned wwns > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart Any reason to remove this functionality? I was actually using it. Sebastian -- To unsubscribe from this list: send the line "unsub

[PATCH] lpfc: remove incorrect lockdep assertion

2016-04-17 Thread Sebastian Herbszt
Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix the comment which resulted in this mistake. Fixes: 1c2ba475eb0e ("lpfc: Add lockdep assertions") Signed-off-by: Sebastian Herbszt diff -uNr -U 5 a/drivers/scsi/lpfc/lpfc_sli.c b/dr

Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

2016-03-30 Thread Sebastian Herbszt
Johannes Thumshirn wrote: > Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running > into the BUG_ON() in scsi_target_reap(). > > This intermediate state is only valid in the path from scsi_remove_target() to > scsi_target_destroy() indicating this target is going to be remove

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Sebastian Herbszt
he code > to be misindented in the first place. > > Signed-off-by: Arnd Bergmann > Fixes: 549e55cd2a1b ("[SCSI] lpfc 8.2.2 : Fix locking around HBA's port_list") > --- > drivers/scsi/lpfc/lpfc_init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Revi

Re: [PATCH] Separate target visibility from reaped state information

2016-02-07 Thread Sebastian Herbszt
James Bottomley wrote: > On Wed, 2016-02-03 at 23:38 +0100, Sebastian Herbszt wrote: > > James Bottomley wrote: > > > On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote: > > > > On 01/19/16 17:03, James Bottomley wrote: > > > > > On Tue, 2016-0

Re: [PATCH] Separate target visibility from reaped state information

2016-02-07 Thread Sebastian Herbszt
Martin K. Petersen wrote: > >>>>> "Sebastian" == Sebastian Herbszt writes: > > >> The only change from the current workflow is that the DEL transition > >> (now the reaped flag) is done before the spin lock is dropped which > >> would f

Re: [PATCH] Separate target visibility from reaped state information

2016-02-03 Thread Sebastian Herbszt
James Bottomley wrote: > On Wed, 2016-02-03 at 23:38 +0100, Sebastian Herbszt wrote: > > James Bottomley wrote: > > > On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote: > > > > On 01/19/16 17:03, James Bottomley wrote: > > > > > On Tue, 2016-0

Re: [PATCH] Separate target visibility from reaped state information

2016-02-03 Thread Sebastian Herbszt
prohibited. Such scanning > > activity can postpone the transition of the state of a SCSI target > > into STARGET_DEL. I think if the scheduler decides to run the thread > > that executes scsi_remove_target() on the same CPU as the scanning > > code after the scanning code

Re: *** GMX Spamverdacht *** Re: [PATCH] Separate target visibility from reaped state information

2016-02-03 Thread Sebastian Herbszt
Martin K. Petersen wrote: > >>>>> "Sebastian" == Sebastian Herbszt writes: > > >> The only change from the current workflow is that the DEL transition > >> (now the reaped flag) is done before the spin lock is dropped which > >> would f

Re: [PATCH] Separate target visibility from reaped state information

2016-01-31 Thread Sebastian Herbszt
James Bottomley wrote: > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote: > > > > > > > "Bart" == Bart Van Assche > > > > > > > writes: > > > > Bart> Instead of representing the states "visible in sysfs" and "has > > Bart> been removed from the target list" by a single state variable,

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-20 Thread Sebastian Herbszt
ort of refactoring. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2, RESEND] Separate target visibility from reaped state information

2016-01-06 Thread Sebastian Herbszt
arget" > > (commit 40998193560d). > > * "scsi_remove_target: fix softlockup regression on hot remove" > > (commit bc3f02a795d3). > > > > Reported-by: Sebastian Herbszt > > Tested-by: Sebastian Herbszt >

Re: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

2016-01-05 Thread Sebastian Herbszt
I wrote: > Christoph Hellwig wrote: > > On Thu, Dec 31, 2015 at 06:04:15PM +0100, Sebastian Herbszt wrote: > > > I still get this on 4.4.0-rc7-1.g276c9f4-default. Since this did not > > > happen on 4.3 I checked the scsi changes and found the following commit: >

Re: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

2016-01-03 Thread Sebastian Herbszt
Christoph Hellwig wrote: > On Thu, Dec 31, 2015 at 06:04:15PM +0100, Sebastian Herbszt wrote: > > I still get this on 4.4.0-rc7-1.g276c9f4-default. Since this did not > > happen on 4.3 I checked the scsi changes and found the following commit: > > > > scsi: restart

Re: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

2015-12-31 Thread Sebastian Herbszt
I wrote: > I got the following lockup on openSUSEs 4.4.0-rc5-2.g1e923a3-default kernel > while unloading the lpfc module: > > [ 444.088002] NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! > [kworker/1:1:29] > [ 444.088002] Modules linked in: lpfc(-) qla2x00tgt(O) qla2xxx_scst(O) > scst_v

Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

2015-12-17 Thread Sebastian Herbszt
mes Smart You missed the two already available positive reviews [1][2]. Anyway, Reviewed-by: Sebastian Herbszt [1] http://marc.info/?l=linux-scsi&m=144574360607327&w=2 [2] http://marc.info/?l=linux-scsi&m=144823385015994&w=2 -- To unsubscribe from this list: send the line &qu

Re: [PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy"

2015-12-17 Thread Sebastian Herbszt
d-off-by: Markus Elfring > Signed-off-by: James Smart Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

2015-12-17 Thread Sebastian Herbszt
I got the following lockup on openSUSEs 4.4.0-rc5-2.g1e923a3-default kernel while unloading the lpfc module: [ 444.088002] NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29] [ 444.088002] Modules linked in: lpfc(-) qla2x00tgt(O) qla2xxx_scst(O) scst_vdisk(O) scsi_transport_

Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

2015-11-22 Thread Sebastian Herbszt
Saurabh Sengar wrote: > replacing kmalloc and memset by a single call of kzalloc > > Signed-off-by: Saurabh Sengar > --- > v2 : I didn't got any response for my initial patch, > I am sending it again on top of latest kernel(today's) > > drivers/scsi/lpfc/lpfc_els.c | 3 +-- > 1 file changed, 1

Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

2015-11-22 Thread Sebastian Herbszt
> rdp_context->ndlp = lpfc_nlp_get(ndlp); > rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id; Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] libfc: correct function name in comment

2015-10-11 Thread Sebastian Herbszt
Use the correct function name in kernel-doc comment. Signed-off-by: Sebastian Herbszt Acked-by: Vasu Dev --- diff -U 5 -rp a/drivers/scsi/libfc/fc_npiv.c b/drivers/scsi/libfc/fc_npiv.c --- a/drivers/scsi/libfc/fc_npiv.c 2014-09-03 19:30:11.760273300 +0200 +++ b/drivers/scsi/libfc

Re: [PATCH 09/14] fix: lpfc_send_rscn_event sends bigger buffer size

2015-09-01 Thread Sebastian Herbszt
ruct lpfc_els_event_header) + payload_len, > + sizeof(struct lpfc_rscn_event_header) + payload_len, > (char *)rscn_event_data, > LPFC_NL_VENDOR_ID); > Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 08/14] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-09-01 Thread Sebastian Herbszt
t; -error: > +error_mbuf_free: > lpfc_mbuf_free(phba, mp->virt, mp->phys); > kfree(mp); > +error_cmd_free: > lpfc_sli4_mbox_cmd_free(phba, mbox); > rdp_context->cmpl(phba, rdp_context, FAILURE); > } Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/14] lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype

2015-09-01 Thread Sebastian Herbszt
sli.c > @@ -6696,7 +6696,7 @@ lpfc_mbox_timeout(unsigned long ptr) > * This function checks if any mailbox completions are present on the mailbox > * completion queue. > **/ > -bool > +static bool > lpfc_sli4_mbox_completions_pending(struct lpfc_hba *phba) > { >

Re: [PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

2015-09-01 Thread Sebastian Herbszt
lues. */ > lpfc_vport_template.sg_tablesize = phba->cfg_sg_seg_cnt; > - lpfc_template.sg_tablesize = phba->cfg_sg_seg_cnt; > + lpfc_template_s3.sg_tablesize = phba->cfg_sg_seg_cnt; > > /* There are going to be 2 reserved BDEs: 1 FCP cmnd + 1 FCP rsp */ > if (phba-

Re: [PATCH 02/14] lpfc: Remove unnessary cast

2015-09-01 Thread Sebastian Herbszt
sizeof(struct lpfc_sli_ring), GFP_KERNEL); > if (!phba->sli.ring) > return -ENOMEM; Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-18 Thread Sebastian Herbszt
Johannes Thumshirn wrote: > Sebastian Herbszt writes: > > > Johannes Thumshirn wrote: > >> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, > >> execution > >> continues normally and mp gets kfree()d. > >> > >> If the

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-17 Thread Sebastian Herbszt
Johannes Thumshirn wrote: > If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution > continues normally and mp gets kfree()d. > > If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the > error label where lpfc_mbuf_free() is called with mp->virt and mp->

[PATCH] lpfc: remove set but not used variables

2015-07-26 Thread Sebastian Herbszt
Remove set but not used variables. Signed-off-by: Sebastian Herbszt --- diff -urp a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2015-04-15 06:18:24.669045137 +0200 +++ b/drivers/scsi/lpfc/lpfc_attr.c 2015-07-25 01:22:42.072765205

[PATCH] lpfc: Use && instead of & for boolean expression

2015-07-22 Thread Sebastian Herbszt
Use logical instead of bitwise AND. Signed-off-by: Sebastian Herbszt --- diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-05 22:18:43.933739150 +0200 +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07-22 10:31

[PATCH v2] qla2xxx: use t10_pi_tuple

2015-07-12 Thread Sebastian Herbszt
Drop unused scsi_dif_tuple and use t10_pi_tuple instead of own sd_dif_tuple copy. Also use sg_virt() instead of open coding it. Signed-off-by: Sebastian Herbszt diff -urp linux/drivers/scsi/qla2xxx-orig/qla_def.h linux/drivers/scsi/qla2xxx/qla_def.h --- linux/drivers/scsi/qla2xxx-orig

[RESEND][PATCH] qla2xxx: use t10_pi_tuple

2015-07-12 Thread Sebastian Herbszt
Drop unused scsi_dif_tuple and use t10_pi_tuple instead of own sd_dif_tuple copy. Signed-off-by: Sebastian Herbszt diff -urp linux/drivers/scsi/qla2xxx-orig/qla_def.h linux/drivers/scsi/qla2xxx/qla_def.h --- linux/drivers/scsi/qla2xxx-orig/qla_def.h 2015-04-15 06:18:24.681045138 +0200

[RESEND][PATCH] lpfc: fix model description

2015-07-06 Thread Sebastian Herbszt
Remove trailing space from model description. Signed-off-by: Sebastian Herbszt Reviewed-By: James Smart diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c --- 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 2015-04-15 06:18:24.673045138 +0200 +++ 4.0/drivers/scsi

Re: [RFC PATCH 1/2] lpfc: add target infrastructure

2015-06-17 Thread Sebastian Herbszt
Hannes Reinecke wrote: > On 06/14/2015 05:20 PM, Sebastian Herbszt wrote: > > Add target infrastructure. > > > > Signed-off-by: Sebastian Herbszt > > --- > Hmm. And that hooks into _which_ target mode infrastructure? Currently it is SCST with the lpfc_scst module.

[RFC PATCH 2/2] lpfc: add target hooks

2015-06-14 Thread Sebastian Herbszt
Add target hooks. Signed-off-by: Sebastian Herbszt --- diff -upNr 4.1-rc7.orig/drivers/scsi/Kconfig 4.1-rc7/drivers/scsi/Kconfig --- 4.1-rc7.orig/drivers/scsi/Kconfig 2015-05-31 10:05:16.189204634 +0200 +++ 4.1-rc7/drivers/scsi/Kconfig2015-06-14 16:33:02.479543894 +0200 @@ -1299,6

[RFC PATCH 1/2] lpfc: add target infrastructure

2015-06-14 Thread Sebastian Herbszt
Add target infrastructure. Signed-off-by: Sebastian Herbszt --- diff -upNr 4.1-rc7.orig/drivers/scsi/lpfc/lpfc_target_api.c 4.1-rc7/drivers/scsi/lpfc/lpfc_target_api.c --- 4.1-rc7.orig/drivers/scsi/lpfc/lpfc_target_api.c1970-01-01 01:00:00.0 +0100 +++ 4.1-rc7/drivers/scsi/lpfc

Re: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

2015-06-02 Thread Sebastian Herbszt
phba->cfg_sg_seg_cnt; > - lpfc_template.sg_tablesize = phba->cfg_sg_seg_cnt; > + lpfc_template_s3.sg_tablesize = phba->cfg_sg_seg_cnt; > > /* There are going to be 2 reserved BDEs: 1 FCP cmnd + 1 FCP rsp */ > if (phba->cfg_enable_bg) { Reviewed-by: Sebastian

Re: [PATCH] lpfc: fix model description

2015-05-27 Thread Sebastian Herbszt
I wrote: > Remove trailing space from model description. > > Signed-off-by: Sebastian Herbszt > > diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c > 4.0/drivers/scsi/lpfc/lpfc_init.c > --- 4.0/drivers/scsi/lpfc.orig/lpfc_init.c2015-04-15 06:18:24.673045138 > +020

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-27 Thread Sebastian Herbszt
James Smart wrote: > Sebastian, > > Re: more than 1 space between a type declaration and a variable name - I > do not believe that's a hard requirement. It fully passes checkpatch. > Yes, consistent style use (aligning all variable names at same offset, > or always 1) would be good - but code h

Re: [PATCH 8/9] lpfc: Fix to drop PLOGIs from fabric node till LOGO processing completes

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Fix to drop PLOGIs from fabric node till LOGO processing completes > > The domain controller PLOGI's concurrent with prior LOGO's/unreg_rpi's > completing created a race condition where driver rpi ref count can > inadvertantly hit 0 and the rpi attempted to be freed. This e

Re: [PATCH 7/9] lpfc: Fix scsi task management error message.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Fix scsi task management error message. > > TMF's were getting error messages on FCP_RSP errors (underrun). Underruns > aren't meaningful in the scenario. Change the error message to filter out > these response check errors, and don't unconditionally mark the cmd as > in er

Re: [PATCH 6/9] lpfc: Fix cq_id masking problem.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Fix cq_id masking problem. > > The driver inadvertainly constrained the id space to 8 bits, when its inadvertently, it's > a full 16 bits from hw. This resulted in bad id's being written to the > hardware. Resulted in symptoms such as incomplete initialization, no > detec

Re: [PATCH 4/9] lpfc: Add support for using block multi-queue

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Add support for using block multi-queue > > With blk-mq support in the mid-layer, lpfc can do IO steering based > on the information in the request tag. This patch allows lpfc to use two spaces > blk-mq if enabled. If not enabled, we fall back into the emulex-internal >

Re: [PATCH 3/9] lpfc: Devices are not discovered during takeaway/giveback testing

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Devices are not discovered during takeaway/giveback testing > > When a remote nport changes it's DID, a new ndlp is used. its > However, we left the old ndlp state unchanged and still in > a discovery state. The may stall discovery resulting in some The? > devices not b

Re: [PATCH 1/9] lpfc: Check for active portpeerbeacon.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Check for active portpeerbeacon. > > LCB requests to set Beacon would fail if the beacon was already enabled beacon > internally as the mailbox command used to query the state failes with fails > an already-set status. > > Correct by enhancing the check so we don't fai

Re: [PATCH v2 06/15] lpfc: Add support for RDP ELS command.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Add support for RDP ELS command. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_crtn.h | 2 + > drivers/scsi/lpfc/lpfc_els.c | 420 > ++ > dr

Re: [PATCH v2 03/15] lpfc: Add support for ELS LCB.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Add support for ELS LCB. > > Also has a little whitespace fixing. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_els.c | 239 > +- > drivers/s

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Fix rport leak. > > Correct locking and refcounting in tracking our rports > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_disc.h| 4 +- > drivers/scsi/lpfc/lpfc_els.c | 12 +++- > drivers/scsi/lpfc/lpfc_hbadisc.c |

Re: [PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

2015-05-24 Thread Sebastian Herbszt
_NN, 0, 0); > lpfc_ns_cmd(vport, SLI_CTNS_RSPN_ID, 0, 0); > lpfc_ns_cmd(vport, SLI_CTNS_RFT_ID, 0, 0); > + lpfc_ns_cmd(vport, SLI_CTNS_RFF_ID, 0, 0); > > /* Issue SCR just before NameServer GID_FT Query */ > lpfc_issue_els_scr(vpor

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

2015-05-23 Thread Sebastian Herbszt
I wrote: > Alexey Kardashevskiy wrote: > > On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: > > > James Smart wrote: > > >> > > >> Reviewed-By: James Smart > > >> > > >> > > >> Alexey, Sebastian, > > >> >

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

2015-05-22 Thread Sebastian Herbszt
Alexey Kardashevskiy wrote: > On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: > > James Smart wrote: > >> > >> Reviewed-By: James Smart > >> > >> > >> Alexey, Sebastian, > >> > >> Yes - this section needs to be reverted.

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

2015-04-28 Thread Sebastian Herbszt
Alexey Kardashevskiy wrote: > This reverts 4fbdf9cb is breaks LPFC on POWER7 machine, big endian kernel. > > This is the hardware used for verification: > 0005:01:00.0 Fibre Channel [0c04]: Emulex Corporation Saturn-X: LightPulse > Fibre Channel Host Adapter [10df:f100] (rev 03) > 0005:01:00.1 Fi

Re: [PATCH] lpfc: fix model description

2015-04-26 Thread Sebastian Herbszt
Bart Van Assche wrote: > On 04/22/15 23:16, Sebastian Herbszt wrote: > > Remove trailing space from model description. > > > > Signed-off-by: Sebastian Herbszt > > > > diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c > > 4.0/drivers/scsi/lpfc/lpfc_in

Re: [RFC PATCH 2/2] lpfc: add target hooks

2015-04-24 Thread Sebastian Herbszt
Andy Grover wrote: > On 04/12/2015 07:17 AM, Sebastian Herbszt wrote: > > Add target hooks. > > > > Signed-off-by: Sebastian Herbszt > > > +#ifdef LPFC_TARGET_MODE > > +#include "lpfc_target_api.h" > > +#include "lpfc_target_api_base.h&qu

[PATCH] lpfc: fix model description

2015-04-22 Thread Sebastian Herbszt
Remove trailing space from model description. Signed-off-by: Sebastian Herbszt diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c --- 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 2015-04-15 06:18:24.673045138 +0200 +++ 4.0/drivers/scsi/lpfc/lpfc_init.c 2015-04

Re: [PATCH v3 10/20] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: > Fixes those things that parse the result of what data is registered with > the fabric. > > -- james Any particular "thing" you got on your mind? qla2xxx does not provide this information (yet). Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-scs

Re: [PATCH 06/14] lpfc: Add support for RDP ELS command.

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: > > Add support for RDP ELS command. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_crtn.h | 2 + > drivers/scsi/lpfc/lpfc_els.c | 415 > ++ > dr

Re: [PATCH 03/14] lpfc: Add support for ELS LCB.

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: > > Add support for ELS LCB. > > Also has a little whitespace fixing. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_els.c | 239 > +- > drivers/s

Re: [PATCH 01/14] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: > > The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc

Re: [PATCH v3 18/20] lpfc: Fix for lun discovery issue with saturn adapter.

2015-04-18 Thread Sebastian Herbszt
I wrote: > James Smart wrote: > > > > Fix for lun discovery issue with saturn adapter. > > > > FCP_CMD payload was not always properly initialized on SLI-3 devices. > > > > Signed-off-by: Dick Kennedy > > Signed-off-by: James Smart > > --- > > drivers/scsi/lpfc/lpfc_scsi.c | 41 > > +

Re: [PATCH v3 18/20] lpfc: Fix for lun discovery issue with saturn adapter.

2015-04-18 Thread Sebastian Herbszt
James Smart wrote: > > Fix for lun discovery issue with saturn adapter. > > FCP_CMD payload was not always properly initialized on SLI-3 devices. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_scsi.c | 41 - >

lpfc: Unknown ELS command x18 received from NPORT xfffc2b

2015-04-14 Thread Sebastian Herbszt
We recently started to get [8043768.238110] lpfc :10:00.1: 1:(0):0115 Unknown ELS command x18 received from NPORT xfffc2b [8130462.560283] lpfc :10:00.1: 1:(0):0115 Unknown ELS command x18 received from NPORT xfffc2b [8216439.442882] lpfc :10:00.1: 1:(0):0115 Unknown ELS command x18

Re: [PATCH v3 10/20] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

2015-04-14 Thread Sebastian Herbszt
James Smart wrote: > > Fix provide host name and OS name in RSNN-NN FC-GS command > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_ct.c | 21 +++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/

[RFC PATCH 2/2] lpfc: add target hooks

2015-04-12 Thread Sebastian Herbszt
Add target hooks. Signed-off-by: Sebastian Herbszt --- diff -uNrp 4.0-rc7.orig/drivers/scsi/Kconfig 4.0-rc7/drivers/scsi/Kconfig --- 4.0-rc7.orig/drivers/scsi/Kconfig 2015-04-12 12:52:36.830558971 +0200 +++ 4.0-rc7/drivers/scsi/Kconfig2015-04-12 12:53:01.582559694 +0200 @@ -1299,6

[RFC PATCH 1/2] lpfc: add target infrastructure

2015-04-12 Thread Sebastian Herbszt
Add target infrastructure. Signed-off-by: Sebastian Herbszt --- diff -uNrp 4.0-rc7.orig/drivers/scsi/lpfc/lpfc_target_api.c 4.0-rc7/drivers/scsi/lpfc/lpfc_target_api.c --- 4.0-rc7.orig/drivers/scsi/lpfc/lpfc_target_api.c1970-01-01 01:00:00.0 +0100 +++ 4.0-rc7/drivers/scsi/lpfc

Re: [PATCH 01/21] lpfc: Fix the iteration count to match the 30 sec comment in the routine lpfc_pci_function_reset

2015-04-05 Thread Sebastian Herbszt
ba.u.if_type2. > STATUSregaddr, ®_data.word0)) { > rc = -ENODEV; Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

2015-04-05 Thread Sebastian Herbszt
James Smart wrote: > Fix provide host name and OS name in RSNN-NN FC-GS command > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_ct.c | 21 +++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpf

Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

2015-04-05 Thread Sebastian Herbszt
James Smart wrote: > Implement support for wire-only DIF devices > > This patch adds the ability to support auto-enablement of wire-only DIF > (DIF is generated on TX to target, stripped on RX; OS unaware DIF in use) > for a select set of devices. Currently, there is only 1 device vendor > support

Re: [PATCH] scsi_scan: Send TEST UNIT READY to LUN0 before LUN scanning

2014-12-04 Thread Sebastian Herbszt
Hannes Reinecke wrote: > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c > index 49014a1..4f446e3 100644 > --- a/drivers/scsi/scsi_devinfo.c > +++ b/drivers/scsi/scsi_devinfo.c > @@ -166,6 +166,7 @@ static struct { > {"easyRAID", "X6P", NULL, BLIST_NOREPORTLUN}, >

[PATCH] scsi_host: fix comment

2014-09-20 Thread Sebastian Herbszt
Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the order of Scsi_Host members. Update the comment to reflect this. Signed-off-by: Sebastian Herbszt diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index ba20347..d4e0509 100644 --- a/include/scsi/scsi_ho