{
> + zone_blocks = 0;
> goto out;
> + }
>
> same = buf[4] & 0x0f;
> if (same > 0) {
> --
> 2.9.0
>
Reviewed-by: Shaun Tancheff
--
Shaun Tancheff
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer wrote:
> Damien Le Moal writes:
>
>> + if (!is_power_of_2(zone_blocks)) {
>> + if (sdkp->first_scan)
>> + sd_printk(KERN_NOTICE, sdkp,
>> + "Devices with non power of 2 zone "
>> +
On Thu, Oct 13, 2016 at 6:00 PM, Adam Manzanares
wrote:
> The request priority is now by default coming from the ioc. It was not
> clear what this code was trying to do based upon the iopriority class or
> data. The driver should check that a device supports priorities and use
> them according to
Shaun Tancheff
* Removed confusing use of 512B sector units in functions
interface]
Signed-off-by: Damien Le Moal
Reviewed-by: Christoph Hellwig
Reviewed-by: Shaun Tancheff
Tested-by: Shaun Tancheff
---
Changes from v5:
* Rebased on Jens' for-4.9/block branch (v5 is bas
zones of the device.
Signed-off-by: Hannes Reinecke
[Damien: * Removed the zone cache
* Implement report zones operation based on earlier proposal
by Shaun Tancheff ]
Signed-off-by: Damien Le Moal
Reviewed-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by
zone information result is passed as an array
of struct blk_zone identical to the structure used internally for
processing the REQ_OP_ZONE_REPORT operation. The BLKRESETZONE ioctl
maps to a single call of the blkdev_reset_zones function.
Signed-off-by: Shaun Tancheff
Signed-off-by: Damien Le
: Martin K. Petersen
Reviewed-by: Shaun Tancheff
Tested-by: Shaun Tancheff
---
Documentation/ABI/testing/sysfs-block | 13 +
block/blk-sysfs.c | 11 +++
2 files changed, 24 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-block
b/Documentation/A
From: Hannes Reinecke
Signed-off-by: Hannes Reinecke
Signed-off-by: Damien Le Moal
Reviewed-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Shaun Tancheff
Tested-by: Shaun Tancheff
---
block/blk-settings.c | 4
1 file changed, 4 insertions(+)
diff --git a/block
From: Shaun Tancheff
Define REQ_OP_ZONE_REPORT and REQ_OP_ZONE_RESET for handling zones of
host-managed and host-aware zoned block devices. With with these two
new operations, the total number of operations defined reaches 8 and
still fits with the 3 bits definition of REQ_OP_BITS.
Signed-off
Signed-off-by: Damien Le Moal
Reviewed-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Shaun Tancheff
Tested-by: Shaun Tancheff
---
Documentation/ABI/testing/sysfs-block | 16
block/blk-settings.c | 1 +
block/blk-sysfs.c | 18
This series introduces support for zoned block devices. It integrates
earlier submissions by Hannes Reinecke, Damien Le Moal and Shaun Tancheff.
Compared to the previous series version, the code was significantly
simplified by limiting support to zoned devices satisfying the following
conditions
Hello Bart,
I rebased this series on Jens for-4.9/block and will repost.
Thanks!
--Shaun
On Fri, Sep 30, 2016 at 12:18 PM, Bart Van Assche
wrote:
> On 09/30/2016 09:47 AM, Shaun Tancheff wrote:
>> On Fri, Sep 30, 2016 at 11:10 AM, Bart Van Assche
>> wrote:
>>> On 0
lNlVTT7Ugl8V50qIHLe856QW0qfG3WVYGOrWzA&m=VY30muznazMHPib_ks7gWROq97LIrq37TtKOXyYliB0&s=s2DsgBOJACiLmv56Aw-uehcdexEfBe73hSnqZDfB0xY&e=
--
Shaun Tancheff
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
* Modified sd_zbc_read_zones to include checks that the
>device satisfies the kernel constraints
> * Implemeted REPORT ZONES setup and post-processing based
>on code from Shaun Tancheff ]
> Signed-off-by: Damien Le Moal
> ---
> drivers
ev_zone_size are also provided for, as the name suggest,
> obtaining the zone size (in 512B sectors) of the zones of the device.
>
> Signed-off-by: Hannes Reinecke
>
> [Damien: * Removed the zone cache
> * Implement report zones operation based on earlier proposal
>
t;
> + if (b->chunk_sectors)
> + t->chunk_sectors = min_not_zero(t->chunk_sectors,
> + b->chunk_sectors);
> +
> return ret;
> }
> EXPORT_SYMBOL(blk_stack_limits);
> --
> 2.7.4
Reviewed-by: Shau
@@ -555,6 +565,7 @@ static struct attribute *default_attrs[] = {
> &queue_hw_sector_size_entry.attr,
> &queue_logical_block_size_entry.attr,
> &queue_physical_block_size_entry.attr,
> + &queue_chunk_sectors_entry.attr,
> &queue_io_min_en
-1354,6 +1381,26 @@ static inline unsigned int bdev_write_same(struct
> block_device *bdev)
> return 0;
> }
>
> +static inline enum blk_zoned_model bdev_zoned_model(struct block_device
> *bdev)
> +{
> + struct request_queue *q = bdev_get_queue(bdev);
>
t;
> + if (b->chunk_sectors)
> + t->chunk_sectors = min_not_zero(t->chunk_sectors,
> + b->chunk_sectors);
> +
> return ret;
> }
> EXPORT_SYMBOL(blk_stack_limits);
> --
> 2.7.4
Reviewed-by: Sha
ntry.attr,
> &queue_physical_block_size_entry.attr,
> + &queue_chunk_sectors_entry.attr,
> &queue_io_min_entry.attr,
> &queue_io_opt_entry.attr,
> &queue_discard_granularity_entry.attr,
> --
> 2.7.4
Reviewed-by: Shaun Tancheff
Tested-by: Shaun
v_write_same(struct
> block_device *bdev)
> return 0;
> }
>
> +static inline enum blk_zoned_model bdev_zoned_model(struct block_device
> *bdev)
> +{
> + struct request_queue *q = bdev_get_queue(bdev);
> +
> + if (q)
> + return blk_queue_
off-by: Hannes Reinecke
>
> [Damien: * Removed zone cache support
> * Removed mapping of discard to reset write pointer command
> * Modified sd_zbc_read_zones to include checks that the
>device satisfies the kernel constraints
> * Implemeted REPORT ZONES set
zone information result is passed as an array
of struct blk_zone identical to the structure used internally for
processing the REQ_OP_ZONE_REPORT operation. The BLKRESETZONE ioctl
maps to a single call of the blkdev_reset_zones function.
Signed-off-by: Shaun Tancheff
Signed-off-by: Damien Le
zones of the device.
Signed-off-by: Hannes Reinecke
[Damien: * Removed the zone cache
* Implement report zones operation based on earlier proposal
by Shaun Tancheff ]
Signed-off-by: Damien Le Moal
---
Changes from v2:
- Added EXPORT_SYMBOL_GPL() per Damien
- Added uapi
> If you are not the intended recipient, any disclosure, copying, distribution
> or any action taken or omitted to be taken in reliance on it, is prohibited.
> If you have received this e-mail in error, please notify the sender
> immediately and delete the e-mail in its entirety from you
SEQWRITE_REQ,
>> - BLK_ZONE_TYPE_SEQWRITE_PREF,
>> -};
>
> Please don't move this code around after it was added just two
> patches earlier. I'd say just split adding the new blkzoned.h
> uapi header into a patch of it's own and add that before the
> c
fG3WVYGOrWzA&m=vJFB6pCywWtdvkgHz9Vc0jQz0xzeyZlr-7eCWYu88nM&s=yiQLPFpqmMrbqLZz1Jb3aNqOje2dRMLJHEzUDobwcXc&e=
--
Shaun Tancheff
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Sep 19, 2016 at 4:27 PM, Damien Le Moal wrote:
> From: Shaun Tancheff
>
> Adds the new BLKUPDATEZONES, BLKREPORTZONE, BLKRESETZONE,
> BLKOPENZONE, BLKCLOSEZONE and BLKFINISHZONE ioctls.
>
> BLKREPORTZONE implementation uses the device queue zone RB-tree by
> default
On Mon, Sep 19, 2016 at 4:27 PM, Damien Le Moal wrote:
> From: Hannes Reinecke
>
> Implement ZBC support functions to setup zoned disks and fill the
> block device zone information tree during the device scan. The
> zone information tree is also always updated on disk revalidation.
> This adds su
On Fri, Sep 9, 2016 at 10:36 AM, Tejun Heo wrote:
> Hello, Shaun.
>
> On Fri, Sep 09, 2016 at 10:26:44AM -0500, Shaun Tancheff wrote:
>> I'm looking into it now. Let me see if I can reproduce this on any of my
>> hardware.
>>
>> If not there are a couple of
Restrict support SCT Write Same to devices which also support ZAC where
support is required.
Reported-by: Mike Krinkin
Signed-off-by: Shaun Tancheff
---
drivers/ata/libata-scsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata
On Fri, Sep 9, 2016 at 10:36 AM, Tejun Heo wrote:
> Hello, Shaun.
>
> On Fri, Sep 09, 2016 at 10:26:44AM -0500, Shaun Tancheff wrote:
>> I'm looking into it now. Let me see if I can reproduce this on any of my
>> hardware.
>>
>> If not there are a couple of
On Thu, Aug 25, 2016 at 9:31 PM, Damien Le Moal wrote:
>
> Shaun,
>
> On 8/25/16 05:24, Shaun Tancheff wrote:
>>
>> (RESENDING to include f2fs, fs-devel and dm-devel)
>>
>> Add op flags to access to zone information as well as open, close
>> and reset zon
Tom,
In my opinion this patch you submitted is simply making the code less
safe against a buffer overflow without a sufficiently good reason.
In future please comment on other patches as replies to those patches.
Mixing them together is just confusing.
--Shaun
--
To unsubscribe from this list: s
(RESENDING to include f2fs, fs-devel and dm-devel)
Add support for ZBC ioctl's
BLKREPORT - Issue Report Zones to device.
BLKZONEACTION - Issue a Zone Action (Close, Finish, Open, or Reset)
Signed-off-by: Shaun Tancheff
---
v8:
- Changed ioctl for zone actions to a single ioctl
igned-off-by: Shaun Tancheff
---
v8:
- Added Finish Zone op
- Fixed report zones copy to user to work when HARDENED_USERCOPY is enabled
v6:
- Added GFP_DMA to gfp mask.
v5:
- In sd_setup_zone_action_cmnd, remove unused vars and fix switch indent
- In blk-lib fix documentation
v4:
- Rebase on
- Changed bi_rw to op_flags clarify sepeartion of bio op from flags.
- Fixed memory leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit message for first patch in series.
Shaun Tanch
On Mon, Aug 22, 2016 at 8:25 PM, Damien Le Moal wrote:
>
> Shaun,
>
> On 8/23/16 09:22, Shaun Tancheff wrote:
>> On Mon, Aug 22, 2016 at 6:57 PM, Damien Le Moal
>> wrote:
>> Also you may note that in my patch to get Host Aware working
>> with the zone cac
0, and make the SATL
> response with invalid CDB field if we catch that.
No that is not quite right you need to check if you are
overflowing either RBUF or sdp->sector_size.
> Though IMHO this is really NOT a reason that is strong enough to
> prevent this patch from entering the rep
On Tue, Aug 23, 2016 at 3:37 AM, Tom Yan wrote:
> On 23 August 2016 at 07:30, Shaun Tancheff wrote:
> If we really want/need to avoid hitting some real buffer limit (e.g.
> maximum length of scatter/gather list?), then we should in some way
> check n_block against that. If it is
On Mon, Aug 22, 2016 at 3:53 PM, Tom Yan wrote:
> On 22 August 2016 at 20:32, Shaun Tancheff wrote:
>> On Mon, Aug 22, 2016 at 3:07 PM, Tom Yan wrote:
>>> I don't see how that's possible. count / n_block will always be
>>> smaller than 65535 * ATA_MAX_TR
On Mon, Aug 22, 2016 at 6:57 PM, Damien Le Moal wrote:
>
> Shaun,
>
> On 8/22/16 13:31, Shaun Tancheff wrote:
> [...]
>> -int sd_zbc_setup_discard(struct scsi_disk *sdkp, struct request *rq,
>> - sector_t sector, unsigned int num_sectors)
>>
On Mon, Aug 22, 2016 at 3:07 PM, Tom Yan wrote:
> I don't see how that's possible. count / n_block will always be
> smaller than 65535 * ATA_MAX_TRIM_RNUM(64) = 4194240. Not to mention
> that isn't even a "buffer limit" anyway. By SG_IO do you mean like
> SCSI Write Same commands that issued with
On Mon, Aug 22, 2016 at 1:55 PM, wrote:
> From: Tom Yan
>
> In commit 5c79097a28c2 ("libata-scsi: reject WRITE SAME (16) with
> n_block that exceeds limit"), it is made sure that
> ata_set_lba_range_entries() will never be called with a request
> size (n_block) that is larger than the number of
On Mon, Aug 22, 2016 at 2:11 AM, Hannes Reinecke wrote:
> On 08/22/2016 06:34 AM, Shaun Tancheff wrote:
>> Currently the RB-Tree zone cache is fast and flexible. It does
>> use a rather largish amount of ram. This model reduces the ram
>> required from 120 bytes per zone to 1
On Sun, Aug 21, 2016 at 11:34 PM, Shaun Tancheff wrote:
> Currently the RB-Tree zone cache is fast and flexible. It does
> use a rather largish amount of ram. This model reduces the ram
> required from 120 bytes per zone to 16 bytes per zone with a
> moderate transformation of the blk
.
Signed-off-by: Shaun Tancheff
---
block/blk-core.c |2 +-
block/blk-sysfs.c | 31 +-
block/blk-zoned.c | 103 +++--
drivers/scsi/sd.c |5 +-
drivers/scsi/sd.h |4 +-
drivers/scsi/sd_zbc.c | 1025 +++-
include
Move the remaining ZBC specific code to sd_zbc.c
Signed-off-by: Shaun Tancheff
---
drivers/scsi/sd.c | 65 +--
drivers/scsi/sd.h | 20 ++
drivers/scsi/sd_zbc.c | 170 +++---
3 files changed, 126 insertions(+), 129
.
Shaun Tancheff (2):
Move ZBC core setup to sd_zbc
Migrate zone cache from RB-Tree to arrays of descriptors
block/blk-core.c |2 +-
block/blk-sysfs.c | 31 +-
block/blk-zoned.c | 103 +++--
drivers/scsi/sd.c | 66 +--
drivers/scsi/sd.h | 20 +-
drivers
Dedupe ZBC/ZAC constants used for reporting options, same code,
zone condition and zone type.
These are all useful to programs consuming zone information from
user space as well so include them in a uapi header.
Signed-off-by: Shaun Tancheff
---
block/blk-lib.c | 4
Finish zones having no other analog are sent directly
to the device.
On successful completion each zone action will update the zone cache
as appropriate.
Signed-off-by: Shaun Tancheff
---
block/blk-lib.c | 16 --
drivers/scsi/sd.c | 42 +++-
drivers/scsi/sd.h | 22 +-
drivers
when the WP indicates that 2000 blocks
in the zone are in use and the discard indicated 1000 blocks
can be unmapped the discard should fail as a Reset WP will
unmap all the 2000 blocks in the zone.
Signed-off-by: Shaun Tancheff
---
drivers/scsi/sd.c | 45 ++---
drivers/scsi/sd.h
heff/linux/tree/v4.8-rc2%2Bbiof.v9
g...@github.com:stancheff/linux.git v4.8-rc2+biof.v9
v2:
- Fully integrated bio <-> zone cache [<-> device]
- Added discard -> write same for conventional zones.
- Merged disparate constants into a canonical set.
Shaun Tancheff (4):
E
Seagate drives report a SAME code of 0 due to having:
- Zones of different types (CMR zones at the low LBA space).
- Zones of different size (A terminating 'runt' zone in the high
lba space).
Support loading the zone topology into the zone cache.
Signed-off-by: Shau
Add support for ZBC ioctl's
BLKREPORT - Issue Report Zones to device.
BLKZONEACTION - Issue a Zone Action (Close, Finish, Open, or Reset)
Signed-off-by: Shaun Tancheff
---
v8:
- Changed ioctl for zone actions to a single ioctl that takes
a structure including the zone,
eport zones currently defaults to reporting on all zones. It expected
that support for the zone option flag will piggy back on streamid
support. The report option flag is useful as it can reduce the number
of zones in each report, but not critical.
Signed-off-by: Shaun Tancheff
---
v8:
- Added Finish
op from flags.
- Fixed memory leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit message for first patch in series.
Shaun Tancheff (2):
Add bio/request flags to issue ZBC/ZAC co
On Tue, Aug 9, 2016 at 11:38 PM, Damien Le Moal wrote:
> Shaun,
>
> On 8/10/16 12:58, Shaun Tancheff wrote:
>>
>> On Tue, Aug 9, 2016 at 3:09 AM, Damien Le Moal
>> wrote:
>>>>
>>>> On Aug 9, 2016, at 15:47, Hannes Reinecke wrote:
>>
>&
On Mon, Aug 15, 2016 at 11:00 PM, Damien Le Moal wrote:
>
> Shaun,
>
>> On Aug 14, 2016, at 09:09, Shaun Tancheff wrote:
> […]
>>>>
>>> No, surely not.
>>> But one of the _big_ advantages for the RB tree is blkdev_discard().
>>> Withou
On Tue, Aug 9, 2016 at 1:47 AM, Hannes Reinecke wrote:
> On 08/05/2016 10:35 PM, Shaun Tancheff wrote:
>> On Tue, Aug 2, 2016 at 8:29 PM, Damien Le Moal
>> wrote:
>>> Hannes, Shaun,
>>>
>>> Let me add some more comments.
>>>
>>>> On
locks() wrapper.
Ah, I think I am understanding now. When the sector size is 4K the
minimum page sent with WRITE SAME will be 4K.
If so, we also need to fix the write_same SATL code that is working
under the assumption of a 512 byte sector sector as the largest
guaranteed amount of data in the
== BLK_ZONE_OFFLINE) {
> + /* let the drive fail the command */
> + sd_zbc_debug_ratelimit(sdkp,
> + "zone %zu offline\n",
> + zone->start);
> + goto out;
> +
In sd_setup_discard_cmnd() there are a some discard
methods that fall back to using WRITE_SAME. It
appears that those paths using WRITE_SAME should
also use the SD_WRITE_SAME_TIMEOUT instead of the
default SD_TIMEOUT.
Signed-off-by: Shaun Tancheff
---
I don't have a use case that break
On Thu, Aug 11, 2016 at 3:26 AM, wrote:
> From: Tom Yan
>
> Currently we advertise Maximum Write Same Length based on the
> maximum number of sectors that one-block TRIM payload can cover.
> The field are used to derived discard_max_bytes and
> write_same_max_bytes limits in the block layer, whi
0466-98-3593 (ext. 513593)
> 1 kirihara-cho, Fujisawa,
> Kanagawa, 252-0888 Japan
> www.hgst.com
>
> Western Digital Corporation (and its subsidiaries) E-mail Confidentiality
> Notice & Disclaimer:
>
> This e-mail and any files transmitted with it may contain co
On Tue, Aug 9, 2016 at 1:47 AM, Hannes Reinecke wrote:
> On 08/05/2016 10:35 PM, Shaun Tancheff wrote:
>> On Tue, Aug 2, 2016 at 8:29 PM, Damien Le Moal
>> wrote:
>>>> On Aug 2, 2016, at 23:35, Hannes Reinecke wrote:
>>>> On 08/01/2016 07:07 PM, Shaun Ta
On Tue, Aug 2, 2016 at 8:29 PM, Damien Le Moal wrote:
> Hannes, Shaun,
>
> Let me add some more comments.
>
>> On Aug 2, 2016, at 23:35, Hannes Reinecke wrote:
>>
>> On 08/01/2016 07:07 PM, Shaun Tancheff wrote:
>>> On Mon, Aug 1, 2016 at 4:41 AM, Chri
On Thu, Aug 4, 2016 at 10:46 AM, Christoph Hellwig wrote:
> On Wed, Aug 03, 2016 at 07:30:29PM -0500, Shaun Tancheff wrote:
>> I think the translation in loop.c is suspicious here:
>>
>> "if use DIO && not (a flush_flag or discard_flag)"
>> shoul
d83 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1659,8 +1659,9 @@ static int loop_queue_rq(struct blk_mq_hw_ctx *hctx,
if (lo->lo_state != Lo_bound)
return -EIO;
- if (lo->use_dio && (!(cmd->rq->cmd_flags & REQ_FLUSH) ||
-
Seagate drives report a SAME code of 0 due to having:
- Zones of different types (CMR zones at the low LBA space).
- Zones of different size (A terminating 'runt' zone in the high lba space).
Support loading the zone topology into the sd_zbc zone cache.
Signed-off-by: Shaun Tan
Signed-off-by: Shaun Tancheff
Cc: Hannes Reinecke
Cc: Damien Le Moal
Cc: Dan Williams
Cc: Sagi Grimberg
Cc: Mike Christie
Cc: Toshi Kani
Cc: Kent Overstreet
Cc: Ming Lei
---
block/blk-lib.c| 3 +-
block/blk-zoned.c | 190 +
block
sd: Implement new RESET_WP provisioning mode
sd: configure ZBC devices
...
Cc: Hannes Reinecke
Cc: Damien Le Moal
Shaun Tancheff (2):
bio/zbc support for zone cache
Enable support for Seagate HostAware drives (testing).
block/blk-lib.c| 3 +-
block/bl
ps://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=CwIBAg&c=IGDlg0lD0b-nebmJJ0Kp8A&r=Wg5NqlNlVTT7Ugl8V50qIHLe856QW0qfG3WVYGOrWzA&m=0ZPyN4vfYZXSmuCmIm3wpExF1K28PYO9KmgcqDsfQBg&s=aiguzw5_op7woZCZ5Qi7c36b16SxiWTJXshN0dG3Xyo&e=
--
Shaun T
return;
> + }
It's a bit unfortunate that you abort here. The current Seagate Host
Aware drives
must report a same code of 0 here due to the final 'runt' zone and are therefore
not supported by your RB-Tree in the following patches.
> + /* Read the zone l
d bit for ata-passthrough flag.
V2:
- Changed bi_rw to op_flags clarify sepeartion of bio op from flags.
- Fixed memory leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit messag
er
of zones in each report, but not critical.
Signed-off-by: Shaun Tancheff
---
v5:
- In sd_setup_zone_action_cmnd, remove unused vars and fix switch indent
- In blk-lib fix documentation
v4:
- Rebase on linux-next tag next-20160617.
- Change bio flags to bio op's
V3:
- Rebase on Mike
Add support for ZBC ioctl's
BLKREPORT- Issue Report Zones to device.
BLKOPENZONE - Issue Zone Action: Open Zone command.
BLKCLOSEZONE - Issue Zone Action: Close Zone command.
BLKRESETZONE - Issue Zone Action: Reset Zone command.
Signed-off-by: Shaun Tancheff
---
v6:
-
On Tue, Jun 21, 2016 at 9:43 PM, Martin K. Petersen
wrote:
>>>>>> "Shaun" == Shaun Tancheff writes:
>
> Shaun> SATA drives may support write same via SCT. This is useful for
> Shaun> setting the drive contents to a specific pattern (0's).
>
>
e for that operation.
Report zones currently defaults to reporting on all zones. It expected
that support for the zone option flag will piggy back on streamid
support. The report option flag is useful as it can reduce the number
of zones in each report, but not critical.
Signed-off-by: Shaun Tan
Add New ioctl types
BLKREPORT- Issue Report Zones to device.
BLKOPENZONE - Issue an Zone Action: Open Zone command.
BLKCLOSEZONE - Issue an Zone Action: Close Zone command.
BLKRESETZONE - Issue an Zone Action: Reset Zone command.
Signed-off-by: Shaun Tancheff
---
v4
to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit message for first patch in series.
Shaun Tancheff (2):
Add bio/request flags for using ZBC/ZAC commands
Add ioctl to issue ZBC/ZAC commands via block layer
M
TRIM but fail to zero blocks reliably. For example a
file-system or DM target could issue a write same w/o unmap followed
by an trim.
Signed-off-by: Shaun Tancheff
---
v3:
- Demux UNMAP/TRIM from WRITE SAME
v2:
- Remove fugly ata hacking from sd.c
---
drivers/ata/libata-scsi.c
...@github.com:stancheff/linux.git
branch: v4.7-rc2+sct-write-same.v3
v3:
- Demux UNMAP/TRIM from WRITE SAME
- Add offset from scatterlist to page address.
v2:
- Remove fugly ata hacking from sd.c
Shaun Tancheff (1):
Add support for SCT Write Same
drivers/ata/libata-scsi.c | 80
ry leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit message for first patch in series.
Shaun Tancheff (2):
Add bio/request flags for using ZBC/ZAC commands
Add ioctl to iss
Add New ioctl types
BLKREPORT- Issue Report Zones to device.
BLKOPENZONE - Issue an Zone Action: Open Zone command.
BLKCLOSEZONE - Issue an Zone Action: Close Zone command.
BLKRESETZONE - Issue an Zone Action: Reset Zone command.
Signed-off-by: Shaun Tancheff
---
v4
e for that operation.
Report zones currently defaults to reporting on all zones. It expected
that support for the zone option flag will piggy back on streamid
support. The report option flag is useful as it can reduce the number
of zones in each report, but not critical.
Signed-off-by: Shaun Tan
On Fri, Jun 10, 2016 at 2:19 AM, Hannes Reinecke wrote:
> On 06/10/2016 09:10 AM, Shaun Tancheff wrote:
>> The current generation of HBA SAS adapters support connecting SATA
>> drives and perform SCSI<->ATA translations in hardware.
>> Unfortunately the ZBC commands a
can reduce the number of
zones in each report, but not critical.
Signed-off-by: Shaun Tancheff
---
V3:
- Rebase on Mike Cristie's separate bio operations
- Update blkzoned_api.h to include report zones PARTIAL bit.
V2:
- Changed bi_rw to op_flags clarify sepeartion of bio op from flags.
can reduce the number of
zones in each report, but not critical.
Signed-off-by: Shaun Tancheff
---
V3:
- Rebase on Mike Cristie's separate bio operations
- Update blkzoned_api.h to include report zones PARTIAL bit.
V2:
- Changed bi_rw to op_flags clarify sepeartion of bio op from flags.
Add New ioctl types
BLKREPORT- Issue Report Zones to device.
BLKOPENZONE - Issue an Zone Action: Open Zone command.
BLKCLOSEZONE - Issue an Zone Action: Close Zone command.
BLKRESETZONE - Issue an Zone Action: Reset Zone command.
Signed-off-by: Shaun Tancheff
---
block
eartion of bio op from flags.
- Fixed memory leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit message for first patch in series.
Shaun Tancheff (3):
Add bio/request flags for
ds the meaning of REQ_META to direct ZBC commands
to construct ZAC equivalent ATA pass through commands.
Note also that this approach expects the initiator to deal with the
little endian result due to bypassing the normal translation layers.
Signed-off-by: Shaun Tancheff
---
So this patch isn'
low the SCT path
else fail with the current error (unmap is not set).
In this way if you device supports both TRIM and SCT then you can WRITE SAME
or TRIM.
> - Shouldn't we still translate discard command to TRIM? Maybe we
>need a check of the operation in the request st
data by mapping discard operations to
reset write pointer operations. Conventional zones that do not support
reset write pointer can still honor the discard zeroes data by issuing
a write same over the zone.
v2:
- Remove fugly ata hacking from sd.c
Shaun Tancheff (1):
Add support for SCT Write
SATA drives may support write same via SCT. This is useful
for setting the drive contents to a specific pattern (0's).
Signed-off-by: Shaun Tancheff
---
v2:
- Remove fugly ata hacking from sd.c
---
drivers/ata/libata-scsi.c | 34 ++
drivers/scsi
On Wed, Jun 8, 2016 at 10:39 PM, Martin K. Petersen
wrote:
>
> >>>>> "Shaun" == Shaun Tancheff writes:
>
> Shaun,
>
> Shaun> SATA drives may support write same via SCT. This is useful for
> Shaun> setting the drive contents to a specific patt
Add New ioctl types
BLKREPORT- Issue Report Zones to device.
BLKOPENZONE - Issue an Zone Action: Open Zone command.
BLKCLOSEZONE - Issue an Zone Action: Close Zone command.
BLKRESETZONE - Issue an Zone Action: Reset Zone command.
Signed-off-by: Shaun Tancheff
---
V2
ds the meaning of REQ_META to direct ZBC commands
to construct ZAC equivalent ATA pass through commands.
Note also that this approach expects the initiator to deal with the
little endian result due to bypassing the normal translation layers.
Signed-off-by: Shaun Tancheff
---
v2:
- Added REQ_M
can reduce the number of
zones in each report, but not critical.
Signed-off-by: Shaun Tancheff
---
V2:
- Changed bi_rw to op_flags clarify sepeartion of bio op from flags.
- Fixed memory leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Remov
emory leak in blkdev_issue_zone_report failing to put_bio().
- Documented opt in blkdev_issue_zone_report.
- Moved include/uapi/linux/fs.h changes to patch 3
- Fixed commit message for first patch in series.
Shaun Tancheff (4):
Losing bits on request.cmd_flags
Add bio/request flags for usin
1 - 100 of 134 matches
Mail list logo
