On 7/26/2013 7:15 PM, Seungwon Jeon wrote:
Fatal error in OCS(overall command status) field indicates
error conditions which is not covered by UFSHCI.
It means that host cannot define the result of command status
and therefore host may need to check transfer response UPIU's
response and status fi
On 7/26/2013 7:16 PM, Seungwon Jeon wrote:
Except for 'GOOD' and 'CHECK CONDITION', other status value
This is what UFS device spec says: "A GOOD status indicates successful
SCSI completion and therefore no Sense Data will be returned." So please
change the commit text accordingly.
in Response
On 7/26/2013 7:16 PM, Seungwon Jeon wrote:
LACTH(Interrupt aggregation counter threshold) value is allowed
I guess you mean "IACTH" not "LACTH". Other than this, change looks good
to me.
Reviewed-by: Subhash Jadavani
up to 0x1F and current setting value is the ma
On 7/26/2013 7:17 PM, Seungwon Jeon wrote:
Implements to support GET and SET operations of the DME.
These operations are used to configure the behavior of
the UNIPRO. Along with basic operation, {Peer/AttrSetType}
can be mixed.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/ufshcd.c | 88
Looks good to me.
Reviewed-by: Subhash Jadavani
On 7/26/2013 7:18 PM, Seungwon Jeon wrote:
'drivers/scsi/ufs/unipro.h' is added.
Attributes in the layers of the UNIPRO stack can be
read and written via the DME.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/unipr
Change looks good except few minor comments.
On 7/26/2013 7:18 PM, Seungwon Jeon wrote:
Setting PA_PWRMode using DME_SET triggers the power mode
change. And then the result will be given by the HCS.UPMCRS.
This operation should be done atomically.
Signed-off-by: Seungwon Jeon
---
drivers/scs
On 7/29/2013 3:35 PM, Seungwon Jeon wrote:
On Mon, July 29, 2013, Subhash Jadavani wrote:
On 7/26/2013 7:15 PM, Seungwon Jeon wrote:
Fatal error in OCS(overall command status) field indicates
error conditions which is not covered by UFSHCI.
It means that host cannot define the result of
Change looks good (except one minor question).
Reviewed-by: Subhash Jadavani
On 7/26/2013 7:19 PM, Seungwon Jeon wrote:
UIC attributes can be set with using DME_SET command for
power mode change. For configuration the link capability
attributes are used, which is updated after successful
link
On 7/30/2013 6:32 PM, Seungwon Jeon wrote:
On Mon, July 29, 2013, Sujit Reddy Thumma wrote:
On 7/29/2013 11:47 AM, Subhash Jadavani wrote:
On 7/26/2013 7:15 PM, Seungwon Jeon wrote:
Fatal error in OCS(overall command status) field indicates
error conditions which is not covered by UFSHCI.
It
On 7/30/2013 6:32 PM, Seungwon Jeon wrote:
On Mon, July 29, 2013, Subhash Jadavani wrote:
On 7/26/2013 7:17 PM, Seungwon Jeon wrote:
Implements to support GET and SET operations of the DME.
These operations are used to configure the behavior of
the UNIPRO. Along with basic operation, {Peer
On 8/6/2013 5:38 PM, Seungwon Jeon wrote:
On Wednesday, July 31, 2013, Subhash Jadavani wrote:
Change looks good (except one minor question).
Reviewed-by: Subhash Jadavani
On 7/26/2013 7:19 PM, Seungwon Jeon wrote:
UIC attributes can be set with using DME_SET command for
power mode change
On 8/13/2013 5:20 PM, Seungwon Jeon wrote:
On Mon, August 12, 2013, Subhash Jadavani wrote:
On 7/30/2013 6:32 PM, Seungwon Jeon wrote:
On Mon, July 29, 2013, Sujit Reddy Thumma wrote:
On 7/29/2013 11:47 AM, Subhash Jadavani wrote:
On 7/26/2013 7:15 PM, Seungwon Jeon wrote:
Fatal error in
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/27/2013 9:48 AM, Sujit Reddy Thumma wrote:
Some vendor specific controller versions might need to configure
vendor specific - registers, clocks, voltage regulators etc. to
initialize the host controller UTP layer and Uni-Pro stack.
Provide
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/27/2013 9:48 AM, Sujit Reddy Thumma wrote:
Add generic clock initialization support for UFSHCD platform
driver. The clock info is read from device tree using standard
clock bindings. A generic max-clock-frequency-hz property is
defined to
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/25/2013 4:06 PM, Dolev Raviv wrote:
In interrupt context, after reading and comparing the UTRLDBR to
hba->outstanding_request and before resetting the interrupt aggregation,
there might be completion of another transfer request (TR). S
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/27/2013 9:48 AM, Sujit Reddy Thumma wrote:
UFS devices are powered by at most three external power supplies -
- VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V
- VCCQ - The controller and I/O power supply, 1.1V to
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
Unlike 'GOOD' and 'CHECK CONDITION', other status values in
Response UPIU may or may not contain sense data. That is returning
sense data isn't obvious. So, in this case the
On 8/27/2013 1:50 PM, Subhash Jadavani wrote:
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/25/2013 4:06 PM, Dolev Raviv wrote:
In interrupt context, after reading and comparing the UTRLDBR to
hba->outstanding_request and before resetting the interrupt aggregation,
there might
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
IACTH(Interrupt aggregation counter threshold) value is allowed
up to 0x1F and current setting value is the maximum.
This value is related with NUTRS(max:0x20) of HCI's capability.
Considerin
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
'drivers/scsi/ufs/unipro.h' is added.
Attributes in the layers of the UNIPRO stack can be
read and written via the DME.
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
---
dr
Looks good to me.
Reviewed-by: Subhash Jadavani
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
Implements to support GET and SET operations of the DME.
These operations are used to configure the behavior of
the UNIPRO. Along with basic operation, {Peer/AttrSetType}
can be mixed.
Signed-off-by
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
Setting PA_PWRMode using DME_SET triggers the power mode
change. And then the result will be given by the HCS.UPMCRS.
This operation should be done atomically.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/ufshcd.c | 84
On 8/26/2013 8:11 PM, Seungwon Jeon wrote:
UIC attributes can be set with using DME_SET command for
power mode change. For configuration the link capability
attributes are used, which is updated after successful
link startup.
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
On 8/27/2013 3:51 PM, Subhash Jadavani wrote:
On 8/26/2013 8:11 PM, Seungwon Jeon wrote:
UIC attributes can be set with using DME_SET command for
power mode change. For configuration the link capability
attributes are used, which is updated after successful
link startup.
Signed-off-by
On 8/27/2013 4:58 PM, Seungwon Jeon wrote:
On Tue, August 27, 2013, Subhash Jadavani wrote:
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
Setting PA_PWRMode using DME_SET triggers the power mode
change. And then the result will be given by the HCS.UPMCRS.
This operation should be done atomically
Hi Santosh,
These patches looks good to me (Have already gave Reviewed-by to all
patches). Please check if its fine to be pushed to scsi-next?
Regards,
Subhash
On 8/26/2013 8:10 PM, Seungwon Jeon wrote:
This path series contain driver's fixes and updates.
Changes in v3:
- Rebased with scs
On 9/21/2013 12:06 PM, Akinobu Mita wrote:
The data byte count field of PRDT indicates the length of data block
which is a segment of data transfer for SCSI commands. The value of
this field shall have Dword granularity and the the maximum of length
is 256KB.
This adjusts dma pad mask and max s
Looks good to me.
Reviewed-by: Subhash Jadavani
On 9/25/2013 7:17 PM, Akinobu Mita wrote:
The data byte count field of PRDT indicates the length of data block
which is a segment of data transfer for SCSI commands. The value of
this field shall have Dword granularity and the the maximum of
11:59 AM
To: Dolev Raviv
Cc: james.bottom...@hansenpartnership.com; h...@infradead.org;
linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org;
linux-arm-...@vger.kernel.org; santos...@gmail.com; Subhash Jadavani; Sujit
Reddy Thumma; Martin K. Petersen
Subject: Re: [PATCH V3 01/16] scsi: supp
Regards,
Subhash
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of 'Christoph Hellwig'
Sent: Saturday, September 13, 2014 11:55 AM
To: Subhash Jadavani
Cc: 'Christoph Hellwig'; 'Dolev Raviv';
james.botto
g
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Subhash Jadavani
Sent: Thursday, September 18, 2014 10:18 AM
To: 'Christoph Hellwig'
Cc: 'Dolev Raviv'; james.bottom...@hansenpartnership.com;
linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org;
linux-arm-...@vger.ke
stoph Hellwig'
Sent: Monday, September 22, 2014 7:29 AM
To: Subhash Jadavani
Cc: 'Dolev Raviv'; james.bottom...@hansenpartnership.com;
linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org;
linux-arm-...@vger.kernel.org; santos...@gmail.com; 'Sujit Reddy Thumma';
'Mart
Raviv; james.bottom...@hansenpartnership.com; h...@infradead.org;
linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org;
linux-arm-...@vger.kernel.org; santos...@gmail.com; Subhash Jadavani
Subject: Re: [PATCH V4 09/17] scsi: ufs: manually add well known logical
units
> None of the REP
hip.com; h...@infradead.org;
linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org;
linux-arm-...@vger.kernel.org; santos...@gmail.com; Subhash Jadavani; Sujit
Reddy Thumma
Subject: Re: [PATCH V4 11/17] scsi: ufs: add UFS power management support
>> /**
>> * ufsh
mes.bottom...@hansenpartnership.com; h...@infradead.org;
linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org;
linux-arm-...@vger.kernel.org; santos...@gmail.com; Subhash Jadavani
Subject: Re: [PATCH V5 02/17] scsi: sysfs: don't add scsi_device if its
already added
On Wed, Sep 24,
-...@vger.kernel.org; santos...@gmail.com; Subhash Jadavani; Sujit
Reddy Thumma
Subject: Re: [PATCH V5 10/17] scsi: ufs: manually add well known logical
units
> /**
> + * ufshcd_set_queue_depth - set lun queue depth
> + * @sdev: pointer to SCSI device
> + *
> + * Read bLUQueueDepth val
ufs driver removal so we
can remove these manually added devices immediately after it. Next patch
revision should fix it.
-Original Message-
From: 'Christoph Hellwig' [mailto:h...@infradead.org]
Sent: Wednesday, September 24, 2014 9:41 AM
To: Subhash Jadavani
Cc: 'Christ
14 9:38 AM
To: Subhash Jadavani
Cc: 'Christoph Hellwig'; 'Dolev Raviv';
james.bottom...@hansenpartnership.com; linux-scsi@vger.kernel.org;
linux-scsi-ow...@vger.kernel.org; linux-arm-...@vger.kernel.org;
santos...@gmail.com
Subject: Re: [PATCH V5 02/17] scsi: sysfs: don't add sc
Storage)
Sent: Wednesday, September 24, 2014 1:50 PM
To: Christoph Hellwig; Dolev Raviv
Cc: james.bottom...@hansenpartnership.com; linux-scsi@vger.kernel.org;
linux-scsi-ow...@vger.kernel.org; linux-arm-...@vger.kernel.org;
santos...@gmail.com; Subhash Jadavani; Sujit Reddy Thumma; Martin K.
t: Friday, October 03, 2014 9:16 AM
To: Dolev Raviv
Cc: Jej B; Christoph Hellwig; linux-scsi@vger.kernel.org;
linux-scsi-ow...@vger.kernel.org; linux-arm-...@vger.kernel.org; Santosh Y;
Subhash Jadavani
Subject: Re: [PATCH V6 10/18] scsi: ufs: manually add well known logical units
2014-09-25 21:32
> If the UFS Power management level 5 is chosen, the UIC link is down during
> suspend. And the power mode should be configured during resume again.
> Unfortunately, it will not be configured because the above condition hits
> unintentionally.
Yes, it seems a bug.
> I would like to propose a
2014 12:21 AM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita; Akinobu Mita; Vinayak Holikatti; Santosh Y; Dolev Raviv;
Subhash Jadavani; Yaniv Gardi; Christoph Hellwig; James E.J. Bottomley
Subject: [PATCH -next] scsi: ufs: fix configuring power mode after UIC link
down
If the UFS Power management level
Looks good, Reviewed-by: Subhash Jadavani
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Dolev Raviv
Sent: Sunday, October 05, 2014 7:10 AM
To: james.bottom...@hansenpartnership.com; h...@infradead.org
Cc: linux-scsi
k if not earlier.
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig
Sent: Tuesday, October 21, 2014 7:06 AM
To: Subhash Jadavani
Cc: 'Dolev Raviv'; james.bottom...@hansenpartnership.com;
linux-scsi@vger
Reviewed-by: Subhash Jadavani
-Original Message-
From: Akinobu Mita [mailto:akinobu.m...@gmail.com]
Sent: Tuesday, November 18, 2014 6:03 AM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita; Akinobu Mita; Vinayak Holikatti; Subhash Jadavani; Dolev
Raviv; Sujit Reddy Thumma; Yaniv Gardi
Looks good to me,
Reviewed-by: Subhash Jadavani
-Original Message-
From: Akinobu Mita [mailto:akinobu.m...@gmail.com]
Sent: Tuesday, November 18, 2014 6:03 AM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita; Akinobu Mita; Vinayak Holikatti; Dolev Raviv; Subhash
Jadavani; Yaniv Gardi
Looks good to me.
Reviewed-by: Subhash Jadavani
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Akinobu Mita
Sent: Sunday, November 23, 2014 9:24 PM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita; Akinobu Mita; Vinayak
Few comments inline:
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
From: Vinayak Holikatti
This patch seggregates the PCI specific code in ufshcd.c to make it
ready for splitting into core ufs driver and PCI glue driver. Also
copyright header modification to remove extra warranty discl
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
From: Vinayak Holikatti
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 11
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
From: Vinayak Holikatti
This patch separates PCI code from ufshcd.c and makes it as a
core driver module and adds a new file ufshcd-pci.c as PCI glue
driver.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holika
On 1/4/2013 12:30 PM, vinayak holikatti wrote:
On Thu, Dec 27, 2012 at 7:59 PM, Subhash Jadavani
wrote:
Few comments inline:
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
From: Vinayak Holikatti
This patch seggregates the PCI specific code in ufshcd.c to make it
ready for splitting
On 1/4/2013 1:07 PM, vinayak holikatti wrote:
On Thu, Dec 27, 2012 at 8:28 PM, Subhash Jadavani
wrote:
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
From: Vinayak Holikatti
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Signed
On 1/11/2013 4:11 PM, Sujit Reddy Thumma wrote:
On 1/9/2013 5:41 PM, vinayak holikatti wrote:
On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma
wrote:
Hi Vinayak,
I have few comments below:
+#ifdef CONFIG_PM
+/**
+ * ufshcd_pltfrm_suspend - suspend power management function
+ * @pdev: poi
-gather nodes.
Signed-off-by: Subhash Jadavani
---
block/blk-merge.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 936a110..623fca5 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -42,6 +42,9 @@ static unsigned
-gather nodes.
Signed-off-by: Subhash Jadavani
---
block/blk-merge.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 936a110..6eaef3d4 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -42,6 +42,9 @@ static unsigned
On 1/15/2013 9:49 PM, James Bottomley wrote:
On Tue, 2013-01-15 at 21:31 +0530, Subhash Jadavani wrote:
blk_rq_map_sg() function merges the physically contiguous pages to use same
scatter-gather node without checking if their page descriptors are
contiguous or not.
Now when dma_map_sg() is
On 1/16/2013 4:02 PM, James Bottomley wrote:
On Wed, 2013-01-16 at 12:07 +0530, Subhash Jadavani wrote:
Now consider this call stack from MMC block driver (this is on the ARmv7
based board):
[ 98.918174] [] (v7_dma_inv_range+0x30/0x48) from
[] (dma_cache_maint_page+0x1c4/0x24c
oblem test this patch?
Yes, this patch also fixes the issue. You may add: Tested-by: Subhash
Jadavani .
Regards,
Subhash
arch/arm/mm/dma-mapping.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.
Looks good. Reviewed-by: Subhash Jadavani
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
> Move the ufshcd_hba_stop from header file.
>
> Signed-off-by: Seungwon Jeon
> ---
> drivers/scsi/ufs/ufshcd.c |9 +
> drivers/scsi/ufs/ufshcd.h |9 -
> 2 files
On 4/26/2013 10:36 AM, Seungwon Jeon wrote:
Hi,
On Thursday, April 25, 2013, Sujit Reddy Thumma wrote:
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/ufshcd.c | 106
+++--
Patch looks good but one minor comment below.
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
It makes interrupt setting more flexible especially
for disabling. And wrong bit mask is fixed for ver 1.0.
[17:16] is added for mask.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/ufshcd.c | 86 ++
Few minor comments other than what Sujit/Santosh have already commented.
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Link start-up requires long time with multiphase handshakes
between UFS host and device. This affects driver's probe time.
This patch let link start-up run asynchronously.
And comp
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Add uic command operations including DME_XXX series.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/ufs-attrs.h | 129
drivers/scsi/ufs/ufshcd.c| 220 +-
drivers/scsi/ufs/ufs
From: Sahitya Tummala
Provide an option to enable/disable clock scaling during runtime.
Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock
scaling.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
are skipped
and the last step, reset and restore process, is initiated.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
ing/trace_pipe
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 133
include/trace/events/ufs.h | 149 +
2 files changed, 270 insertions(+), 12 deletions(-)
create mode 100
This patch provides the sysfs attribute to choose the power management
level for UFS runtime and system suspend.
Reviewed-by: Sujit Reddy Thumma
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 122 ++
drivers/scsi/ufs/ufshcd.h | 2
doing any
regular data transfer but sometimes device may not behave properly if host
keeps the auto-bkops disabled. This change adds the capability to let the
device auto-bkops always enabled except suspend.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
.
Above issue is fixed by setting the default power mode immediately after
successful link startup.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drive
This patch adds the profiling support for some of the time critical
operations like hibern8 enter/exit, clock gating & clock scaling.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 24
include/trace/events/ufs.h
From: Dolev Raviv
Inserts driver dumps for UFS Host Controller registers, Transfer Requests
and Task Management Requests.
The dumps will occur on driver initialization failure, ufshcd_abort() and
on error handling path.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
Changes v1
ent for ufs commands
Sahitya Tummala (2):
scsi: ufs: Add sysfs node to dynamically control clock gating
scsi: ufs: Add sysfs node to dynamically control clock scaling
Subhash Jadavani (6):
scsi: ufs: add tracing support
scsi: ufs: provide sysfs attribute to select the PM level
scsi: u
From: Sahitya Tummala
Provide an option to enable/disable clock gating during runtime.
Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable
clock gating.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
ts/ufs/enable
cat /sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Lee Susman
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 52 +-
include/trace/events/ufs.h | 38 +
2 files changed, 89 insertions(+
have to tune this default power mode for different chipset
platforms to meet the low power requirements/goals. Hence this patch
adds option to change default UFS low power mode (level).
Reviewed-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt
: Subhash Jadavani
---
Changes v1 -> v2:
- Added explicit new line character at the end of the printk messages.
---
drivers/scsi/ufs/ufshcd.c | 203 --
drivers/scsi/ufs/ufshcd.h | 47 +++
2 files changed, 208 insertions(+), 42 deletions(-)
diff --
On 2016-12-13 12:04, Rob Herring wrote:
On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote:
UFS device and link can be put in multiple different low power modes
hence
UFS driver supports multiple different low power modes. By default UFS
driver selects the default (optimal) low
On 2016-12-13 12:10, Steven Rostedt wrote:
On Tue, 13 Dec 2016 11:48:45 -0800
Subhash Jadavani wrote:
This change adds the ftrace support for following:
1. UFS initialization time
2. Clock gating states
3. Clock scaling states
4. Power management APIs latency
5. BKOPs enable/disable
Usage
On 2016-12-13 12:22, Steven Rostedt wrote:
On Tue, 13 Dec 2016 11:52:16 -0800
Subhash Jadavani wrote:
From: Lee Susman
Use the ftrace infrastructure to conditionally trace ufs command
events.
New trace event is created, which samples the following ufs command
data:
- device name
On 2016-12-19 10:38, Rob Herring wrote:
On Tue, Dec 13, 2016 at 2:16 PM, Subhash Jadavani
wrote:
On 2016-12-13 12:04, Rob Herring wrote:
On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote:
UFS device and link can be put in multiple different low power modes
hence
UFS driver
:
scsi: ufs: Add sysfs node to dynamically control clock gating
scsi: ufs: Add sysfs node to dynamically control clock scaling
Subhash Jadavani (6):
scsi: ufs: add tracing support
scsi: ufs: provide sysfs attribute to select the PM level
scsi: ufs: set default UFS power managemen
From: Dolev Raviv
Inserts driver dumps for UFS Host Controller registers, Transfer Requests
and Task Management Requests.
The dumps will occur on driver initialization failure, ufshcd_abort() and
on error handling path.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
Changes
ing/trace_pipe
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
Changes from v2 -> v3:
- Used TRACE_DEFINE_ENUM to print out enums
---
drivers/scsi/ufs/ufshcd.c | 85 ++---
include/trace/events/ufs.h | 185 +
2 files change
are skipped
and the last step, reset and restore process, is initiated.
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
good power savings with relatively less enter/exit
latencies.
Reviewed-by: Yaniv Gardi
Signed-off-by: Subhash Jadavani
---
Changes from v2 -> v3:
- Simplified patch to just set the default power management level.
Device tree capability to specify broken hardware will be taken up
: Subhash Jadavani
---
Changes from v1 -> v2:
- Added explicit new line character at the end of the printk messages.
---
drivers/scsi/ufs/ufshcd.c | 203 --
drivers/scsi/ufs/ufshcd.h | 47 +++
2 files changed, 208 insertions(+), 42 deletions(-)
d
This patch provides the sysfs attribute to choose the power management
level for UFS runtime and system suspend.
Reviewed-by: Sujit Reddy Thumma
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 144 ++
drivers/scsi/ufs/ufshcd.h | 2
This patch adds the profiling support for some of the time critical
operations like hibern8 enter/exit, clock gating & clock scaling.
Reviewed-by: Venkat Gopalakrishnan
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 24
include/trace/events/ufs.h
.
Above issue is fixed by setting the default power mode immediately after
successful link startup.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufshcd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drive
From: Sahitya Tummala
Provide an option to enable/disable clock scaling during runtime.
Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock
scaling.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
From: Sahitya Tummala
Provide an option to enable/disable clock gating during runtime.
Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable
clock gating.
Signed-off-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
doing any
regular data transfer but sometimes device may not behave properly if host
keeps the auto-bkops disabled. This change adds the capability to let the
device auto-bkops always enabled except suspend.
Reviewed-by: Sahitya Tummala
Signed-off-by: Subhash Jadavani
---
drivers/scsi/ufs/ufs
ts/ufs/enable
cat /sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Lee Susman
Signed-off-by: Subhash Jadavani
---
Changes from v2 -> v3:
- Removed conditional compilation based on CONFIG_TRACEPOINTS and
used trace_*_enabled() to skip unnecessary code path execution.
---
drivers/scsi/uf
_device_id
ufs_qcom_of_match[] = {
{ .compatible = "qcom,ufshc"},
{},
};
+MODULE_DEVICE_TABLE(of, ufs_qcom_of_match);
static const struct dev_pm_ops ufs_qcom_pm_ops = {
.suspend= ufshcd_pltfrm_suspend,
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The
tem_resume,
and trace_ufshcd_init
Where:
hba->uic_link_state is passed to dev_state
hba->curr_dev_pwr_mode is passed to link_state
This wasn't intentional so it's a bug. This change fixed this bug.
Reported-by: Colin Ian King
Signed-off-by: Subhash Jadavani
---
driv
);
/**
* ufshcd_read_desc_param - read the specified descriptor parameter
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux
struct ufs_hba *hba, int desc_index, u8
*buf,
- u32 size, bool ascii);
-
/* Expose Query-Request API */
int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,
enum flag_idn idn, bool *flag_res);
Looks good to me.
Reviewed-by: Subhash Jadavani
L_UNIT_MASK) >>
ATTR_ICC_LVL_UNIT_OFFSET;
curr_uA = data & ATTR_ICC_LVL_VALUE_MASK;
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the li
__func__, ret);
+ goto out;
+ }
+
+ ufs_fixup_device_setup(hba, &card);
ufshcd_tune_unipro_params(hba);
ret = ufshcd_set_vccq_rail_unused(hba,
Looks good to me.
Reviewed-by: Subhash Jadavani
--
The Qualcomm Innovation Center, Inc. is a member of C
(3):
scsi: ufs: skip request abort task when previous aborts failed
scsi: ufs: reduce printout for aborted requests
scsi: ufs: add host state prints in failure cases
Subhash Jadavani (3):
scsi: ufs: add load based scaling of UFS gear
scsi: ufs: don't suspend clock scaling during
1 - 100 of 281 matches
Mail list logo
