[PATCH 4/4] mpt3sas: Update driver version to 27.101.00.00.

2018-12-06 Thread Suganath Prabu
Update driver version from 27.100.00.00 to 27.101.00.00. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 3a294b9

[PATCH 3/4] mpt3sas: Replace readl with ioc->base_readl.

2018-12-06 Thread Suganath Prabu
Use ioc->base_readl to restrict the readl retries to only Aero controllers. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.c | 39 +++-- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c

[PATCH 1/4] mpt3sas: Introduce flag for aero based controllers.

2018-12-06 Thread Suganath Prabu
Adding flag "is_aero_ioc" to differentiate aero based controllers from other gen35 controllers. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 + drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 -- 2 files changed, 9 insertions(+), 6 deletions(-)

[PATCH 2/4] mpt3sas: Add separate function for aero doorbell reads.

2018-12-06 Thread Suganath Prabu
base_readl_aero for Aero IOC and base_readl for gen35 and other controllers. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.c | 30 ++ drivers/scsi/mpt3sas/mpt3sas_base.h | 2 ++ 2 files changed, 32 insertions(+) diff --git a/drivers/scsi/mpt3sas

[PATCH 0/4] mpt3sas: Fix hardware bug in aero controllers.

2018-12-06 Thread Suganath Prabu
for maximum three times, if read returns zero. Suganath Prabu (4): mpt3sas: Introduce flag for aero based controllers. mpt3sas: Add separate function for aero doorbell reads. mpt3sas: Replace readl with ioc->base_readl. mpt3sas: Update driver version to 27.101.00.00. drivers/scsi/mpt3

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-01 Thread Suganath Prabu Subramani
On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > > The code for getting shost and IOC is redundant so > > moved that to function "scsih_get_shost_and_ioc". > > Also checks f

Re: [PATCH v4 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-09-27 Thread Suganath Prabu Subramani
Hi Bjorn, Thanks for reviewing. On Thu, Sep 27, 2018 at 2:33 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:35AM +0530, Suganath Prabu S wrote: > > Introduce mpt3sas_wait_for_ioc_to_operational. > > > > This section of code "wait for IOC to be operationa

[PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-25 Thread Suganath Prabu S
ine. v4 Changes: === Dont split strings in print statement. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 39 drivers/scsi/mpt3sas/mpt3sas_base.h | 3 ++- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 50

[PATCH v4 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-09-25 Thread Suganath Prabu S
ks, and this returns with error code EFAULT, if it detects HBA is hot unplugged or IOC is not in operational state. V2 change set: used pci_device_is_present instead of mpt3sas_base_pci_device_is_unplugged v4 Change set: Dont split strings in print statement Signed-off-by: Suganath Prabu S ---

[PATCH v4 0/6] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-09-25 Thread Suganath Prabu S
statement, to avoid warning from checkpatch.pl. Suganath Prabu S (6): mpt3sas: Introduce mpt3sas_base_pci_device_is_available mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational mpt3sas: Introdude _scsih_get_shost_and_ioc. mpt3sas: Fix Sync cache command failure during driver

[PATCH v4 6/6] mpt3sas: Bump driver version to 27.100.00.00.

2018-09-25 Thread Suganath Prabu S
Modify driver version to 27.100.00.00 (which is equivalent to PH8 OOB driver) Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas

[PATCH v4 5/6] mpt3sas: Fix driver modifying NVRAM/persistent data.

2018-09-25 Thread Suganath Prabu S
. Driver should change only current copy of Manufacturing page11 Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b

[PATCH v4 4/6] mpt3sas: Fix Sync cache command failure during driver unload.

2018-09-25 Thread Suganath Prabu S
this function mpt3sas_base_pci_device_is_unplugged with pci_device_is_present Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 41 ++-- drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 -- 2 files changed, 44 insertions(+), 4 deletions(-) diff

[PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-09-25 Thread Suganath Prabu S
The code for getting shost and IOC is redundant so moved that to function "scsih_get_shost_and_ioc". Also checks for NULL are added to IOC and shost. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 98 ++-- 1 file changed, 82

Re: [PATCH v3 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-25 Thread Suganath Prabu Subramani
On Tue, Sep 25, 2018 at 3:22 PM Andy Shevchenko wrote: > > On Tue, Sep 25, 2018 at 12:46 PM Suganath Prabu Subramani > wrote: > > > > > + pr_err(MPT3SAS_FMT > > > > + "%s: pci error recovery reset or" > > &g

Re: [PATCH v3 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-25 Thread Suganath Prabu Subramani
Hi Andy, I forgot to add Lukas in last patch CC list, But i have sent a note regarding the updated patch to him. Also added linux-pci On Tue, Sep 25, 2018 at 2:10 PM Andy Shevchenko wrote: > > On Mon, Sep 24, 2018 at 9:36 AM Suganath Prabu S > wrote: > > &g

[PATCH v3 6/6] mpt3sas: Bump driver version to 27.100.00.00.

2018-09-24 Thread Suganath Prabu S
Modify driver version to 27.100.00.00 (which is equivalent to PH8 OOB driver) Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas

[PATCH v3 4/6] mpt3sas: Fix Sync cache command failure during driver unload.

2018-09-24 Thread Suganath Prabu S
this function mpt3sas_base_pci_device_is_unplugged with pci_device_is_present Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 41 ++-- drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 -- 2 files changed, 44 insertions(+), 4 deletions(-) diff

[PATCH v3 5/6] mpt3sas: Fix driver modifying NVRAM/persistent data.

2018-09-24 Thread Suganath Prabu S
. Driver should change only current copy of Manufacturing page11 Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b

[PATCH v3 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-09-24 Thread Suganath Prabu S
The code for getting shost and IOC is redundant so moved that to function "scsih_get_shost_and_ioc". Also checks for NULL are added to IOC and shost. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 98 ++-- 1 file changed, 82

[PATCH v3 0/6] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-09-24 Thread Suganath Prabu S
: In Patch 0001 - unlock mutex, if active reset is in progress. V2 changes: Replaced mpt3sas_base_pci_device_is_unplugged with pci_device_is_present. V3 Change Set: Simplified function "mpt3sas_base_pci_device_is_available" and made inline Suganath Prabu S (6): mpt3sas:

[PATCH v3 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-09-24 Thread Suganath Prabu S
ks, and this returns with error code EFAULT, if it detects HBA is hot unplugged or IOC is not in operational state. V2 change set: used pci_device_is_present instead of mpt3sas_base_pci_device_is_unplugged Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3

[PATCH v3 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-24 Thread Suganath Prabu S
s_base_pci_device_is_unplugged. 2) As suggested by Lukas, removed using watchdog thread for checking hba hot unplug(Patch 02 of V1). Added Hot unplug checks in scan finish and reset paths. v3 Change Set: = Simplified function "mpt3sas_base_pci_device_is_available" and made

[PATCH v2 4/6] mpt3sas: Fix Sync cache command failure during driver unload.

2018-09-20 Thread Suganath Prabu S
this function mpt3sas_base_pci_device_is_unplugged with pci_device_is_present Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 41 ++-- drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 -- 2 files changed, 44 insertions(+), 4 deletions(-) diff

[PATCH v2 6/6] mpt3sas: Bump driver version to 27.100.00.00.

2018-09-20 Thread Suganath Prabu S
Modify driver version to 27.100.00.00 (which is equivalent to PH8 OOB driver) Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas

[PATCH v2 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-20 Thread Suganath Prabu S
s_base_pci_device_is_unplugged. 2) As suggested by Lukas, removed using watchdog thread for checking hba hot unplug(Patch 02 of V1). Added Hot unplug checks in scan finish and reset paths. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 46 +

[PATCH v2 0/6] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-09-20 Thread Suganath Prabu S
: In Patch 0001 - unlock mutex, if active reset is in progress. V2 changes: Replaced mpt3sas_base_pci_device_is_unplugged with pci_device_is_present. Suganath Prabu S (6): mpt3sas: Introduce mpt3sas_base_pci_device_is_available mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

[PATCH v2 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-09-20 Thread Suganath Prabu S
The code for getting shost and IOC is redundant so moved that to function "scsih_get_shost_and_ioc". Also checks for NULL are added to IOC and shost. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 98 ++-- 1 file changed, 82

[PATCH v2 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-09-20 Thread Suganath Prabu S
ks, and this returns with error code EFAULT, if it detects HBA is hot unplugged or IOC is not in operational state. V2 change set: used pci_device_is_present instead of mpt3sas_base_pci_device_is_unplugged Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3

[Patch v1 5/7] mpt3sas: Fix Sync cache command failure during driver unload.

2018-08-30 Thread Suganath Prabu S
This is to fix Sync cache and start stop command failures with DID_NO_CONNECT during driver unload. 1) Release drives first from SML, then remove internally in driver. 2) And allow sync cache and Start stop commands to firmware, even when remove_host flag is set Signed-off-by: Suganath Prabu S

[Patch v1 1/7] mpt3sas: Introduce mpt3sas_base_pci_device_is_unplugged

2018-08-30 Thread Suganath Prabu S
en if diag reset fails and also if driver detects that HBA is hot unplugged. v1 change set: unlock mutex before goto "out_unlocked", if active reset is in progress. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 62 +++-

[Patch v1 2/7] mpt3sas: Add HBA hot plug watchdog thread.

2018-08-30 Thread Suganath Prabu S
perational. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 92 +++- drivers/scsi/mpt3sas/mpt3sas_base.h | 6 +++ drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 +++ 3 files changed, 104 insertions(+), 1 deletion(-) diff --git a/drivers/sc

[Patch v1 6/7] mpt3sas: Fix driver modifying NVRAM/persistent data.

2018-08-30 Thread Suganath Prabu S
. Driver should change only current copy of Manufacturing page11 Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b

[Patch v1 0/7] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-08-30 Thread Suganath Prabu S
: In Patch 0001 - unlock mutex, if active reset is in progress. Suganath Prabu S (7): mpt3sas: Introduce mpt3sas_base_pci_device_is_unplugged mpt3sas: Add HBA hot plug watchdog thread. mpt3sas: Seperate out mpt3sas_wait_for_ioc_to_operational mpt3sas: Introdude _scsih_get_shost_and_ioc

[Patch v1 3/7] mpt3sas: Seperate out mpt3sas_wait_for_ioc_to_operational

2018-08-30 Thread Suganath Prabu S
ks, and this returns with error code EFAULT, if it detects HBA is hot unplugged or IOC is not in operational state. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 92 +++- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++ drivers/scsi/mpt3

[Patch v1 7/7] mpt3sas: Bump driver version to 27.100.00.00.

2018-08-30 Thread Suganath Prabu S
Modify driver version to 27.100.00.00 (which is equivalent to PH8 OOB driver) Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas

[Patch v1 4/7] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-08-30 Thread Suganath Prabu S
The code for getting shost and IOC is redundant so moved that to function "scsih_get_shost_and_ioc". Also checks for NULL are added to IOC and shost. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 98 ++-- 1 file changed, 82

[PATCH 5/7] mpt3sas: Fix Sync cache command failure during driver unload.

2018-08-29 Thread Suganath Prabu S
This is to fix Sync cache and start stop command failures with DID_NO_CONNECT during driver unload. 1) Release drives first from SML, then remove internally in driver. 2) And allow sync cache and Start stop commands to firmware, even when remove_host flag is set. Signed-off-by: Suganath Prabu S

[PATCH 0/7] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-08-29 Thread Suganath Prabu S
and remove HBA without bringing the system down. For surprise removal detection, driver does a PCI read of IOC's vendor field in IOC's PCI configuration space. If the read value is 0x this indicates that the device might have hot removed and the device will be removed from driver. Suganath Prabu

[PATCH 6/7] mpt3sas: Fix driver modifying NVRAM/persistent data.

2018-08-29 Thread Suganath Prabu S
. Driver should change only current copy of Manufacturing page11. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_config.c | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b

[PATCH 1/7] mpt3sas: Introduce mpt3sas_base_pci_device_is_unplugged

2018-08-29 Thread Suganath Prabu S
en if diag reset fails and also if driver detects that HBA is hot unplugged. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 61 +++- drivers/scsi/mpt3sas/mpt3sas_base.h | 3 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 42 ++

[PATCH 7/7] mpt3sas: Bump driver version to 27.100.00.00.

2018-08-29 Thread Suganath Prabu S
Modify driver version to 27.100.00.00 (which is equivalent to PH8 OOB driver) Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas

[PATCH 2/7] mpt3sas: Add HBA hot plug watchdog thread.

2018-08-29 Thread Suganath Prabu S
perational. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 92 +++- drivers/scsi/mpt3sas/mpt3sas_base.h | 6 +++ drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 +++ 3 files changed, 104 insertions(+), 1 deletion(-) diff --git a/drivers/sc

[PATCH 4/7] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-08-29 Thread Suganath Prabu S
The code for getting shost and IOC is redundant so moved that to function "scsih_get_shost_and_ioc". Also checks for NULL are added to IOC and shost. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 98 ++-- 1 file changed, 82

Re: mpt3sas heavy I/O load causes kernel BUG at block/blk-core.c:2695

2018-06-07 Thread Suganath Prabu Subramani
: Fix for Asynchronous completion of timedout IO and task abort of timedout IO. Track msix of each IO and use the same msix for issuing abort to timed out IO. With this driver will process IO's reply first followed by TM. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B Reviewed

Re: mpt3sas: sleeping function called from invalid context

2018-03-13 Thread Suganath Prabu Subramani
ve patch ready along with few other change and we ll be posting it by tomorrow after covering BST. Thanks, Suganath Prabu S On Mon, Mar 12, 2018 at 11:53 PM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > Hello, > > For the first I/O request after boot that is sent to a disk att

Re: [PATCH 5/6] mpt3sas: Introduce function to clone mpi request.

2018-02-23 Thread Suganath Prabu Subramani
Hi tomas, We have sent V1 version of patches on 7th of Feb. Please review. Thanks, Suganath Prabu S On Mon, Jan 22, 2018 at 8:08 PM, Tomas Henzl <the...@redhat.com> wrote: > On 01/19/2018 01:37 PM, Suganath Prabu S wrote: >> 1) Added function _base_clone_mpi_to_sys_mem to clone

Re: [V1 0/6] mpt3sas: Adding MPI Endpoint device support.

2018-02-15 Thread Suganath Prabu Subramani
Gentle Reminder, Any update on this ? Thanks, Suganath Prabu S On Wed, Feb 7, 2018 at 4:21 PM, Suganath Prabu S <suganath-prabu.subram...@broadcom.com> wrote: > V1 Change info: > > * Few sparse warning fixes over initial patch set. > * For 32 bit Arch,_base_writeq fun

[V1] mpt3sas: Do not use 32-bit atomic request descriptor for Ventura controllers.

2018-02-14 Thread Suganath Prabu S
and use 64 bit Descriptors V1 Change set: 1) In this patch removed callbacks as suggested by Hannes. Note: This patch Should be applied on top of https://www.spinics.net/lists/linux-scsi/msg117405.html "Adding MPI Endpoint device support" patches. Signed-off-by: Suganath Prabu S

[V1 4/6] mpt3sas: Introduce Base function for cloning.

2018-02-07 Thread Suganath Prabu S
All scsi IO's and config requests data buffer and sgl are cloned to system memory in _clone_sg_entries before submitting it to Firmware. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c

[V1 5/6] mpt3sas: Introduce function to clone mpi request.

2018-02-07 Thread Suganath Prabu S
,_base_writeq function is identical to _base_mpi_ep_writeq, Removed duplicate code as suggested. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 140 1 file changed, 125 insertions(+), 15 del

[V1 6/6] mpt3sas: Introduce function to clone mpi reply.

2018-02-07 Thread Suganath Prabu S
If the posted request has an error of any type, the IOC writes a Reply message into a host-based system reply message frame. This functions clone it in the BAR0 mapped region. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.

[V1 0/6] mpt3sas: Adding MPI Endpoint device support.

2018-02-07 Thread Suganath Prabu S
ich will be the entry point in IOC FW module. Once PLX management calls relevant callbackfrom IOC FW, rest of the processing will behandled within IOC FW. IOC FW should release TLP packet as soon as possible to avoid any TLP timeout. Suganath Prabu S (6): mpt3sas: Add PCI device ID for Andromeda. mpt3

[V1 2/6] mpt3sas: Configure reply post queue depth, DMA and sgl tablesize.

2018-02-07 Thread Suganath Prabu S
This configures shost max sector to 128, single reply descriptor post queue, sgl table size to 16 and 32 bit DMA for MPI Endpoint and it supports 64K as max IO. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c

[V1 1/6] mpt3sas: Add PCI device ID for Andromeda.

2018-02-07 Thread Suganath Prabu S
Add device ID and flag for Andromeda/MPI Emdpont. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 1 + drivers/scsi/mpt3sas/mpt3sas_base.h | 1 + drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 -- 3 files chang

[V1 3/6] mpt3sas: Introduce API's to get BAR0 mapped buffer address.

2018-02-07 Thread Suganath Prabu S
directly to the mCPU memory region via BAR-0 region. Introduced API's to calculate and return BAR0 mapped host buffer's physical and virtual address for the provided smid Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.

Re: [PATCH] mpt3sas: fix an out of bound write

2018-01-28 Thread Suganath Prabu Subramani
Hi, Please consider this patch as Ack-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Thanks. On Fri, Jan 19, 2018 at 8:52 PM, Tomas Henzl <the...@redhat.com> wrote: > cpu_msix_table is allocated to store online cpus, but pci_irq_get_affinity > may return cpu_p

Re: [PATCH 4/6] mpt3sas: Introduce Base function for cloning.

2018-01-23 Thread Suganath Prabu Subramani
sas_base.c:278:13: warning: '_clone_sg_entries' defined but not used static void _clone_sg_entries(struct MPT3SAS_ADAPTER ^ cc1: some warnings being treated as errors Thanks, Suganath Prabu S On Sat, Jan 20, 2018 at 11:37 PM, kbuild test robot <l...@intel.com> wrot

[PATCH 0/6] mpt3sas: Adding MPI Endpoint device support.

2018-01-19 Thread Suganath Prabu S
oon as possible to avoid any TLP timeout. Suganath Prabu S (6): mpt3sas: Add PCI device ID for Andromeda. mpt3sas: Configure reply post queue depth, DMA and sgl tablesize. mpt3sas: Introduce API's to get BAR0 mapped buffer address. mpt3sas: Introduce Base function for cloning. mpt3sas: Introd

[PATCH 5/6] mpt3sas: Introduce function to clone mpi request.

2018-01-19 Thread Suganath Prabu S
1) Added function _base_clone_mpi_to_sys_mem to clone MPI request into system BAR0 mapped region. 2) Seperate out MPI Endpoint IO submissions to function _base_put_smid_mpi_ep_scsi_io. 3) MPI EP requests are submitted in two 32 bit MMIO writes. from _base_mpi_ep_writeq. Signed-off-by: Suganath

[PATCH 4/6] mpt3sas: Introduce Base function for cloning.

2018-01-19 Thread Suganath Prabu S
All scsi IO's and config requests data buffer and sgl are cloned to system memory in _clone_sg_entries before submitting it to Firmware. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c

[PATCH 6/6] mpt3sas: Introduce function to clone mpi reply.

2018-01-19 Thread Suganath Prabu S
If the posted request has an error of any type, the IOC writes a Reply message into a host-based system reply message frame. This functions clone it in the BAR0 mapped region. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.

[PATCH 1/6] mpt3sas: Add PCI device ID for Andromeda.

2018-01-19 Thread Suganath Prabu S
Add device ID and flag for Andromeda/MPI Emdpont. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 1 + drivers/scsi/mpt3sas/mpt3sas_base.h | 1 + drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 -- 3 files chang

[PATCH 2/6] mpt3sas: Configure reply post queue depth, DMA and sgl tablesize.

2018-01-19 Thread Suganath Prabu S
This configures shost max sector to 128, single reply descriptor post queue, sgl table size to 16 and 32 bit DMA for MPI Endpoint and it supports 64K as max IO. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c

[Resend 03/11] mpt3sas: separate out _base_recovery_check()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> No functional change. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++- 1 file changed, 14 insertio

[Resend 02/11] mpt3sas: use list_splice_init()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Use 'list_splice_init()' instead of hand-crafted function. No functional change. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/m

[Resend 04/11] mpt3sas: open-code _scsih_scsi_lookup_get()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Just a wrapper around the scsi lookup array and only used in one place, so open-code it. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mp

[Resend PATCH 00/11] mpt3sas: Enable scsi MQ & lockless command submission

2018-01-04 Thread Suganath Prabu S
errupt and as such does benefit from converting it to full multiqueue support. Suganath Prabu S (11): mpt3sas: set default value for cb_idx mpt3sas: use list_splice_init() mpt3sas: separate out _base_recovery_check() mpt3sas: open-code _scsih_scsi_lookup_get() mpt3sas: Introduce mpt3sas_get_st_fro

[Resend 05/11] mpt3sas: Introduce mpt3sas_get_st_from_smid()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Abstract accesses to the scsi_lookup array by introducing mpt3sas_get_st_from_smid(). Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sa

[Resend 07/11] mpt3sas: always use first reserved smid for ioctl passthrough

2018-01-04 Thread Suganath Prabu S
ioctl commands. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 19 +-- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 10 ++ 2 files changed, 15 insertion

[Resend 08/11] mpt3sas: simplify task management functions

2018-01-04 Thread Suganath Prabu S
; Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 88 +++- 1 file changed, 7 insertions(+), 81 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scs

[Resend 06/11] mpt3sas: check command status before attempting abort

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> When attempting a command abort we should check the command status prior to sending the abort; the command might've been completed already. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram.

[Resend 09/11] mpt3sas: simplify mpt3sas_scsi_issue_tm()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Move the check for outstanding commands out of the function allowing us to simplify the overall code. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- dr

[Resend 11/11] mpt3sas: lockless command submission

2018-01-04 Thread Suganath Prabu S
ated by scsi mid layer for each scsi command. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 147 ++- drivers/scsi/mpt3sas/mpt3sas_base.h

[Resend 10/11] mpt3sas: simplify _wait_for_commands_to_complete()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Use 'host_busy' instead of counting outstanding commands by hand. Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 14

[Resend 01/11] mpt3sas: set default value for cb_idx

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> No functional change Signed-off-by: Hannes Reinecke <h...@suse.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deleti

[PATCH 11/11] mpt3sas: lockless command submission

2017-12-21 Thread Suganath Prabu S
mplate, so that struct scsiio_tracker is preallocated by scsi mid layer for each scsi command. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 147 +++

[PATCH 05/11] mpt3sas: Introduce mpt3sas_get_st_from_smid()

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Abstract accesses to the scsi_lookup array by introducing mpt3sas_get_st_from_smid(). Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3

[PATCH 08/11] mpt3sas: simplify task management functions

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> No functional change. Code optimization. One can simply check 'target_busy' or 'device_busy' when figuring out if there are outstanding commands; no need to painstakingly counting them by hand. Signed-off-by: Suganath Prabu S <suganath-pra

[PATCH 06/11] mpt3sas: check command status before attempting abort

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> When attempting a command abort we should check the command status prior to sending the abort; the command might've been completed already. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B &

[PATCH 04/11] mpt3sas: open-code _scsih_scsi_lookup_get()

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Just a wrapper around the scsi lookup array and only used in one place, so open-code it. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- dr

[PATCH 02/11] mpt3sas: use list_splice_init()

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Use 'list_splice_init()' instead of hand-crafted function. No functional change. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3sas/m

[PATCH 10/11] mpt3sas: simplify _wait_for_commands_to_complete()

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Use 'host_busy' instead of counting outstanding commands by hand. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 14

[PATCH 07/11] mpt3sas: always use first reserved smid for ioctl passthrough

2017-12-21 Thread Suganath Prabu S
ioctl commands. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 19 +-- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 10 ++ 2 files changed, 15

[PATCH 09/11] mpt3sas: simplify mpt3sas_scsi_issue_tm()

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> Move the check for outstanding commands out of the function allowing us to simplify the overall code. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- dr

[PATCH 03/11] mpt3sas: separate out _base_recovery_check()

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> No functional change. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++- 1 file changed, 1

[PATCH 01/11] mpt3sas: set default value for cb_idx

2017-12-21 Thread Suganath Prabu S
From: Hannes Reinecke <h...@suse.de> No functional change Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> --- drivers/scsi/mpt3sas/modules.order | 2 +- drivers/scsi/mpt3sas/mpt3sas_base.c

[PATCH 00/11] mpt3sas: Enable scsi MQ & lockless command submission

2017-12-21 Thread Suganath Prabu S
errupt and as such does benefit from converting it to full multiqueue support. Suganath Prabu S (11): mpt3sas: set default value for cb_idx mpt3sas: use list_splice_init() mpt3sas: separate out _base_recovery_check() mpt3sas: open-code _scsih_scsi_lookup_get() mpt3sas: Introduce mpt3sas_get_st_fro

[PATCH] mpt3sas: Remove unused variable requeue_event

2017-12-02 Thread Suganath Prabu S
No Functional change just cleanup, Removed variable requeue_event and made function as void. Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/d

[PATCH 04/13] mpt3sas: API 's to support NVMe drive addition to SML

2017-10-31 Thread Suganath Prabu S
mpt3sas_config_get_pcie_device_pg2 Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.h | 10 + drivers/scsi/mpt3sas/mpt3sas_config.c | 100 drivers/scsi/mpt3sas/mpt3sas_sc

[PATCH 00/13] mpt3sas driver NVMe support:

2017-10-31 Thread Suganath Prabu S
Ventura Series controller are Tri-mode. The controller and firmware are capable of supporting NVMe devices and PCIe switches to be connected with the controller. This patch set adds driver level support for NVMe devices and PCIe switches. Suganath Prabu S (13): mpt3sas: Add nvme device support

[PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

2017-10-31 Thread Suganath Prabu S
to translate it. And this will have a performance reduction. To avoid that driver proactively checks whether the translation will be done in hardware or not, if not then driver try to translate inside the driver. Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath P

[PATCH 01/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

2017-10-31 Thread Suganath Prabu S
called when driver unregisters or removes device. Also frees allocated resources and info. Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.h | 110 ++

[PATCH 06/13] mpt3sas: Handle NVMe PCIe device related events generated from firmware.

2017-10-31 Thread Suganath Prabu S
<chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 30 ++- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 471 ++- 2 files changed, 495 insertions(+), 6 deletions(-) diff --g

[PATCH 09/13] mpt3as: Add-Task-management-debug-info-for-NVMe-drives.

2017-10-31 Thread Suganath Prabu S
Added debug information for NVMe/PCIe drives in target rest path Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 80 1

[PATCH 08/13] mpt3sas: scan and add nvme device after controller reset

2017-10-31 Thread Suganath Prabu S
After Controller reset, Scan and add nvme device back to the topology. Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 194 +++

[PATCH 03/13] mpt3sas: Added support for nvme encapsulated request message.

2017-10-31 Thread Suganath Prabu S
. * This encapsulated NVMe command is used by applications to send direct NVMe commands to NVMe drives. Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_

[PATCH 05/13] mpt3sas: API's to remove nvme drive from sml

2017-10-31 Thread Suganath Prabu S
Below API's are included in nvme drive remove path. _scsih_pcie_device_remove_by_handle _scsih_pcie_device_remove_from_sml Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt

[PATCH 10/13] mpt3sas: NVMe drive support for BTDHMAPPING ioctl command and log info

2017-10-31 Thread Suganath Prabu S
* Added debug prints for pcie devices in ioctl debug path. Which will be helpful for debugging. * Added PCIe device support for ioctl BTDHMAPPING ioctl. Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com>

[PATCH 11/13] mpt3sas: Fix nvme drives checking for tlr.

2017-10-31 Thread Suganath Prabu S
Check for NVMe drives before enabling or checking tlr. Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 22 -- 1 file changed, 16 inse

  1   2   3   >