On Wed, Jul 06, 2016 at 06:40:32AM +, Tom Yan wrote:
> Um it's not mainly about in caps or not, but more about wrongly spelled as
> cbd.
Heh, right, so please just note it in the description.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the
On Wed, Jul 06, 2016 at 03:10:51AM +0800, Tom Yan wrote:
> Well it is exactly what the patch does. We no longer do the "divide it
> by 8" thing each time we want to know the now defined TRIM_RANGE_NUM.
>
> ata_set_lba_range_entries() has only been used by
> ata_scsi_write_same_xlat()
>
Hello,
On Wed, Jul 06, 2016 at 03:13:31AM +0800, Tom Yan wrote:
> I just thought that such a minor change in a comment can fit in the
> same patch where the issue was first noticed. Anyway, will split them
> if I am going to send a v3 set.
>
> On 5 July 2016 at 19:08, Sergei Shtylyov
>
Hello,
On Mon, Jun 20, 2016 at 06:46:55PM -0700, Dan Williams wrote:
> On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen
> <martin.peter...@oracle.com> wrote:
> >>>>>> "Tejun" == Tejun Heo <t...@kernel.org> writes:
> >
> >>> I
On Thu, Jun 16, 2016 at 12:45:40PM +0800, DingXiang wrote:
...
> In fact,we don't need libata to deal with hotplug in sas environment.
> So we can't run ata hotplug task when ata port is sas host.
Martin, can you please confirm whether the above is true. If so, I'll
route the patch through
On Fri, Jun 10, 2016 at 04:33:09PM -0500, Brian King wrote:
> On 05/26/2016 09:12 AM, Brian King wrote:
> > On 05/25/2016 02:32 PM, Tejun Heo wrote:
> >> Hello, Brian.
> >>
> >> So, of all the ata drivers, ipr seems to be the only driver which
>
Ditto with other patches.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 31, 2016 at 04:38:17PM +0800, Wei Fang wrote:
> sas_ata_strategy_handler() adds the works of the ata error handler
> to system_unbound_wq. This workqueue asynchronously runs work items,
Are there more than one error handling work items per host?
Thanks.
--
tejun
--
To unsubscribe
Hello, Brian.
So, of all the ata drivers, ipr seems to be the only driver which
doesn't implement ata_port_opeations->error_handler and thus depends
on the old error handling path. I'm wondering whether it'd be possible
to convert ipr to implement ->error_handler and drop the old path.
Would that
On Fri, May 06, 2016 at 01:05:36PM +0200, Hannes Reinecke wrote:
> On 04/25/2016 10:16 PM, Tejun Heo wrote:
> > Hello,
> >
> > On Mon, Apr 25, 2016 at 12:45:42PM +0200, Hannes Reinecke wrote:
> >> here's a patchset implementing ZAC support for libata.
> >>
&
Hello,
On Mon, Apr 25, 2016 at 12:45:42PM +0200, Hannes Reinecke wrote:
> here's a patchset implementing ZAC support for libata.
>
> This is the second part of a larger patchset for ZAC/ZBC support;
> it requires the scsi trace fixes queued for in mkp/4.7/scsi-queue and
> the patchset 'libata:
On Thu, Apr 14, 2016 at 05:59:48PM +0200, Hannes Reinecke wrote:
> For this patch, yes, you are right.
> However, the ZAC enablement patches later on submit READ LOG EXT commands
> (for REPORT ZONES), and _they_ benefit from NCQ encapsulation.
Umm... so, you can't use ata_exec_internal() outside
On Thu, Apr 14, 2016 at 07:48:03AM +0200, Hannes Reinecke wrote:
> On 04/13/2016 08:09 PM, Tejun Heo wrote:
> > On Tue, Apr 12, 2016 at 08:47:53AM +0200, Hannes Reinecke wrote:
> >> libata device disabling is ... curious. So add the correct
> >> definitions that we can d
Hello, Hannes.
On Thu, Apr 14, 2016 at 07:44:19AM +0200, Hannes Reinecke wrote:
> Hehe. No, it isn't, if you look closely.
> (Or make that: it _shouldn't_, and I've messed it up)
> (That's what the 'fpdma' parameter is for)
>
> The benefit is not so much for normal operations, but it'll give us
On Tue, Apr 12, 2016 at 08:47:50AM +0200, Hannes Reinecke wrote:
> + log_pages = get_unaligned_le16(>sector_buf[log_index]);
> + if (!log_pages) {
> + ata_dev_warn(dev,
> + "NCQ Send/Recv Log not supported\n");
Shouldn't this be an info message?
On Tue, Apr 12, 2016 at 08:47:53AM +0200, Hannes Reinecke wrote:
> libata device disabling is ... curious. So add the correct
> definitions that we can disable ZAC devices properly.
Fold into an earlier patch?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe
On Tue, Apr 12, 2016 at 08:47:49AM +0200, Hannes Reinecke wrote:
> Recent devices can use NCQ encapsulation for READ LOG DMA EXT,
> so we should be using it if available.
Does this have any actual benefits than being new and shiny? It's
being called from EH path where we know that no other
.
>
> Will move these 2 generic definitions to scatterlist.h later.
>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Acked-by: Bart Van Assche <bart.vanass...@sandisk.com> (for ib_srp changes)
> Signed-off-by: Ming Lin <min...@ssi.samsung.com>
For libata
On Mon, Apr 04, 2016 at 01:24:52PM -0700, Ming Lin wrote:
> Could you help to review/ack this ATA part?
> Thanks.
Can you please resend me the patches?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to
On Mon, Apr 04, 2016 at 02:26:51PM +0300, Sergei Shtylyov wrote:
> >+} else {
> >+/* Could not decode error */
> >+ata_dev_warn(dev, "could not decode error status 0x%x err_mask
> >0x%x\n",
>
>"%#x" is equivalent and takes up less space.
Oops, gmail for some
On Mon, Apr 04, 2016 at 11:47:48AM +0200, Hannes Reinecke wrote:
> +/*
/**
> + * ata_scsi_report_zones_complete
> + *
> + * Convert T-13 little-endian field representation into
> + * T-10 big-endian field representation.
> + */
> +static void ata_scsi_report_zones_complete(struct ata_queued_cmd
Hello, Hannes.
Except for the minor nits, looks good to me. Will wait for refresh
and apply to libata/for-4.7-zac.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hello, Hannes.
Applied the series to libata/for-4.7-zac with cosmetic updates
((s64)-1 -> UINT64_MAX, kbuild warning fixes and other formatting
updates).
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to
On Thu, Feb 18, 2016 at 10:54:10AM +0200, Mika Westerberg wrote:
> Linux already supports runtime PM of disks (drivers/scsi/sd.c) so that
> after certain amount of idle time the disk is suspended automatically. This
> series extends the support to AHCI host controllers. Whenever SATA ports
> are
Hello,
Patchset looks good to me. Once Jens acks the first patch, I'll apply
the whole series to libata/for-4.6 w/ the field initialization
updated.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
On Thu, Feb 18, 2016 at 12:45:05PM +0200, Andy Shevchenko wrote:
> > + .driver.pm = _pci_pm_ops,
>
> Please, do this in several assignments, since to support older compilers.
Can you please elaborate? That's a single assignment. Are there
compilers which can't do that?
t; manage that.
The whole series looks good to me. Please feel free to add
Reviewed-by: Tejun Heo <t...@kernel.org>
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, Christoph.
On Wed, Sep 30, 2015 at 05:14:49PM +0200, Christoph Hellwig wrote:
> The problem is that async probing deadlocks vs a synchronous
> request_module, as Tejun figured out based on the thrad in
> http://thread.gmane.org/gmane.linux.kernel/1420814
>
> Tejun, if I understand the
Hello,
On Fri, Sep 18, 2015 at 08:42:26AM -0700, Lee Duncan wrote:
> To be clear: you would like a patch series that converts the users of
> the ida_* routines in my patches to instead use the ida_simple_*
> routines, correct? And of course the ida_* helper routines I was adding
> in idr.h would
Hello,
On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote:
> Well, there's an easy fix for that. We could have ida_remove() actually
> free the bitmap and not cache it if it's the last layer. That way ida
> would naturally empty and we wouldn't need a destructor. Tejun, would
>
Hello, James.
On Thu, Sep 17, 2015 at 10:58:29AM -0700, James Bottomley wrote:
> The argument is that we shouldn't have to explicitly destroy a
> statically initialized object, so
>
> DEFINE_IDA(someida);
>
> Should just work without having to explicitly do
>
> ida_destory(someida);
>
>
Hello,
On Tue, Sep 15, 2015 at 11:38:42AM -0700, James Bottomley wrote:
> For most of the SCSI stuff, yes. I'm less sure about the sd numbers.
> They go up very high and get hammered a lot during system bring up and
> hot plug. I think having their own lock rather than wrapping everything
>
Hello,
On Tue, Sep 15, 2015 at 09:46:01AM -0700, Lee Duncan wrote:
> +/**
> + * ida_get_index - allocate a ida index value
> + * @ida idr handle
> + * @lock spinlock handle protecting this index
> + * @p_id pointer to allocated index value
> + *
> + * A helper function for
Hello,
On Fri, Aug 21, 2015 at 10:37:44PM -0700, Anatol Pomozov wrote:
...
https://bbs.archlinux.org/viewtopic.php?id=199351 A lot of people
report the same problem as mine. It was found that the problem appears
only starting from 3.19, with kernel 3.18 or Windows these drives work
fine. It
On Mon, Aug 03, 2015 at 11:16:21AM -0400, Tejun Heo wrote:
From 8c0fa3e7ca99b0d6d96cb2cf194a912f643da7c5 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Mon, 3 Aug 2015 11:10:45 -0400
fe7173c206de (libata: Implement support for sense data reporting)
and subsequent patches
Hello, James.
On Mon, Aug 03, 2015 at 08:42:43AM -0700, James Bottomley wrote:
I'd think it would be the same reason as all modern transports: it's
faster and allows processing of sense data in-band. Under the old
regime, the device is effectively frozen until you collect the data.
Under
Hello,
On Mon, Aug 03, 2015 at 09:31:57AM +0200, Hannes Reinecke wrote:
The whole point of the autosense feature is that you do _not_
have to fall back to the original trial-and-error libata EH,
but know exactly what the problem is. Plus any retry will be giving
us (in most cases) exactly the
From 8c0fa3e7ca99b0d6d96cb2cf194a912f643da7c5 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Mon, 3 Aug 2015 11:10:45 -0400
fe7173c206de (libata: Implement support for sense data reporting)
and subsequent patches enabled NCQ autosense reporting; unfortunately,
this breaks libata
Adding a bit.
On Mon, Aug 03, 2015 at 11:04:28AM -0400, Tejun Heo wrote:
Ugh... so this is from NCQ autosense thing. Now ATA devices reports
sense data too which trumps AC_ERR_DEV so libata EH decides to retry
even when the device indicates unrecoverable error. Urgh... we
shouldn't
Hello, James.
On Mon, Aug 03, 2015 at 09:44:06AM -0700, James Bottomley wrote:
I'm not arguing that *this* patch is the best way to do it. You asked
*why* autosense and that's what I answered. I think there's time to
Heh, that was mostly me being confused. I was thinking NCQ autosense
was
Hello, Hannes.
On Mon, Aug 03, 2015 at 06:47:46PM +0200, Hannes Reinecke wrote:
At the moment NCQ autosense is mostly used to provide the host with more
details for a failed I/O. The typical case here is (no small surprise)
ZAC disks, which use autosense to inform the host about
a malformed
Hello,
On Fri, Jul 31, 2015 at 03:02:03PM +0200, Hannes Reinecke wrote:
If a failed command has a valid autosense there is no need to
retry it on the ATA level; at best we're incurring the same
error again. So rather not retry it here, but leave it to
the SCSI layer to decide if a retry is in
On Fri, Apr 17, 2015 at 04:22:17PM +0530, Suman Tripathi wrote:
Hi ,
I need some suggestion .
From the below interrupt handler in libahci.c it explains that the
interrupt from port to Host is level triggered. Do we have any
existing implementation that handles the port to Host as Edge
On Wed, Apr 01, 2015 at 08:18:02PM +0530, Suman Tripathi wrote:
This patch enables full AHCI feature support for APM X-Gene SoC SATA host host
controller. The following errata's are removed:
1. 2a0bdff6b95 (ahci-xgene: fix the dma state machine lockup for the
IDENTIFY DEVICE
On Wed, Apr 01, 2015 at 12:13:36PM -0400, Tejun Heo wrote:
Signed-off-by : Suman Tripathi stripa...@apm.com
Applied to libata/for-4.1 w/ minor edit.
Reverted due to build failure from missing asm/cputype.h. Suman,
you're the develper and familiar with how the prerequisite patches
On Wed, Apr 01, 2015 at 05:39:56PM +0100, Russell King - ARM Linux wrote:
On Wed, Apr 01, 2015 at 12:31:16PM -0400, Tejun Heo wrote:
On Wed, Apr 01, 2015 at 12:13:36PM -0400, Tejun Heo wrote:
Signed-off-by : Suman Tripathi stripa...@apm.com
Applied to libata/for-4.1 w/ minor edit
On Tue, Feb 10, 2015 at 08:56:30AM -0800, James Bottomley wrote:
+ wq = alloc_ordered_workqueue(%s_%d_hpsa, 0, name, h-ctlr);
It's not an objection to your patch, but what idiot did this? There's
an extra variable there between the format and the arguments. That
makes the pattern
On Mon, Feb 02, 2015 at 11:37:19PM +0530, Suman Tripathi wrote:
This patch addresses the issue with ATA_CMD_SMART pio mode
command for enumeration and device detection with ATA devices.
The X-Gene AHCI controller has an errata in which it cannot clear
the BSY bit after the PIO setup FIS. The
: Tejun Heo t...@kernel.org
Cc: Christoph Hellwig h...@lst.de
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: linux-...@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Applied 1-2 to libata/for-3.20.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
On Tue, Jan 27, 2015 at 11:26:11PM +0530, Suman Tripathi wrote:
This patch addresses the issue with ATA_CMD_SMART pio mode
command for enumeration and device detection with ATA devices.It is the
same issue as in patch
www.spinics.net/lists/linux-ide/msg49092.html
The link is broken. Can
Hello,
On Tue, Jan 27, 2015 at 08:34:58AM +0900, Akinobu Mita wrote:
The owner module reference of the ahci platform's scsi_host is
initialized to libahci_platform's one, because these drivers use a
scsi_host_template defined in libahci_platform. So these drivers can
be unloaded even if the
the forementioned patches are merged to mainline
before applying to subsystem trees.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Andrew Morton a...@linux-foundation.org
Cc: James E.J. Bottomley james.bottom...@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/scsi_debug.c | 6
Hello, Akinobu.
On Tue, Jan 20, 2015 at 11:57:37PM +0900, Akinobu Mita wrote:
The reason I didn't move sht from the core driver to the LLDDs for
fixing ufs and ums-* in the first place is to avoid exporting many
symbols for callbacks in sht. But I realized that we can do it
without that many
On Mon, Jan 19, 2015 at 12:05:58AM +0900, Akinobu Mita wrote:
While accessing a scsi_device, the use count of the underlying LLDD
module is incremented. The module reference is retrieved through
.module field of struct scsi_host_template.
This mapping between scsi_device and underlying LLDD
Hello, Alan.
On Thu, Jan 15, 2015 at 01:22:03PM -0500, Alan Stern wrote:
It has a reference to keep it from beeing freed, but so far I can't find
anything that prevents -remove from beeing called while we are in or
just before a method call.
There are two types of methods to think about:
On Tue, Jan 06, 2015 at 01:51:15PM +0530, Suman Tripathi wrote:
Hi
On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote:
This patch addresses the issue with ATA_CMD_PACKET pio mode
command for enumeration and device detection with ATAPI devices.It is the
same issue as in patch
On Tue, Jan 06, 2015 at 03:32:14PM +0530, Suman Tripathi wrote:
This patch set implements the PMP support for APM X-Gene SoC AHCI SATA Host
Controller driver.
Hmm... still doesn't apply to for-3.20 after pulling in
for-3.19-fixes.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git
On Tue, Jan 06, 2015 at 07:10:31PM +0530, Suman Tripathi wrote:
Hi ,
For more info here is the git log output before applying the patch.
git log
commit b84b25cb0900b99b28c742dd33101be779f58259
Merge: 0628ee7 36aae28
Author: Tejun Heo t...@kernel.org
Date: Tue Jan 6 07:48:24 2015
On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote:
This patch addresses the issue with ATA_CMD_PACKET pio mode
command for enumeration and device detection with ATAPI devices.It is the
same issue as in patch
www.spinics.net/lists/linux-ide/msg49092.html
Signed-off-by: Suman
On Mon, Jan 05, 2015 at 08:30:05AM -0500, Tejun Heo wrote:
On Mon, Jan 05, 2015 at 03:51:45PM +0530, Suman Tripathi wrote:
Due to H/W errata, the controller is unable to save the PMP
field fetched from command header before sending the H2D FIS.
When the device returns the PMP port field
On Mon, Dec 29, 2014 at 08:52:47AM +0530, Suman Tripathi wrote:
This patch addresses the issue with ATA_CMD_PACKET pio mode
command for enumeration and device detection with ATAPI devices.
The X-Gene AHCI controller has an errata in which it cannot clear
the BSY bit after the PIO setup FIS.
On Mon, Jan 05, 2015 at 07:33:06PM +0530, Suman Tripathi wrote:
Reverted due to conflicts with the endian fix patches. Please rebase
these two on top of them.
Will do that .. I should have wait for the endian patch getting
accepted. Sorry for that.
Ooh, please don't be sorry. It's
On Mon, Jan 05, 2015 at 03:51:45PM +0530, Suman Tripathi wrote:
Due to H/W errata, the controller is unable to save the PMP
field fetched from command header before sending the H2D FIS.
When the device returns the PMP port field in the D2H FIS, there is
a mismatch and results in command
On Wed, Nov 05, 2014 at 01:08:19PM +0100, Hannes Reinecke wrote:
Hi all,
this patchset updates the ATA stack to correctly detect
host-managed ZAC devices.
Hannes Reinecke (3):
libsas: use ata_dev_classify()
libata: Implement ATA_DEV_ZAC
libata-scsi: Update SATL for ZAC drives
Hello,
On Tue, Oct 07, 2014 at 01:10:46AM +0200, Luis R. Rodriguez wrote:
On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote:
For in-kernel stuff, we already have a clear
synchronization point where we already synchronize all async calls.
Shouldn't we be flushing these async probes
Hello, Luis.
The patchset generally looks good to me. Please feel free to add
Reviewed-by: Tejun Heo t...@kernel.org
A question below.
On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote:
+ bus.enable_kern_async=1 [KNL]
+ This tells the kernel
Hello,
On Mon, Oct 06, 2014 at 10:36:27PM +0200, Luis R. Rodriguez wrote:
Do we intend to keep this param permanently? Isn't this more of a
temp tool to be used during development? If so, maybe we should make
that clear with __DEVEL__ too?
As its designed right now no, its not a temp
On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote:
libata already uses an internal buffer, so we should be using
__scsi_print_command() here.
Cc: Tejun Heo t...@kernel.org
Cc: linux-...@vger.kernel.org
Cc: LKML linux-ker...@vger.kernel.org
Signed-off-by: Hannes Reinecke h
On Mon, Sep 29, 2014 at 04:10:30PM +0200, Hannes Reinecke wrote:
On 09/29/2014 04:06 PM, Tejun Heo wrote:
On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote:
libata already uses an internal buffer, so we should be using
__scsi_print_command() here.
Cc: Tejun Heo t
Hello, Luis.
On Mon, Sep 29, 2014 at 11:22:08PM +0200, Luis R. Rodriguez wrote:
+ /* For now lets avoid stupid bug reports */
+ if (!strcmp(bus-name, pci) ||
+ !strcmp(bus-name, pci_express) ||
+ !strcmp(bus-name, hid) ||
+ !strcmp(bus-name, sdio) ||
+
Hello,
On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote:
...
Systemd should consider enabling async probe on device drivers
it loads through systemd-udev but probably does not want to
enable it for modules loaded through systemd-modules-load
(modules-load.d). At least on my
On Wed, Sep 24, 2014 at 08:30:33AM -0600, Jens Axboe wrote:
On 09/24/2014 02:23 AM, Christoph Hellwig wrote:
Thanks, this fixes the boot stall for me.
Tested-by: Christoph Hellwig h...@lst.de
Sweet, I'll shove this off today, so we are done for 3.17 release.
Cool, once it hits the
From 9eca80461a45177e456219a9cd944c27675d6512 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Wed, 24 Sep 2014 13:07:33 -0400
This reverts commit 0a30288da1aec914e158c2d7a3482a85f632750f, which
was a temporary fix for SCSI blk-mq stall issue. The following
patches will fix
On Tue, Sep 23, 2014 at 02:08:12AM -0400, Tejun Heo wrote:
From 83b06f4fc6ca2f7f3d706a168b71c248bdada668 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Tue, 23 Sep 2014 01:58:34 -0400
blk-mq uses percpu_ref for its usage counter which tracks the number
of in-flight commands
FYI, I added a paragraph explaining what happened to the temp fix at
the end. The following is the applied version.
Thanks.
- 8 -
From 17497acbdce9506fd6a75115dee4ab80c3cc5ee5 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Wed, 24 Sep 2014 13:31:50 -0400
blk-mq uses
On Tue, Sep 23, 2014 at 02:01:41AM -0400, Tejun Heo wrote:
On Tue, Sep 23, 2014 at 07:59:24AM +0200, Christoph Hellwig wrote:
[PATCHSET percpu/for-3.18] percpu_ref: implement switch_to_atomic/percpu()
looks way to big for 3.17, and the regression was introduced in the 3.17
merge window
From 83b06f4fc6ca2f7f3d706a168b71c248bdada668 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Tue, 23 Sep 2014 01:58:34 -0400
blk-mq uses percpu_ref for its usage counter which tracks the number
of in-flight commands and used to synchronously drain the queue on
freeze. percpu_ref
On Tue, Sep 23, 2014 at 08:09:06AM +0200, Christoph Hellwig wrote:
On Tue, Sep 23, 2014 at 02:01:41AM -0400, Tejun Heo wrote:
On Tue, Sep 23, 2014 at 07:59:24AM +0200, Christoph Hellwig wrote:
[PATCHSET percpu/for-3.18] percpu_ref: implement
switch_to_atomic/percpu()
looks way
On Mon, Sep 22, 2014 at 06:31:33PM +0530, Suman Tripathi wrote:
This patch fixes the error print invalid resource for the APM X-Gene
SoC AHCI SATA Host Controller driver. This print was due to the fact
that the controller 3 don't have a mux resource. This didn't result
in any errors but the
.
Signed-off-by: Tejun Heo t...@kernel.org
Reported-by: Christoph Hellwig h...@infradead.org
Link: http://lkml.kernel.org/g/20140919113815.ga10...@lst.de
Fixes: add703fda981 (blk-mq: use percpu_ref for mq usage count)
Cc: Kent Overstreet k...@daterainc.com
Cc: Jens Axboe ax...@kernel.dk
---
Hello
Oops, I forgot to cc Kent. Kent, the patch is at
http://lkml.kernel.org/g/20140923192432.ga24...@mtj.dyndns.org
On Tue, Sep 23, 2014 at 01:29:03PM -0600, Jens Axboe wrote:
The hack looks fine to me, if it passes Christophs boot stall test. The
hack isn't THAT nasty, since you already have a
On Tue, Sep 23, 2014 at 07:55:54AM +0200, Christoph Hellwig wrote:
Jens,
can we simply get these commits reverted from now if there's no better
fix? I'd hate to have this boot stall in the first kernel with blk-mq
support for scsi.
Patches going out right now.
Thanks.
--
tejun
--
To
On Tue, Sep 23, 2014 at 01:56:48AM -0400, Tejun Heo wrote:
On Tue, Sep 23, 2014 at 07:55:54AM +0200, Christoph Hellwig wrote:
Jens,
can we simply get these commits reverted from now if there's no better
fix? I'd hate to have this boot stall in the first kernel with blk-mq
support
On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote:
[suman] : So the posted version is acceptable ? Any others comments on this
patch ?
I'm suggesting setting ctx-cs_mux to NULL on failure. IOW,
if (res) {
ctx-csr_mux = devm_ioremap_resources();
Hello,
On Sun, Sep 14, 2014 at 11:36:51AM +0530, Suman Tripathi wrote:
We can maintain same piece (IS_ERR(ctx-csr_mux)), then we can do the
below instead of NULL ??
ctx-csr_mux = res ? devm_ioremap_resource(dev, res) : ERR_PTR(-EINVAL);
Setting it to NULL on failure would probably make
On Fri, Sep 12, 2014 at 01:24:08PM +0530, Suman Tripathi wrote:
This patch fixes the error print invalid resource for the APM X-Gene
SoC AHCI SATA Host Controller driver. This print was due to the fact
that the controller 3 don't have a mux resource. This didn't result
in any errors but the
Hello, Alan.
On Tue, Sep 09, 2014 at 11:08:22AM -0400, Alan Stern wrote:
Sorry, the meaning wasn't clear. I meant that the existing code
doesn't work. The patch seems to work okay (except that I can't use
queue_flag_test_and_set because the queue isn't locked at that point).
I'll submit
because of the unbalanced calls to
blk_queue_bypass_end().
This patch fixes the problem by making blk_register_queue() call
blk_queue_bypass_end() only the first time the queue is registered.
Signed-off-by: Alan Stern st...@rowland.harvard.edu
CC: Tejun Heo t...@kernel.org
CC: James Bottomley
Hey, James.
On Tue, Sep 09, 2014 at 12:35:46PM -0700, James Bottomley wrote:
I don't have very strong views on this one. However, I've got to say
from a systems point of view that if the desire is to flag when the
module is having problems, probing and initializing synchronously in a
thread
Hello,
On Tue, Sep 09, 2014 at 03:26:02PM -0700, James Bottomley wrote:
We no longer report back error on probe failure on module load.
Yes, we do; for every probe failure of a device on a driver we'll print
a warning (see drivers/base/dd.c). Now if someone is proposing we
should report
Hello, James.
On Tue, Sep 09, 2014 at 03:46:23PM -0700, James Bottomley wrote:
If you want the return of an individual device probe a log scraper gives
it to you ... and nothing else does currently. The advantage of the
prink in dd.c is that it's standard for everything and can be scanned
On Tue, Sep 09, 2014 at 12:25:29PM +0900, Tejun Heo wrote:
Hello,
On Mon, Sep 08, 2014 at 08:19:12PM -0700, Luis R. Rodriguez wrote:
On the systemd side of things it should enable this sysctl and for
older kernels what should it do?
Supposing the change is backported via -stable, it can
Hello, Luis.
On Mon, Sep 08, 2014 at 06:04:23PM -0700, Luis R. Rodriguez wrote:
I have no idea how the selection should be. It could be per-insmod or
maybe just a system-wide flag with explicit exceptions marked on
drivers is good enough. I don't know.
Its perfectly understandable if
On Tue, Sep 09, 2014 at 10:10:59AM +0900, Tejun Heo wrote:
* Identify cases which can't be asynchronous and make them
synchronous. e.g. keep who's doing request_module() and avoid
asynchronous probing if current is probing one of those.
That wouldn't work as we don't know what's gonna
Hello,
On Mon, Sep 08, 2014 at 01:42:44PM -0400, Alan Stern wrote:
This looks like a nasty hack. In theory the QUEUE_FLAG_INIT_DONE should
be unset on blk_unregister_queue() to match the teardown; it's only
accident it isn't. del_gendisk() in sd_remove() is supposed to tear a
lot of
On Tue, Sep 09, 2014 at 10:10:59AM +0900, Tejun Heo wrote:
I'm not too convinced this is such a difficult problem to figure out.
We already have most of logic in place and the only thing missing is
how to switch it. Wouldn't something like the following work?
* Add a sysctl knob to enable
On Mon, Sep 08, 2014 at 06:26:04PM -0700, Luis R. Rodriguez wrote:
Alternatively, add a module-generic param async_probe or whatever
and use that to switch the behavior should work too. I don't know
which way is better but either should work fine.
I take it by this you meant a generic
Hello,
On Mon, Sep 08, 2014 at 06:38:34PM -0700, Luis R. Rodriguez wrote:
OK then one only concern I would have with this is that the presence
of such a flag doesn't necessarily mean that all drivers on a system
have been tested for asynch probe yet. I'd feel much more comfortable
Given that
Hello,
On Mon, Sep 08, 2014 at 07:28:58PM -0700, Luis R. Rodriguez wrote:
Given that the behvaior change is from driver core and that device
probing can happen post-loading anyway,
Ah but lets not forget Dmitry's requirement which is for in-kernel
drivers. We'd need to deal with both
On Mon, Sep 08, 2014 at 07:57:28PM -0700, Luis R. Rodriguez wrote:
I think we
just should make exceptions sensible so that it works fine in practice
for now (and I don't think that'd be too hard). So, the only
cooperation necessary from userland would be just saying I don't
wanna wait
101 - 200 of 637 matches
Mail list logo
