Hello,
On Mon, Sep 08, 2014 at 08:19:12PM -0700, Luis R. Rodriguez wrote:
On the systemd side of things it should enable this sysctl and for
older kernels what should it do?
Supposing the change is backported via -stable, it can try to set the
sysctl on all kernels. If the knob doesn't exist,
On Sun, Sep 07, 2014 at 01:24:47PM +0200, Hannes Reinecke wrote:
Which was actually my first attempt, but then I figured I'd be
increasing the stacksize in doing so.
But sure, if you're okay with it I'll be redoing the patch.
The struct is only 32 bytes. I don't think it's gonna make any
Hello,
On Sat, Sep 06, 2014 at 10:21:51AM +0200, Hannes Reinecke wrote:
Well, yes, in principle. I was looking into that, too.
But then I figured that moving to ata_taskfile would be a major overhaul for
libsas, which would be quite beyond scope here.
And all for a puny little patch.
Hmm?
On Thu, Sep 04, 2014 at 11:37:24PM -0700, Luis R. Rodriguez wrote:
...
+ /*
+ * I got SIGKILL, but wait for 60 more seconds for completion
+ * unless chosen by the OOM killer. This delay is there as a
+ * workaround for boot failure caused by
approach of trying to mark specific drivers as needing
async probing is completely broken for the problem at hand. It
can't address the problem adequately while breaking backward
compatibility. I don't think this makes much sense.
Nacked-by: Tejun Heo t...@kernel.org
Thanks.
--
tejun
Hello,
On Fri, Sep 05, 2014 at 09:44:05AM -0700, Dmitry Torokhov wrote:
Which problem are we talking about here though? It does solve the slow device
stalling the rest if the kernel booting (non-module case) for me.
The other one. The one with timeout. Neither cxgb4 or pata_marvell
has slow
On Sat, Sep 06, 2014 at 07:29:56AM +0900, Tejun Heo wrote:
It is for storage devices which always have guaranteed synchronous
probing on module load and well-defined probing order. Sure, modern
setups are a lot more dynamic but I'm quite certain that there are
setups in the wild which depend
Hello, Luis.
On Fri, Sep 05, 2014 at 11:12:17AM -0700, Luis R. Rodriguez wrote:
Meanwhile we are allowing a major design consideration such as a 30
second timeout for both init + probe all of a sudden become a hard
requirement for device drivers. I see your point but can't also be
introducing
Hello, Dmitry.
On Fri, Sep 05, 2014 at 03:49:17PM -0700, Dmitry Torokhov wrote:
On Sat, Sep 06, 2014 at 07:31:39AM +0900, Tejun Heo wrote:
On Sat, Sep 06, 2014 at 07:29:56AM +0900, Tejun Heo wrote:
It is for storage devices which always have guaranteed synchronous
probing on module load
Hello,
On Fri, Sep 05, 2014 at 03:52:48PM -0700, Dmitry Torokhov wrote:
Ahem... and they sure it works reliably with large storage arrays? With
SCSI doing probing asynchronously already?
I believe this has been mentioned before too but, yes, SCSI device
probing is asynchronous and parallelized
Hey,
On Fri, Sep 05, 2014 at 04:22:42PM -0700, Dmitry Torokhov wrote:
I don't get it. This is a behavior userland already depends on for
boots. What's there to agree or disagree? This is just a fact that
we can't do this w/o disturbing some userlands in a major way.
I am just
On Thu, Aug 28, 2014 at 02:51:22PM +0530, Suman Tripathi wrote:
Due to HW errata the APM X-Gene AHCI SATA host controller reports link
down even if the device presence is detected. This issue is due to speed
negotiation failure. This patch implements the algorithm to retry the
COMRESET if
On Thu, Aug 28, 2014 at 02:51:21PM +0530, Suman Tripathi wrote:
This patch implements the feature to skip the PHY and clock
initialization if it is already configured by the firmware.
Signed-off-by: Loc Ho l...@apm.com
Signed-off-by: Suman Tripathi stripa...@apm.com
Applied to
On Tue, Aug 26, 2014 at 12:17:35PM +0530, Suman Tripathi wrote:
Didn't I ask you to update the comment to explain what's going on?
[suman] : can you specifically tell which part of the comment is not clear
and need more explanation?
The comment on top of the function doesn't seem to match
On Sun, Aug 24, 2014 at 12:07:27AM +0530, Suman Tripathi wrote:
This patch addresses two HW erratas as described below by retrying the
COMRESET:
1. During speed negotiation, controller is not able to detect ALIGN
at GEN3(6Gbps) within 54.6us and results in a timeout. This issue can
be
On Thu, Aug 21, 2014 at 01:48:00PM +0530, Suman Tripathi wrote:
[suman] : The problem is COMRESET didn't failed. I meant the hardreset is
successful (return 0) but the device is not detected even if device is
present due to speed negotiation failure. For that reason I check for the
Pxstatus
On Tue, Aug 19, 2014 at 12:01:51PM +0530, Suman Tripathi wrote:
The link down issue in first attempt happens due to 2 H/W errata below:
1. Due to HW errata, during speed negotiation, sometimes controller
is not able to detect ALIGN at GEN3(6Gbps) within 54.6us results in
a timeout. This
On Fri, Aug 08, 2014 at 09:44:25PM +0530, Suman Tripathi wrote:
This patch removes the NCQ support from the APM X-Gene SoC AHCI
Host Controller driver as it doesn't support it.
Signed-off-by: Loc Ho l...@apm.com
Signed-off-by: Suman Tripathi stripa...@apm.com
Applied to
On Tue, Jul 29, 2014 at 12:24:48PM +0530, Suman Tripathi wrote:
This patch set contains a couple of fixes related to APM X-Gene SATA
controller driver.
v2 Change:
1. Drop the Link down retry patch from this patch set.
v4 Change:
1. Drop the patch to fix the csr-mask in dts for PHY
On Tue, Jul 29, 2014 at 08:05:45PM +0530, Suman Tripathi wrote:
Hi,
Applied 1 and 3 to libata/for-3.17. 4 doesn't apply. Also, please
prefix the patches with ahci_xgene: from now on.
[suman] : You mean the Remove NCQ patch is not applied. Any reason for
that ?
I meant that the patch
On Thu, Jul 10, 2014 at 07:19:15PM +0530, Suman Tripathi wrote:
This patch fixes the watermark threshold of the receive FIFO for the
APM X-Gene SATA host controller driver.
Can you please explain what are the effects of these patches? Patch
descriptions should include why the specific changes
On Thu, Jul 10, 2014 at 07:19:16PM +0530, Suman Tripathi wrote:
This patch fixes the SATA PHY clock DTS node csr-mask of the
SATA Host controller 1. This patch also fixes the status of
the PHY clock node of SATA Host Controller 1.
Ditto. Before, XXX was wrong and as a result YYY didn't work
On Mon, Jul 07, 2014 at 10:33:03PM +0530, Suman Tripathi wrote:
This patch addresses the dma state machine lockup for APM X-Gene SoC.
Signed-off-by: Loc Ho l...@apm.com
Signed-off-by: Suman Tripathi stripa...@apm.com
Applied to libata/for-3.16-fixes.
Thanks.
--
tejun
--
To unsubscribe
Hello,
On Wed, Jul 02, 2014 at 03:45:07PM +0530, Suman Tripathi wrote:
+int ahci_restart_engine(struct ata_port *ap)
+{
+ struct ahci_host_priv *hpriv = ap-host-private_data;
+
+ ahci_stop_engine(ap);
+ ahci_start_fis_rx(ap);
+ hpriv-start_engine(ap);
+
+ return 0;
Hello,
On Mon, Jun 23, 2014 at 03:23:13PM +0530, Suman Tripathi wrote:
This patch fixes the dma state machine lockup due to the processing
of IDENTIFY DEVICE PIO mode command. The X-Gene AHCI controller
has an errata in which it cannot clear the BSY bit after
receiving the PIO setup FIS and
Hello,
On Mon, Jun 23, 2014 at 03:45:37PM +0530, Suman Tripathi wrote:
@@ -234,15 +237,20 @@ static int xgene_ahci_do_hardreset(struct ata_link
*link,
u8 *d2h_fis = pp-rx_fis + RX_FIS_D2H_REG;
void __iomem *port_mmio = ahci_port_base(ap);
struct ata_taskfile tf;
+ int
On Thu, Jun 19, 2014 at 12:20:54PM +0530, Suman Tripathi wrote:
+ /*
+ * Restart the dma engine if the last cmd issued
+ * is IDENTIFY DEVICE command
+ */
+ if (unlikely(ctx-last_cmd[ap-port_no] == ATA_CMD_ID_ATA))
+ ahci_restart_engine(ap);
Is it really
Two more things.
On Thu, Jun 19, 2014 at 12:20:54PM +0530, Suman Tripathi wrote:
/**
+ * xgene_ahci_qc_issue - Issue commands to the device
+ * @qc: Command to issue
+ *
+ * Due to H/W errata, for the IENTIFY DEVICE command
+ * controller is unable to clear the BSY bit after
+ * receiving
On Thu, Jun 19, 2014 at 07:44:28PM +0530, Suman Tripathi wrote:
Hi Tejun,
On Thu, Jun 19, 2014 at 12:20:54PM +0530, Suman Tripathi wrote:
+ /*
+ * Restart the dma engine if the last cmd issued
+ * is IDENTIFY DEVICE command
+ */
+ if
Hello,
On Thu, Jun 19, 2014 at 07:57:33PM +0530, Suman Tripathi wrote:
[suman] : Are you ok if I make ahci_qc_issue in the ahci.h as not static
and make it as EXPORT_SYMBOL_GPL ? Currenty ahci_qc_issue is static.
If you take the current case , I only had to make ahci_sw_activity as non
Hello,
On Mon, Jun 16, 2014 at 03:05:35PM +0530, Suman Tripathi wrote:
This patch implements the function ahci_restart_engine function to restart
the port dma engine.
Please fit the text under 80 column.
---
I can't apply w/o your SOB.
+int ahci_restart_engine(struct ata_port *ap)
+{
+
On Mon, Jun 16, 2014 at 03:05:36PM +0530, Suman Tripathi wrote:
This patch fixes the dma state machine lockup due to the IDENTIFY DEVICE PIO
mode command. The controller is unable to clear the BSY bit after receiving
the PIO setup FIS and results the dma state machine to go into the
On Sat, Jun 07, 2014 at 02:58:53AM +0530, Suman Tripathi wrote:
This patch implements the function restart_engine function to add the
flexibility to restart the port dma engine from the libata framework.
Signed-off-by: Loc Ho l...@apm.com
Signed-off-by: Suman Tripathi stripa...@apm.com
On Sat, Jun 07, 2014 at 02:58:54AM +0530, Suman Tripathi wrote:
@@ -5072,6 +5072,16 @@ int ata_qc_complete_multiple(struct ata_port *ap, u32
qc_active)
if (qc) {
ata_qc_complete(qc);
nr_done++;
+ /*
+
On Thu, Apr 24, 2014 at 09:27:03PM +0800, Xiangliang Yu wrote:
This patch set will support SATA port multiplier(PM) in LIBSAS.
LIBSAS is need to implement several key handling to support SATA PM:
First,low level driver notify libsas that SATA PM is attached to HBA port.
Then, LIBSAS will
On Wed, Mar 19, 2014 at 10:46:25AM -0700, Randy Dunlap wrote:
From: Randy Dunlap rdun...@infradead.org
Fix build error when CONFIG_PM is not enabled by adding a stub
function in linux/libata.h.
drivers/scsi/libsas/sas_ata.c: In function 'sas_resume_sata':
On Wed, Mar 19, 2014 at 11:14:15AM -0700, Dan Williams wrote:
Subject: libata: remove unused ata_sas_port_async_resume() stub
From: Dan Williams dan.j.willi...@intel.com
Commit bc6e7c4b0d1a libata, libsas: kill pm_result and related cleanup
renamed ata_sas_port_async_resume() to
://marc.info/?l=linux-scsim=138995409532286w=2
Cc: Phillip Susi ps...@ubuntu.com
Cc: Alan Stern st...@rowland.harvard.edu
Suggested-by: Tejun Heo t...@kernel.org
Signed-off-by: Todd Brandt todd.e.bra...@intel.com
Signed-off-by: Dan Williams dan.j.willi...@intel.com
Can somebody ack the sas
On Tue, Mar 18, 2014 at 12:14:37PM -0600, Loc Ho wrote:
This patch fixes an compiler warning with APM X-Gene host controller
driver when compiled with DEBUG enabled.
Signed-off-by: Loc Ho l...@apm.com
Applied to libata/for-3.15.
Thanks.
--
tejun
--
To unsubscribe from this list: send the
://marc.info/?l=linux-scsim=138995409532286w=2
Cc: Phillip Susi ps...@ubuntu.com
Cc: Alan Stern st...@rowland.harvard.edu
Suggested-by: Tejun Heo t...@kernel.org
Signed-off-by: Todd Brandt todd.e.bra...@intel.com
Signed-off-by: Dan Williams dan.j.willi...@intel.com
Applied 1-2 to libata
On Fri, Mar 14, 2014 at 05:53:17PM -0600, Loc Ho wrote:
This patch adds support for the APM X-Gene SoC AHCI SATA host controller. In
order for the host controller to work, the corresponding PHY driver
musts also be available. Currently, only Gen3 disk is supported with this
initial version.
On Wed, Mar 05, 2014 at 03:44:49PM -0700, Loc Ho wrote:
This patch adds APM X-Gene SoC AHCI SATA host controller DTS entries.
I pulled the phy branch into libata/for-3.15 but this patch fails to
apply. Can you please regenerate the patches which need to be applied
on top of libata/for-3.15.
Hello, Loc.
On Tue, Mar 11, 2014 at 08:51:37AM -0700, Loc Ho wrote:
Kishon didn't applied the PHY DTS patch. Did you first apply the PHY
DTS patch? We agreed that you will first pull in the PHY DTS as well
as the host controller patches. I don't see any reason why it wouldn't
apply if both
Hello,
On Wed, Mar 05, 2014 at 12:17:30PM -0800, Dan Williams wrote:
+#define ata_port_resume_sync(ap, msg) ata_port_resume_common((ap), (msg),
false)
+#define queue_ata_port_resume(ap, msg) ata_port_resume_common((ap), (msg),
true)
Let's please use proper static functions. The compiler
On Fri, Mar 07, 2014 at 06:52:06PM -0800, Dan Williams wrote:
From: Dan Williams dan.j.willi...@intel.com
async_schedule() sd resume work to allow disks and other devices to
resume in parallel.
This moves the entirety of scsi_device resume to an async context to
ensure that
On Mon, Mar 10, 2014 at 04:29:47PM -0400, Tejun Heo wrote:
Let's please use proper static functions. The compiler can deal with
inlining. Also, maybe ata_port_resume() and ata_port_resume_async()
are better names for the wrappers?
So, if the suggested names don't jive well with the rest
On Sun, Mar 09, 2014 at 10:23:33PM -0700, Loc Ho wrote:
Hi Tejun,
On Fri, Mar 7, 2014 at 9:28 AM, Loc Ho l...@apm.com wrote:
This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose
PHY driver. The PHY for SATA controller 2 and 3 are enabled by default.
PREPARE_DELAYED_WORK().
This fixes a variety of possible regressions since a2c1c57be8d9
workqueue: consider work function when searching for busy work items
due to which fw_workqueue lost its required non-reentrancy property.
Signed-off-by: Tejun Heo t...@kernel.org
Acked-by: Stefan Richter stef...@s5r6
Hello, Loc.
Almost there. Just one more thing.
On Sun, Feb 23, 2014 at 10:54:24PM -0700, Loc Ho wrote:
+static int xgene_ahci_init_memram(struct xgene_ahci_context *ctx)
+{
+ void __iomem *diagcsr = ctx-csr_base + SATA_DIAG_OFFSET;
+ int try;
+ u32 val;
+
+ val =
Hey,
On Mon, Feb 24, 2014 at 05:02:52PM -0800, Loc Ho wrote:
The completion of the RAM removal from shutdown is quite fast. As per
spec, the max time is 1ms but from the run-time code, it only take one
(1us) or two (2us) read for this to completed. An 1 ms hard delay is more
than 100 time
On Fri, Feb 21, 2014 at 12:13:16AM -0500, Peter Hurley wrote:
CPU 0| CPU 1
|
INIT_WORK(fw_device_workfn) |
|
workfn = funcA |
queue_work_on() |
.
Yo,
On Fri, Feb 21, 2014 at 11:53:46AM -0500, Peter Hurley wrote:
Ok, I can do that. But AFAIK it'll have to be an smp_rmb(); there is
no mb__after unlock.
We do have smp_mb__after_unlock_lock().
[ After thinking about it some, I don't think preventing speculative
writes before clearing
On Fri, Feb 21, 2014 at 06:01:29PM -0500, Peter Hurley wrote:
smp_mb__after_unlock_lock() is only for ordering memory operations
between two spin-locked sections on either the same lock or by
the same task/cpu. Like:
i = 1
spin_unlock(lock1)
spin_lock(lock2)
PREPARE_DELAYED_WORK().
It would probably be best to route this with other related updates
through the workqueue tree.
Compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Stefan Richter stef...@s5r6.in-berlin.de
Cc: linux1394-de...@lists.sourceforge.net
Cc: Chris Boot bo...@bootc.net
Cc: linux-scsi
On Thu, Feb 20, 2014 at 09:07:27PM -0500, Peter Hurley wrote:
On 02/20/2014 08:59 PM, Tejun Heo wrote:
Hello,
On Thu, Feb 20, 2014 at 08:44:46PM -0500, Peter Hurley wrote:
+static void fw_device_workfn(struct work_struct *work)
+{
+ struct fw_device *device = container_of(to_delayed_work
Hello, Loc.
On Thu, Feb 13, 2014 at 03:28:01PM -0800, Loc Ho wrote:
1. There are a number of errata that require workaround. Some can be
fixed by adding broken flags while others are better to just wrap
around the existent libahci library routines and not overly polluting
the libahci
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
Hello,
On Fri, Jan 17, 2014 at 08:41:00PM -0500, Alan Stern wrote:
The intention is that this will help on systems with more than one
disk drive. The one containing the core OS files and the journal will
certainly spin up right away, but the others may not.
To tell the truth, I'm not sure
Hello, Phillip.
On Fri, Jan 17, 2014 at 03:55:30PM -0500, Phillip Susi wrote:
What kind of use cases are we expecting for the lazy behavior?
Not all systems only have a single drive. There may be a tendency for
IO to the drive with the root fs on it after a resume, but multi drive
systems
pretty
much too late.
Tejun, if you want to ack that one, I can put it in either the first
3.14 pull request or a subsequent one. Either way, since it's a
regression fix, we should be able to get it in 3.14.
Acked-by: Tejun Heo t...@kernel.org
Please feel free to route it any way you see
Hello,
On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote:
The START-STOP may result in an error. What do you do in that case?
At least for libata, worrying about suspend/resume failures don't make
whole lot of sense. If suspend failed, just proceed with suspend. If
the device
Hello, James.
On Fri, Jan 17, 2014 at 10:39:37AM -0800, James Bottomley wrote:
The specific worry is the writeback cache. If the flush fails and we
power down with dirty blocks in the cache, those blocks are lost but the
filesystem still thinks they're committed. I think as long as you're
On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote:
You will have to argue this point with Phillip.
If necessary, we could add a sysfs attribute to force a spin-up during
system resume. Or you could disable runtime PM for the disk, but that
has its own disadvantages.
Isn't
Please start a new thread when you're posting a new version of the
whole series don't use the same patch title for the patches. They
do different things. They need different names.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
Hello,
On Tue, Jan 14, 2014 at 04:31:40PM -0800, Todd E Brandt wrote:
Signed-off-by: Todd Brandt todd.e.bra...@intel.com
Signed-off-by: Arjan van de Ven ar...@linux.intel.com
drivers/ata/libata-core.c | 32 +---
1 file changed, 17 insertions(+), 15
Hello, Todd.
On Mon, Jan 13, 2014 at 03:30:26PM -0800, Todd E Brandt wrote:
Ahh, sorry, yea I think async should work for the entire resume pathway. Would
you be willing to accept this ata patch separately from the scsi one? It
wouldn't provide any performance benefit on its own, but would
Hello, Gwendal.
On Mon, Jan 13, 2014 at 04:36:52PM -0800, Gwendal Grignou wrote:
Won't this patch defeat staggered spinup at resume? If you have a jbod
with a smallish power supply, with a 12V rail designed for the steady
state and 1 or 2 devices spinning up at once, you may be in trouble
Hey,
On Tue, Jan 14, 2014 at 07:57:19AM -0800, Loc Ho wrote:
No, they don't and the comments in your driver don't really explain
what's going on. Why are we having retry loops inside hardreset
itself? This can prolong recovery time significantly in corner cases.
Why is this necessary?
On Tue, Jan 14, 2014 at 11:03:12AM -0500, Tejun Heo wrote:
As mentioned, the flush requires immediately after reading the CI.
Otherwise, there is still an chance that the command is completed and
the OS notified the upper layer while the data is still in flight. For
the initial version, I
On Tue, Jan 14, 2014 at 08:21:28AM -0800, Loc Ho wrote:
In the ISR, the AHCI library code reads the CI register and then
performs XOR to determine which commands are completed. Then it goes
and processes the completed command(s). I am worry that the process of
processing the completed
On Tue, Jan 14, 2014 at 08:37:18AM -0800, Loc Ho wrote:
This issue has NOT been observed but the design has this issue and
observed from verification. As a mean to ensure that this never occur
from design itself, this is the workaround and only apply to SATA and
SDIO. The SDIO don't need this
Hello, Loc.
On Sun, Jan 12, 2014 at 08:01:59PM -0800, Loc Ho wrote:
Yes but Let me summary what overrides are required for this X-Gene
SATA controller driver:
1. For Query ID, these two functions - ahci_read_id and ahci_qc_issue
requires override.
But the comment in ahci_qc_issue() says
Hello,
On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote:
I see your point, why have two paths if one will do. The only thing that
worries me is that the PM resume from hibernate function doesn't have
an error handler. What happens when it tries to read the image from swap
and the
Hello,
On Sat, Jan 11, 2014 at 07:58:04PM -0800, Loc Ho wrote:
The flush has to occurred immediately after reading the CI
register. It can not wrap around the isr routine and issue the flush
after or before the library ahci isr routine.
I see. So, you're saying that if PMP support is
Hello,
On Tue, Jan 07, 2014 at 04:56:07PM -0800, Todd E Brandt wrote:
On resume, the ATA port driver currently waits until the AHCI controller
finishes executing the port wakeup command. This patch changes the
Is there anything ahci specific about this? There shouldn't be.
This patch only
Hello, David.
On Fri, Jan 10, 2014 at 02:07:21PM -0600, David Milburn wrote:
Tejun, to avoid some of the interrupt handling code duplication, would
it better to have a AHCI_HFLAG_FLUSH and then change
this driver to set flush
hpriv-hpriv.flush = (void *) xgene_ahci_iob_flush;
and then
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
On Mon, Nov 11, 2013 at 12:08:49PM -0500, Phillip Susi wrote:
No, I did not tune my system; I fixed the kernel so that userspace's
activities do not start those disks.
So, umm, implementing things in kernel to facilitate userland is great
but please don't try to work around userland from
Hello, guys.
(cc'ing Greg)
On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote:
On Fri, 13 Dec 2013, Sarah Sharp wrote:
Given the way things work now, I suspect these warnings are truly
harmless. We could simply get rid of the WARN in sysfs_remove_group.
The alternative
Hey, guys.
On Tue, Nov 19, 2013 at 04:53:16PM -0700, Loc Ho wrote:
This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the
physical layer interface for the corresponding SATA host controller. This
driver uses the new PHY generic framework posted by Kishon Vijay Abrahm.
Hmm...
Hello, Arnd.
On Wed, Nov 20, 2013 at 10:41 AM, Arnd Bergmann a...@arndb.de wrote:
It needs to be in drivers/phy, which is currently being prepared for
the next merge window and which contains the generic interface used
in this driver.
Ah, cool, so I don't need to worry about this one, right?
Hello,
On Tue, Oct 08, 2013 at 02:22:16PM +0200, Alexander Gordeev wrote:
If we talk about pSeries quota, then the current pSeries pci_enable_msix()
implementation is racy internally and could fail if the quota went down
*while* pci_enable_msix() is executing. In this case the loop will have
Hello,
On Wed, Oct 09, 2013 at 02:57:16PM +0200, Alexander Gordeev wrote:
On Mon, Oct 07, 2013 at 02:01:11PM -0400, Tejun Heo wrote:
Hmmm... yean, the race condition could be an issue as multiple msi
allocation might fail even if the driver can and explicitly handle
multiple allocation
On Mon, Oct 07, 2013 at 09:48:01PM +0100, Ben Hutchings wrote:
There is one major flaw in min-max approach - the generic MSI layer
will have to take decisions on exact number of MSIs to request, not
device drivers.
[...
No, the min-max functions should be implemented using the same loop
Hello, Alexander.
On Tue, Oct 08, 2013 at 09:48:26AM +0200, Alexander Gordeev wrote:
If there are many which duplicate the above pattern, it'd probably be
worthwhile to provide a helper? It's usually a good idea to reduce
the amount of boilerplate code in drivers.
I wanted to limit
Hello,
On Tue, Oct 08, 2013 at 11:07:16AM +0200, Alexander Gordeev wrote:
Multipe MSIs is just a handful of drivers, really. MSI-X impact still
Yes, so it's pretty nice to try out things there before going full-on.
will be huge. But if we opt a different name for the new pci_enable_msix()
Hey, guys.
On Sun, Oct 06, 2013 at 09:10:30AM +0200, Alexander Gordeev wrote:
On Sun, Oct 06, 2013 at 05:19:46PM +1100, Benjamin Herrenschmidt wrote:
On Sun, 2013-10-06 at 08:02 +0200, Alexander Gordeev wrote:
In fact, in the current design to address the quota race decently the
drivers
Hello,
On Wed, Oct 02, 2013 at 12:48:21PM +0200, Alexander Gordeev wrote:
Make pci_msix_table_size() to return a error code if the device
does not support MSI-X. This update is needed to facilitate a
forthcoming re-design MSI/MSI-X interrupts enabling pattern.
Device drivers will use this
Hello,
On Wed, Oct 02, 2013 at 12:48:23PM +0200, Alexander Gordeev wrote:
+static int foo_driver_enable_msi(struct foo_adapter *adapter, int nvec)
+{
+ rc = pci_get_msi_cap(adapter-pdev);
+ if (rc 0)
+ return rc;
+
+ nvec = min(nvec, rc);
+ if (nvec
Hello, Alexander.
On Wed, Oct 02, 2013 at 12:48:16PM +0200, Alexander Gordeev wrote:
Alexander Gordeev (77):
PCI/MSI: Fix return value when populate_msi_sysfs() failed
PCI/MSI/PPC: Fix wrong RTAS error code reporting
PCI/MSI/s390: Fix single MSI only check
PCI/MSI/s390: Remove
Hello, (cc'ing linux-scsi)
On Wed, Sep 25, 2013 at 01:37:51PM -0700, Anatol Pomozov wrote:
Hi
On Wed, Sep 4, 2013 at 9:07 AM, Tejun Heo t...@kernel.org wrote:
Hello,
On Wed, Sep 04, 2013 at 08:45:33AM -0700, Anatol Pomozov wrote:
I am not an expect in block code, so I have a few
Hey, Hannes.
On Thu, Sep 26, 2013 at 04:18:34PM +0200, Hannes Reinecke wrote:
However, none of the modern devices should be using this lock
switching, so I would just ignore it.
EG SCSI most definitely doesn't use it.
The kernel is crashing from it, so I don't think ignoring is an
acceptable
Hello,
On Thu, Sep 26, 2013 at 09:23:19AM -0700, Anatol Pomozov wrote:
We use modified version of sbull block device driver from GKH book.
We use it for testing block device startup/shutdown path + CFQ
manipulation.
The sbull driver uses function
blk_init_queue(..., dev-qlock);
it
Hello,
On Sun, Sep 22, 2013 at 02:51:51PM -0700, Dmitry Vyukov wrote:
Yeah, could be. IIRC, there's still race condition in block / scsi
timeout handling. Hmmm...
Is there an open bug for this?
Not that I know of. ISTR a couple threads about it. My memory is
quite hazy as usual but
(cc'ing SCSI people)
On Wed, Sep 18, 2013 at 11:45:22AM -0700, Dmitry Vyukov wrote:
Hi!
I am working on AddressSanitizer -- a tool that detects use-after-free
and out-of-bounds bugs
(https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel).
Below is one of the bug
Hello,
On Sun, Sep 22, 2013 at 11:59:53AM -0700, Dmitry Vyukov wrote:
I've noticed that free happens in scsi_error_handler thread, so maybe
a timeout or some other error condition is involved here.
It is possible that timeout happens while the request is still being
in process of submitting
direct write accesses to using the correct API.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
Acked-by: Tejun Heo t...@kernel.org
The patch is pretty widely spread. I don't mind how it gets routed
but what's the plan?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line
201 - 300 of 637 matches
Mail list logo
