Re: SCSI breakage on non-cache coherent architectures

2007-11-20 Thread Thomas Bogendoerfer
On Tue, Nov 20, 2007 at 06:51:14AM +1100, Benjamin Herrenschmidt wrote: > > On Mon, 2007-11-19 at 00:38 -0800, David Miller wrote: > > From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > Date: Mon, 19 Nov 2007 16:35:23 +1100 > > > > > I'm not sure what is the best way to fix that. Internally, I'

[PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-11-26 Thread Thomas Bogendoerfer
: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- drivers/scsi/sgiwd93.c | 68 ++- 1 files changed, 43 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c index eef8275..d4e6468 100644 --- a/drivers/scsi/sgi

Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-11-27 Thread Thomas Bogendoerfer
On Tue, Nov 27, 2007 at 09:28:14AM +0100, Geert Uytterhoeven wrote: > > struct hpc_chunk { > > struct hpc_dma_desc desc; > > - u32 _padding; /* align to quadword boundary */ > > + u32 _padding[128/4 - 3];/* align to biggest cache line size */ > ^ > (1

Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-11-27 Thread Thomas Bogendoerfer
On Wed, Nov 28, 2007 at 12:00:39AM +0100, peter fuerst wrote: > unlike with sgiseeq.c, in sgiwd93.c there's no need to bloat the hpc_chunk > and only a single dma_cache_sync-call is necessary in fill_hpc_entries and > init_hpc_chain respectively. funny I realized that a couple of minutes ago. A ke

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-11-28 Thread Thomas Bogendoerfer
to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- drivers/scsi/sgiwd93.c | 64 +-- 1 files changed, 39 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-12-02 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - added K

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Thomas Bogendoerfer
On Fri, Dec 21, 2007 at 06:16:41AM -0700, Matthew Wilcox wrote: > On Fri, Dec 21, 2007 at 10:33:26AM +, Alan Cox wrote: > > On Fri, 21 Dec 2007 13:30:08 +1100 > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly > >

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Thomas Bogendoerfer
On Fri, Dec 21, 2007 at 07:00:25AM -0700, Matthew Wilcox wrote: > On Fri, Dec 21, 2007 at 02:30:28PM +0100, Thomas Bogendoerfer wrote: > > there are SCSI host drivers, which also DMA to the sense buffer like > > sgiwd93.c for example. > > Yes ... and there are others whi

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-25 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - added K

Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-26 Thread Thomas Bogendoerfer
On Fri, Jan 25, 2008 at 10:44:40AM -0600, James Bottomley wrote: > > + void *cpu; > > + void *dev; > > This should be struct device *dev; shouldn't it (that seems to be how > it's always used)? of course, no need for the void *. > And that should be dma_free_noncoherent(&pdev->dev, ...) shou

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-26 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - struct

[PATCH] SUN3X_ESP: converted to esp_scsi.c

2008-01-31 Thread Thomas Bogendoerfer
Converted sun3x_esp driver to use esp_scsi.c Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- drivers/scsi/Kconfig |1 + drivers/scsi/Makefile|2 +- drivers/scsi/sun3x_esp.c | 546 -- 3 files changed, 237 insertions(+

Re: [SCSI] sun3x_esp: convert to esp_scsi

2008-02-11 Thread Thomas Bogendoerfer
On Sun, Feb 10, 2008 at 10:38:15AM +0100, Kars de Jong wrote: > Thomas, can't you use ioreadxx() and friends instead of rolling your own > memory mapped I/O handlers? well, at least ioread32be/iowrite32be are looking promising, but a quick grep didn't show them for m68k. > readxx() and friends ar

[PATCH] jazz_esp converted to use esp_core

2007-05-21 Thread Thomas Bogendoerfer
Hi, after chasing and fixing two jazz platform bugs and one MIPS dma mapping bug, I finally succeeded in using the Dave's new esp_core (great work, thank you Dave). Below is the patch. Thomas. Use new SCCI_ESP_CORE for JAZZ SCSS host adapter driver Signed-off-by: Thomas Bogendoerfer &l

Re: [PATCH] jazz_esp converted to use esp_core

2007-05-22 Thread Thomas Bogendoerfer
On Tue, May 22, 2007 at 12:00:41AM +0100, Christoph Hellwig wrote: > On Mon, May 21, 2007 at 11:02:24PM +0200, Thomas Bogendoerfer wrote: > > after chasing and fixing two jazz platform bugs and one MIPS dma mapping > > bug, I finally succeeded in using the Dave's new

[UPDATED PATCH] jazz_esp converted to use esp_core

2007-05-22 Thread Thomas Bogendoerfer
Here is an updated patch for converting jazz_esp to use esp_scsi. Thomas. Use new esp_scsi for JAZZ SCSI host adapter driver Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile index 51e884f..fc05d90 100644 --- a/driver

[PATCH] Cleanup sni_53c710

2007-07-11 Thread Thomas Bogendoerfer
- base address is now a physical address; no need to convert it - remove not needed error printk in module init function Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/sni_53c710.c b/drivers/scsi/sni_53c710.c index a7dfb65..0a6b45b 100644 --- a/driver

[PATCH] Remove printk, which triggers because of low scsi clock on SNI RMs

2007-07-11 Thread Thomas Bogendoerfer
remove printk, which triggers because of low scsi clock on SNI RMs Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index cb02656..b5ee4b3 100644 --- a/drivers/scsi/53c700.c +++ b/drivers/scsi/53c700.c @@ -267,8

PATCH: Allow setting burst length for 53C700

2006-12-25 Thread Thomas Bogendoerfer
rom eb46a70296fd0615ac7d8ee036d0554e8d30c1f2 Mon Sep 17 00:00:00 2001 From: Thomas Bogendoerfer <[EMAIL PROTECTED]> Date: Mon, 25 Dec 2006 20:48:34 +0100 Subject: [PATCH] change burst_disable to burst_length to allow setting of different burst lengths --- drivers/scsi/53c700.c | 24 +--- dri

PATCH: SNI RM 53c710 driver

2006-12-25 Thread Thomas Bogendoerfer
This patch adds a SCSI driver for the onboard 53c710 chip of some SNI RM machines. Thomas. >From ec2d61072027892d67a34d261bd39b32bacd1e64 Mon Sep 17 00:00:00 2001 From: Thomas Bogendoerfer <[EMAIL PROTECTED]> Date: Mon, 25 Dec 2006 21:04:17 +0100 Subject: [PATCH] Support for onb

Re: PATCH: SNI RM 53c710 driver

2007-01-09 Thread Thomas Bogendoerfer
On Tue, Jan 02, 2007 at 11:52:41AM +, Christoph Hellwig wrote: > On Mon, Dec 25, 2006 at 09:32:04PM +0100, Thomas Bogendoerfer wrote: > > This patch adds a SCSI driver for the onboard 53c710 chip of some > > SNI RM machines. > > Nice, this looks really clean. I hav

Re: [PATCH 10/12] scsi: remove the mvme147 driver

2018-03-16 Thread Thomas Bogendoerfer
On Wed, 14 Mar 2018 11:58:25 -0400 "Martin K. Petersen" wrote: > I'm happy to keep things in the tree if they are: > > 1) maintained and tested > 2) actively used > 3) not blocking removal of legacy interfaces I own a MVME147, so if needed I could get it out of the closet and

[PATCH] scsi: qedf: Limit number of CQs

2017-07-13 Thread Thomas Bogendoerfer
From: Thomas Bogendoerfer FCOE offloading on qedf devices fails with: [qed_sp_fcoe_func_start:150(sp-0-3b:00.02)]Cannot satisfy CQ amount. CQs requested 8, CQs available 6. Aborting function start [qed_fcoe_start:821()]Failed to start fcoe [__qedf_probe:3041]:6: Cannot start

[PATCH v2] scsi: qedf: Limit number of CQs

2017-07-25 Thread Thomas Bogendoerfer
From: Thomas Bogendoerfer FCOE offloading failed with: [qed_sp_fcoe_func_start:150(sp-0-3b:00.02)]Cannot satisfy CQ amount. CQs requested 8, CQs available 6. Aborting function start [qed_fcoe_start:821()]Failed to start fcoe [__qedf_probe:3041]:6: Cannot start FCoE function

[PATCH] scsi: qla1280: set 64bit coherent mask

2019-01-09 Thread Thomas Bogendoerfer
ith error -12 Reason is that SGI IP27 always generates 64bit DMA addresses and has no fallback mode for 32bit DMA addresses implemented. QLA1280 supports 64bit addressing for all DMA accesses so setting coherent mask to 64bit fixes the issue. Signed-off-by: Thomas Bogendoerfer --- drivers/scsi/