On Tuesday 13 September 2016 02:48 PM, Vaishali Thakkar wrote:
> Hi,
>
> In the file drivers/scsi/advansys.c we are calling function AdvISR at 2
> instances
> [in the function advansys_reset and advansys_interrupt] while holding
> spinlock.
> Function AdvISR eventually c
ff-by: Vaishali Thakkar
---
Please note that the patch is compile-tested only. And this change
may require driver testing.
---
drivers/scsi/wd719x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index e3da1a2..b8e57f3 100644
Hi,
In the file drivers/scsi/advansys.c we are calling function AdvISR at 2
instances
[in the function advansys_reset and advansys_interrupt] while holding spinlock.
Function AdvISR eventually calls request_firmware following this sequence of
routines:
AdvISR -> adv_async_callback -> AdvResetCh
Hello,
I was wondering about the call to schedule in function qla4_82xx_crb_win_lock
for driver
drivers/scsi/qla4xxx/ql4_nx.c. It is called in 2 functions [qla4_82xx_rd_32 and
qla4_82xx_wr_32] while holding a write_lock_irqsave. Normally we avoid using
sleeping
functions while holding a lock.
I
When sizeof is applied to a pointer typed expression, it gives
the size of the pointer. So, here do not use sizeof on pointer
type.
Problem found using Coccinelle.
Fixes: a3667aaed569 ('[SCSI] csiostor: Chelsio FCoE offload driver')
Signed-off-by: Vaishali Thakkar
---
drivers/scs
On Fri, Jul 17, 2015 at 11:16 AM, Vaishali Thakkar
wrote:
> Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
> struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely.
>
> The Coccinelle semantic patch tha
On Thu, Oct 22, 2015 at 3:53 AM, Muhammad Falak R Wani
wrote:
> Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely, as this macro
> is deprecated.
Duplicate of :https://lkml.org/lkml/2015/7/17/62
> Signed-off-by: Muhammad Falak R W
Ping!
On Fri, Jul 17, 2015 at 11:16 AM, Vaishali Thakkar
wrote:
> Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
> struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely.
>
> The Coccinelle semantic patch tha
completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_htons(x)
+ htons(x)
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc
completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_htons(x)
+ htons(x)
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/fcoe/fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers
DEFINE_PCI_DEVICE_TABLE;
initializer i;
@@
- DEFINE_PCI_DEVICE_TABLE(a)
+ const struct pci_device_id a[]
= i;
Signed-off-by: Vaishali Thakkar
---
This patch is against linux-next branch
---
drivers/scsi/wd719x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/wd719x.c b/drivers
arer name module_platform_driver;
@@
-module_exit(e);
+module_platform_driver(x);
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/jazz_esp.c | 14 +-
drivers/scsi/mac_esp.c| 14 +-
drivers/scsi/qlogicpti.c | 14 +-
drivers/scsi/sni_53c710.c | 14 +-
le_pci_driver;
@@
-module_exit(e);
+module_pci_driver(x);
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/a100u2w.c | 14 +-
drivers/scsi/am53c974.c | 14 +-
drivers/scsi/dc395x.c | 25 +
drivers/scsi/dmx3191d.c | 14 +-
drivers/scsi/hpsa.c
pcmcia_driver;
@@
-module_exit(e);
+module_pcmcia_driver(x);
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/pcmcia/aha152x_stub.c | 14 +-
drivers/scsi/pcmcia/fdomain_stub.c | 14 +-
drivers/scsi/pcmcia/nsp_cs.c | 15 +--
drivers/scsi/pcmcia/nsp_cs
\),ETH_ALEN);
+eth_broadcast_addr(e);
//
Signed-off-by: Vaishali Thakkar
---
Change since v1:
- Fix mistake in commit log
---
drivers/scsi/fnic/fnic_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index
);
+eth_broadcast_addr(e);
//
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/fnic/fnic_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 155b286..650d448 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b
definition of
__constant_cpu_to_le16 completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_cpu_to_le16(x)
+ cpu_to_le16(x)
Signed-off-by: Vaishali Thakkar
---
Changes since v1:
- Make subject more concise
---
drivers/scsi/qla4xxx
definition of
__constant_cpu_to_le16 completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_cpu_to_le16(x)
+ cpu_to_le16(x)
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/qla4xxx/ql4_nx.c | 6 +++---
1 file changed, 3 insertions(+), 3
This patch introduces the use of function setup_timer.
This is done using Coccinelle and semantic patch used is
as follows:
@@
expression x,y,z;
@@
- init_timer (&x);
+ setup_timer (&x, y, z);
- x.function = y;
- x.data = z;
Signed-off-by: Vaishali Thakkar
---
drivers/scsi/lpfc/lpf
19 matches
Mail list logo