RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-08 Thread Xiangliang Yu
Hi, Dan Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more detailed notes about the approach and any caveats would be appreciated. Signed-off-by: Xiangliang Yu

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
Hi, Dan James How about the patches about support for PM? Two months had passed since I submitted the patches. Thanks! -Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: 2014年6月4日 0:05 To: Xiangliang Yu Cc: t...@kernel.org; jbottom...@parallels.com

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
Hi, Dan I haven't receive your review comments, could you send it to me again, thanks! PS: I can't login my gmail, so please send mail to this count. -Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: 2014年8月7日 1:22 To: Xiangliang Yu Cc: jbottom

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Xiangliang Yu
Hi, How about the patch? From: Xiangliang Yu yxlr...@gmail.com Date: 2014-04-24 21:27 GMT+08:00 Subject: [PATCH 1/3] libsas: modify SATA error handler To: t...@kernel.org, jbottom...@parallels.com Cc: dan.j.willi...@intel.com, todd.e.bra...@intel.com, lukasz.do...@intel.com, linux

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Hi, Jan I think below change may be better: { PCI_VDEVICE(MARVELL_EXT, 0x9485), chip_9485 }, Add support for the AOC-SAS2LP-MV8 SAS-2 controller from SuperMicro. This controller has subdevice id 0x9485 instead of 0x9480, and apparently this simple patch is the only thing needed to make it

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Ben Hutchings already submitted a patch for this twice, which I cc'd you on: http://marc.info/?t=13927720393 will you ack it? PCI_VDEVICE() is a sort of take it or leave it macro. It's not important and it will look untidy and a bit confusing having a mix of open coding and macros,

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Ben Hutchings already submitted a patch for this twice, which I cc'd you on: http://marc.info/?t=13927720393 will you ack it? I can't find this mail in my mail box. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

[PATCH 1/3] libsas: modify SATA error handler

2014-04-24 Thread Xiangliang Yu
Add support for SATA port softreset and port multiplier error handling. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/scsi/libsas/sas_ata.c | 226 - include/scsi/libsas.h |6 + 2 files changed, 231 insertions(+), 1 deletions

[PATCH 2/3] libsas: add support for SATA port multiplier(PM)

2014-04-24 Thread Xiangliang Yu
Add support for SATA PM so that host can find devices that is attached to PM, and add PM hotplug event support. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/ata/libata-scsi.c | 48 - drivers/scsi/libsas/sas_ata.c | 358

[PATCH 3/3] mvsas: implement port mulitplier functional interface

2014-04-24 Thread Xiangliang Yu
Implement PM interface of libsas to prepare for SATA PM support. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/scsi/mvsas/mv_64xx.c |2 + drivers/scsi/mvsas/mv_94xx.c | 19 drivers/scsi/mvsas/mv_defs.h |1 + drivers/scsi/mvsas/mv_init.c |7 ++ drivers/scsi/mvsas

[PATCH 0/3] libsas: add support for port multiplier

2014-04-24 Thread Xiangliang Yu
This patch set will support SATA port multiplier(PM) in LIBSAS. LIBSAS is need to implement several key handling to support SATA PM: First,low level driver notify libsas that SATA PM is attached to HBA port. Then, LIBSAS will need to schedule SATA PMP error handler to scan SATA device that is

Please help me to review the patch about supporting SATA PM in LIBSAS

2014-04-16 Thread xiangliang yu
hi, The patch is support SATA PM device and can find all devices that is attached to PM. Until now, i have tested the identified, hot-plug and IO function and result is ok except one mvsas timeout issue. i'll continue to debug mvsas issue, but i don't know whether the libsas code of the patch is

RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-15 Thread Xiangliang Yu
Hi, Xi About patch 3, I check the ffz code and found it will check ~0 conditions. Can you point me to the ~0 check in ffz code? I also feel like using __ffs64 makes the code simpler. Yes, it seem to be ok Does patch 1 look good to you? Thanks. Yes Thanks! -- To unsubscribe from

RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-08 Thread Xiangliang Yu
On 11/6/12 7:06 AM, James Bottomley wrote: Why is this necessary? As I read the reg set assignment code, it finds a free bit in the 64 bit register and uses that ... which can never be greater than 64 so there's no need for the check. This patch just tries to be more defensive for

RE: [PATCH] scsi/mvsas: Fix oops when ata command timeout.

2012-08-01 Thread Xiangliang Yu
Hi, Jianpeng I think MVSAS shouldn't care the completion sign here, just modify task state is ok. -Original Message- From: majianpeng [mailto:majianp...@gmail.com] Sent: 2012年8月1日 15:15 To: JBottomley Cc: Xiangliang Yu; linux-scsi Subject: [PATCH] scsi/mvsas: Fix oops when ata