Re: [PATCH v5 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-15 Thread cang
Hi Martin, On 2018-10-16 10:56, Martin K. Petersen wrote: Can, Per Qcom's UFS host controller HW design, the UFS Tx lane1 clock could be muxed with Tx lane0 clock, hence keep Tx lane1 clock optional by ignoring it if it is not provided in device tree. This change also performs some cleanup to

Re: [PATCH v3 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-12 Thread cang
On 2018-10-13 00:55, Doug Anderson wrote: Hi, On Thu, Oct 11, 2018 at 6:12 PM Can Guo wrote: + if (err != -EPROBE_DEFER) + dev_err(dev, "failed to get %s err %d", + name, err); I wouldn't spin just for this, but if you spin for some other rea

Re: [PATCH v3 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-11 Thread cang
Hi, On 2018-10-12 14:10, Vivek Gautam wrote: On 10/12/2018 6:42 AM, Can Guo wrote: From: Venkat Gopalakrishnan Per Qcom's UFS host controller HW design, the UFS Tx lane1 clock could be muxed with Tx lane0 clock, hence keep Tx lane1 clock optional by ignoring it if it is not provided in devi

Re: [PATCH v2 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-11 Thread cang
Hi Doug, On 2018-10-12 04:21, Doug Anderson wrote: Hi, On Thu, Oct 11, 2018 at 5:33 AM Can Guo wrote: static int ufs_qcom_host_clk_get(struct device *dev, - const char *name, struct clk **clk_out) + const char *name, struct clk **clk_out, bool optional) {

Re: [PATCH 1/1] scsi: ufs: make UFS Tx lane1 clock optional

2018-10-10 Thread cang
Hi Doug, Really thank you for your review. On 2018-10-10 05:56, Doug Anderson wrote: Hi, On Sun, Oct 7, 2018 at 9:34 PM Can Guo wrote: From: Venkat Gopalakrishnan The UFS Tx lane1 clock could be muxed, hence keep it optional by ignoring it if it is not provided in device tree. Thanks

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-10-08 Thread cang
Hi Evan, On 2018-10-04 02:34, Evan Green wrote: Hi, On Wed, Oct 3, 2018 at 11:19 AM Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. I'm reviving this old chestnut, sorry I missed it initia

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-10-08 Thread cang
On 2018-10-04 02:34, Evan Green wrote: Hi, On Wed, Oct 3, 2018 at 11:19 AM Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. I'm reviving this old chestnut, sorry I missed it initially. This

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-04-11 Thread cang
On 2018-04-02 18:00, Vivek Gautam wrote: Hi Can, On 3/2/2018 1:48 PM, Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani Si

Re: [PATCH] scsi: ufs-qcom: add number of lanes per direction

2018-02-26 Thread cang
On 2018-02-09 10:29, Rob Herring wrote: On Mon, Feb 05, 2018 at 08:02:07PM +0800, Can Guo wrote: From: Gilad Broner Different platforms may have different number of lanes for the UFS link. Add parameter to device tree specifying how many lanes should be configured for the UFS link. And don't