On Mon, Sep 23, 2013 at 5:44 PM, vinayak holikatti
wrote:
> On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma
> wrote:
>>
>> Fix many warnings with incorrect endian assumptions
>> which makes the code unportable to new architectures.
>>
>> The UFS specifi
> This adjusts dma pad mask and max segment size to the above-mentioned
> PRDT limitations.
>
> Signed-off-by: Akinobu Mita
> Cc: Subhash Jadavani
> Cc: Vinayak Holikatti
> Cc: Santosh Y
> Cc: "James E.J. Bottomley"
> Cc: linux-scsi@vger.kernel.org
> ---
&
itqueue_head(&hba->tm_tag_wq);
>
> /* Initialize work queues */
> - INIT_WORK(&hba->feh_workq, ufshcd_fatal_err_handler);
> + INIT_WORK(&hba->eh_work, ufshcd_err_handler);
> INIT_WORK(&hba->eeh_work, ufshcd_exception_event_handler);
>
> /* Initialize UIC command mutex */
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 48c7d9b..acf318e 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -183,9 +183,12 @@ struct ufs_dev_cmd {
> * @eh_flags: Error handling flags
> * @intr_mask: Interrupt Mask Bits
> * @ee_ctrl_mask: Exception event control mask
> - * @feh_workq: Work queue for fatal controller error handling
> + * @eh_work: Worker to handle UFS errors that require s/w attention
> * @eeh_work: Worker to handle exception events
> * @errors: HBA errors
> + * @uic_error: UFS interconnect layer error status
> + * @saved_err: sticky error mask
> + * @saved_uic_err: sticky UIC error mask
> * @dev_cmd: ufs device management command information
> * @auto_bkops_enabled: to track whether bkops is enabled in device
> */
> @@ -233,11 +236,14 @@ struct ufs_hba {
> u16 ee_ctrl_mask;
>
> /* Work Queues */
> - struct work_struct feh_workq;
> + struct work_struct eh_work;
> struct work_struct eeh_work;
>
> /* HBA Errors */
> u32 errors;
> + u32 uic_error;
> + u32 saved_err;
> + u32 saved_uic_err;
>
> /* Device management request data */
> struct ufs_dev_cmd dev_cmd;
Acked-by: Vinayak Holikatti
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
+ hba->ufshcd_state = UFSHCD_STATE_OPERATIONAL;
> +
> + /* If we are in error handling context no need to scan the host */
> + if (!ufshcd_eh_in_progress(hba)) {
> + scsi_scan_host(hba->host);
> + pm_runtime_put_sync(hba->dev);
&g
ze wait queue for task management */
> - init_waitqueue_head(&hba->ufshcd_tm_wait_queue);
> + init_waitqueue_head(&hba->tm_wq);
> + init_waitqueue_head(&hba->tm_tag_wq);
>
> /* Initialize work queues */
> INIT_WORK(&hba->feh_workq, ufshcd_fatal_err_handler);
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 767ee9e..84d09d1 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -174,7 +174,9 @@ struct ufs_dev_cmd {
> * @irq: Irq number of the controller
> * @active_uic_cmd: handle of active UIC command
> * @uic_cmd_mutex: mutex for uic command
> - * @ufshcd_tm_wait_queue: wait queue for task management
> + * @tm_wq: wait queue for task management
> + * @tm_tag_wq: wait queue for free task management slots
> + * @tm_slots_in_use: bit map of task management request slots in use
> * @pwr_done: completion for power mode change
> * @tm_condition: condition variable for task management
> * @ufshcd_state: UFSHCD states
> @@ -217,8 +219,10 @@ struct ufs_hba {
> struct uic_command *active_uic_cmd;
> struct mutex uic_cmd_mutex;
>
> - wait_queue_head_t ufshcd_tm_wait_queue;
> + wait_queue_head_t tm_wq;
> + wait_queue_head_t tm_tag_wq;
> unsigned long tm_condition;
> + unsigned long tm_slots_in_use;
>
> struct completion *pwr_done;
>
Acked-by: Vinayak Holikatti
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ng_reqs);
> hba->lrb[tag].cmd = NULL;
> spin_unlock_irqrestore(host->host_lock, flags);
> @@ -2745,6 +2778,13 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> clear_bit_unlock(tag, &hba->lrb_in_use);
> wake_up(&hba->dev_cmd.tag_wq);
> out:
> + if (!err) {
> + err = SUCCESS;
> + } else {
> + dev_err(hba->dev, "%s: failed with err %d\n", __func__, err);
> + err = FAILED;
> + }
> +
> return err;
> }
>
Acked-by: Vinayak Holikatti
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
_hba *hba);
> extern int ufshcd_runtime_suspend(struct ufs_hba *hba);
> extern int ufshcd_runtime_resume(struct ufs_hba *hba);
> extern int ufshcd_runtime_idle(struct ufs_hba *hba);
>
Acked-by: Vinayak Holikatti
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
32 dword_2;
> + __le32 dword_3;
> };
>
> /**
> @@ -352,16 +352,16 @@ struct utp_transfer_req_desc {
> struct request_desc_header header;
>
> /* DW 4-5*/
> - u32 command_desc_base_addr_lo;
> - u32 command_desc_base_addr_hi;
> +
ann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Maya Erez
Signed-off-by: Santosh Yaraganavi
Signed-off-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Reviewed-by: Sujit Reddy Thumma
Tested-by: Maya Erez
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig
James,
I have rebased these patches with top scsi-misc tree.
On Mon, Feb 25, 2013 at 9:44 PM, Vinayak Holikatti
wrote:
> This patch set adds following features
> - Seggregate PCI specific code in ufshcd.c and corrected copyright
> - Adds PCI glue driver ufshcd-pci.c and ufshcd.c be
ann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Maya Erez
Signed-off-by: Santosh Yaraganavi
Signed-off-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Reviewed-by: Sujit Reddy Thumma
Tested-by: Maya Erez
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig
This patch separates PCI code from ufshcd.c and makes it as a
core driver module and adds a new file ufshcd-pci.c as PCI glue
driver.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Maya Erez
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh
: Maya Erez
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 50 +++
drivers/scsi/ufs/ufs.h| 44 +++
drivers/scsi/ufs/ufshcd.c | 348 +++-
drivers/scsi/ufs/ufshci.h | 44 +++
4 files
This patch set adds following features
- Seggregate PCI specific code in ufshcd.c and corrected copyright
- Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module
- Adds Platform glue driver ufshcd-pltfrm.c
- Update correct transfer size in Command UPIU
Vinayak Holikatti (4
On Sun, Feb 24, 2013 at 2:53 PM, James Bottomley
wrote:
> On Tue, 2013-02-05 at 22:17 +0530, vinholika...@gmail.com wrote:
>> From: Vinayak Holikatti
>>
>> This patch seggregates the PCI specific code in ufshcd.c to make it
>> ready for splitting into core ufs drive
Hi James,
look like these patches are fine. Can you please integrate these
patches in your tree.
On Tue, Feb 5, 2013 at 10:17 PM, wrote:
> From: Vinayak Holikatti
>
> This patch set adds following features
> - Seggregate PCI specific code in ufshcd.c and corrected copyright
&
On Fri, Jan 11, 2013 at 6:00 PM, Subhash Jadavani
wrote:
> On 1/11/2013 4:11 PM, Sujit Reddy Thumma wrote:
>>
>> On 1/9/2013 5:41 PM, vinayak holikatti wrote:
>>>
>>> On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma
>>> wrote:
>>>>
;>> + dev_err(&pdev->dev, "ufshcd: Memory resource not
>>>>> available\n");
>>>>> + else {
>>>>> + mem_size = resource_size(mem_res);
>>>>> + release_mem_region(mem_res->start, mem_size);
>>>>> + }
>>>>> + platform_set_drvdata(pdev, NULL);
>>>>> + return 0;
>>>>> +}
>>>>> +
>>>>> +static const struct of_device_id ufs_of_match[] = {
>>>>> + { .compatible = "jedec,ufs-1.1"},
>>>>> +};
>>>>> +
>>>>> +static struct platform_driver ufshcd_pltfrm_driver = {
>>>>> + .probe = ufshcd_pltfrm_probe,
>>>>> + .remove = __devexit_p(ufshcd_pltfrm_remove),
>>>>> +#ifdef CONFIG_PM
>
>
> CONFIG_PM_SLEEP would be better?
the current implementation looks fine.
>Also, can you move legacy suspend/resume
Ok,
> callbacks below to dev_pm_ops?
>
>>>>> + .suspend = ufshcd_pltfrm_suspend,
>>>>> + .resume = ufshcd_pltfrm_resume,
>>>>> +#endif
>>>>> + .driver = {
>>>>> + .name = "ufshcd",
>>>>> + .owner = THIS_MODULE,
>>>>> + .of_match_table = ufs_of_match,
>>>>> + },
>>>>> +};
>
>
> --
> Regards,
> Sujit Reddy Thumma
>
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation.
--
Regards,
Vinayak Holikatti
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 27, 2012 at 8:28 PM, Subhash Jadavani
wrote:
> On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
>>
>> From: Vinayak Holikatti
>>
>> This patch adds Platform glue driver for ufshcd.
>>
>> Reviewed-by: Arnd Bergmann
>> Reviewed-by: Nam
On Thu, Dec 27, 2012 at 7:59 PM, Subhash Jadavani
wrote:
>
> Few comments inline:
>
> On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote:
>>
>> From: Vinayak Holikatti
>>
>> This patch seggregates the PCI specific code in ufshcd.c to make it
>> ready
> drivers/scsi/ufs/ufshcd.c | 2 +-
Acked-by: Vinayak Holikatti
only for drivers/scsi/ufs/ufshcd.c
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 4a370f8..a79ff87 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/sc
> drivers/scsi/ufs/ufshcd.c | 2 +-
Acked-by: Vinayak Holikatti
only for drivers/scsi/ufs/ufshcd.c
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 58f4ba6..4a370f8 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/sc
On Wed, Nov 21, 2012 at 4:26 PM, James Bottomley
wrote:
> On Wed, 2012-11-21 at 16:02 +0530, vinayak holikatti wrote:
>> On Wed, Nov 14, 2012 at 2:56 AM, James Bottomley
>> wrote:
>> > On Thu, 2012-10-18 at 17:37 +0530, vinayak holikatti wrote:
>> >> I am
On Wed, Nov 14, 2012 at 2:56 AM, James Bottomley
wrote:
> On Thu, 2012-10-18 at 17:37 +0530, vinayak holikatti wrote:
>> I am Vacation will look into it when i am back to work.
>> > This doesn't apply on 3.7-rc1. Am I missing any patches in between ?
>
> OK, so i
On Thu, Oct 18, 2012 at 12:13 PM, Venkatraman S wrote:
> On Wednesday 17 October 2012 05:23 PM, Vinayak Holikatti wrote:
>>
>> This patch seggregates the PCI specific code in ufshcd.c to make it
>> ready for splitting into core ufs driver and PCI glue driver. Also
>> co
ann
Reviewed-by: Namjae Jeon
Signed-off-by: Santosh Yaraganavi
Signed-off-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 5d7bd47..57c16ec 100644
--- a/drivers/s
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 11 ++
drivers/scsi/ufs/Makefile|1 +
drivers/scsi/ufs/ufshcd-pltfrm.c
This patch separates PCI code from ufshcd.c and makes it as a
core driver module and adds a new file ufshcd-pci.c as PCI glue
driver.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig
This patch seggregates the PCI specific code in ufshcd.c to make it
ready for splitting into core ufs driver and PCI glue driver. Also
copyright header modification to remove extra warranty disclaim.
Reviewed-by: Arnd Bergmann
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed
This patch set adds following features
- Seggregate PCI specific code in ufshcd.c and corrected copyright
- Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module
- Adds Platform glue driver ufshcd-pltfrm.c
- Update correct transfer size in Command UPIU
Vinayak Holikatti (4
On Wed, Aug 1, 2012 at 8:08 PM, Arnd Bergmann wrote:
> On Thursday 26 July 2012, Vinayak Holikatti wrote:
>
>> -static void ufshcd_remove(struct pci_dev *pdev)
>> +void ufshcd_remove(struct ufs_hba *hba)
>> {
>> - struct ufs_hba *hba = pci_get_drvdata(p
On Thu, Jul 26, 2012 at 5:05 PM, S, Venkatraman wrote:
> On Thu, Jul 26, 2012 at 4:42 PM, vinayak holikatti
> wrote:
>> On Thu, Jul 26, 2012 at 4:02 PM, S, Venkatraman wrote:
>>> On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti
>>> wrote:
>>>&
On Thu, Jul 26, 2012 at 4:02 PM, S, Venkatraman wrote:
> On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti
> wrote:
>> This patch set adds following features
>> - Seggregate PCI specific code in ufshcd.c
>> - Adds PCI glue driver ufshcd-pci.c and ufshcd.c becom
ned-off-by: Santosh Yaraganavi
Signed-off-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dfc3e85..5e732c3 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/s
This patch adds Platform glue driver for ufshcd.
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 11 ++
drivers/scsi/ufs/Makefile|1 +
drivers/scsi/ufs/ufshcd-pltfrm.c | 222
This patch separates PCI code from ufshcd.c and makes it as a
core driver module and adds a new file ufshcd-pci.c as PCI glue
driver.
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 26 ++-
drivers/scsi/ufs
This patch seggregates the PCI specific code in ufshcd.c to make it
ready for splitting into core ufs driver and PCI glue driver.
Reviewed-by: Namjae Jeon
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/ufshcd.c | 277
This patch set adds following features
- Seggregate PCI specific code in ufshcd.c
- Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module
- Adds Platform glue driver ufshcd-pltfrm.c
- Update correct transfer size in Command UPIU
Vinayak Holikatti (4):
[SCSI] drivers/scsi/ufs
On Mon, Jul 16, 2012 at 9:52 PM, Arnd Bergmann wrote:
> On Monday 16 July 2012, James Bottomley wrote:
>> On Fri, 2012-07-13 at 15:45 +, Arnd Bergmann wrote:
>> > On Friday 13 July 2012, Vinayak Holikatti wrote:
>> > > This patch set adds following features
&
On Mon, Jul 16, 2012 at 7:19 PM, Namjae Jeon wrote:
> Hi Vinayak.
>> + * ufshcd_pltfrm_remove - remove platform driver routine
>> + * @pdev: pointer to platform device handle
>> + *
>> + * Returns 0 on success, non-zero value on failure
>> + */
>> +static int __devexit ufshcd_pltfrm_remove(struct
This patch corrects the expected data transfer size of the
command UPIU. The current implementation of cmd->transfersize
is wrong as it probably equal to sector size. With this
implementation the transfer size is updated correctly
Signed-off-by: Vinayak Holikatti
Signed-off-by: Sant
This patch adds Platform glue driver for ufshcd.
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 11 ++
drivers/scsi/ufs/Makefile|1 +
drivers/scsi/ufs/ufshcd-pltfrm.c | 215 ++
3 files
This patch adds PCI glue driver support
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 11 ++
drivers/scsi/ufs/Makefile|1 +
drivers/scsi/ufs/ufshcd-pci.c| 227 ++
drivers/scsi/ufs
This patch removes the PCI specific code to make it into
core ufs driver. This separation allows room for other
bus specific glue drivers to be added in future
Signed-off-by: Vinayak Holikatti
Signed-off-by: Santosh Yaraganavi
---
drivers/scsi/ufs/Kconfig | 15 ++-
drivers/scsi/ufs/ufshcd.c
This patch set adds following features
- Seprates PCI specific code from ufshcd.c to make it as core
- Adds PCI glue driver ufshcd-pci.c
- Adds Platform glue driver ufshcd-pltfrm.c
- Update correct transfer size in Command UPIU
Vinayak Holikatti (4):
[SCSI] drivers/scsi/ufs: Remove PCI
On Mon, Jul 2, 2012 at 8:50 PM, Arnd Bergmann wrote:
> On Monday 02 July 2012, Vinayak Holikatti wrote:
>> +static struct amba_id ufshcd_amba_ids[] = {
>> + {
>> + /* Fake id for Primecell.*/
>> + .id = 0x00041FF0,
>> +
On Mon, Jul 2, 2012 at 8:57 PM, Arnd Bergmann wrote:
> On Monday 02 July 2012, Vinayak Holikatti wrote:
>> +static struct platform_driver ufshcd_pltfrm_driver = {
>> + .probe = ufshcd_pltfrm_probe,
>> + .remove = __devexit_p(ufshcd_pltfrm_remove),
On Mon, Jul 2, 2012 at 8:47 PM, Arnd Bergmann wrote:
> On Monday 02 July 2012, Vinayak Holikatti wrote:
>>
>> This patch separates PCI and core UFS host controller driver.
>> In the current implementation PCI specific code is with ufshcd.c.
>> To provide way for addi
50 matches
Mail list logo
