Re: [PATCH v7 0/5] scsi: ufs: add ufs driver code for Hisilicon Hi3660 SoC

2018-01-07 Thread zhangfei
Hi, Wei On 2018年01月06日 17:51, Li Wei wrote: This patchset adds driver support for UFS for Hi3660 SoC. It is verified on HiKey960 board. Usually here should list the change compared with the last change set, to make it easier to reviewer, who may pay more attention to the differences. For ex

Re: [PATCH 3/3] scsi: hisi_sas: lock sensitive region in hisi_sas_slot_abort()

2017-01-03 Thread zhangfei
On 2017年01月03日 20:24, John Garry wrote: When we call hisi_sas_slot_task_free() we should grab the hisi_hba.lock, as hisi_sas_slot_task_free() accesses common hisi_hba elements. Function hisi_sas_slot_abort() is missing this, so add it. Signed-off-by: John Garry Reviewed-by: Zhangfei Gao

Re: [PATCH 2/3] scsi: hisi_sas: lock sensitive regions when servicing CQ interrupt

2017-01-03 Thread zhangfei
), bitmap of currently allocated IPTT (in hisi_hba.slot_index_tags), and completion queue read pointer. As a solution, lock these elements with the hisi_hba.lock. Signed-off-by: John Garry Reviewed-by: Xiang Chen Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 1/3] scsi: hisi_sas: service v2 hw CQ ISR with tasklet

2017-01-03 Thread zhangfei
processing to tasklet context. Each CQ will have its down tasklet. Signed-off-by: John Garry Reviewed-by: Xiang Chen Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH] scsi: hisi_sas: support deferred probe for v2 hw

2016-12-06 Thread zhangfei
Reviewed-by: Zhangfei Gao Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: UFS_MASK macro definition

2016-11-23 Thread Zhangfei Gao
On Thu, Nov 24, 2016 at 12:21 PM, Subhash Jadavani wrote: > On 2016-11-23 19:23, Zhangfei Gao wrote: >> >> Hi, Vinayak >> >> Checked 4.9-rc6, and not find UFS_MASK macro definition. >> Have find this patch from google, >> >> http://www.spinics.net

[PATCH] ufs: Add missing UFS_MASK macro definition

2016-11-23 Thread Zhangfei Gao
From: Santosh Y Reported-by: Venkatraman S Reviewed-by: Vinayak Holikatti Signed-off-by: Santosh Y Signed-off-by: Zhangfei Gao --- Find the original patch from http://www.spinics.net/lists/linux-scsi/msg58634.html drivers/scsi/ufs/ufshci.h | 2 ++ 1 file changed, 2 insertions(+) diff

UFS_MASK macro definition

2016-11-23 Thread Zhangfei Gao
Hi, Vinayak Checked 4.9-rc6, and not find UFS_MASK macro definition. Have find this patch from google, http://www.spinics.net/lists/linux-scsi/msg58634.html [PATCH 2/2] [SCSI] ufs: Add missing UFS_MASK macro definition Is this patch has been merged? There will be build error if some definition

Re: [PATCH 01/11] hisi_sas: add v2 hw support for ECC and AXI bus fatal error

2016-11-23 Thread Zhangfei Gao
On Wed, Nov 23, 2016 at 4:59 PM, John Garry wrote: > On 16/11/2016 01:47, Zhangfei Gao wrote: >> >> On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: >>> >>> From: Xiang Chen Reviewed-by: Zhangfei Gao >>> >>> For ECC 1bit error, logic can

Re: [PATCH 05/11] hisi_sas: replace WARN_ON() with dev_warn() for internal abort

2016-11-23 Thread Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Replace WARN_ON() with dev_warn() print when internal abort fails. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao Sorry, miss this one. -- To unsubscribe from t

Re: [PATCH 06/11] hisi_sas: modify return value of hisi_sas_query_task()

2016-11-15 Thread Zhangfei Gao
ed-off-by: Xiang Chen > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/11] hisi_sas: check SATA FIS when directly attaching SATA device

2016-11-15 Thread Zhangfei Gao
igned-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/11] hisi_sas: add PHY set linkrate support for v1 and v2 hw

2016-11-15 Thread Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Add the function to set PHY min and max linkrate through > sysfs interface. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from thi

Re: [PATCH 03/11] hisi_sas: only process broadcast change in phy_bcast_v2_hw()

2016-11-15 Thread Zhangfei Gao
y: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/11] hisi_sas: add v2 hw support for ECC and AXI bus fatal error

2016-11-15 Thread Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > For ECC 1bit error, logic can recover it, so we only print > a warning. > For ECC multi-bit and AXI bus fatal error, we panic. Is it possible to recover via resetting phy and device etc instead of panic? Thanks -- To unsub

Re: [PATCH 08/11] hisi_sas: modify some values in get_ata_protocol()

2016-11-15 Thread Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Modify and add some SATA commands according to SATA protocol. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "

Re: [PATCH 10/11] hisi_sas: use atomic64_t for hisi_sas_device.running_req

2016-11-15 Thread Zhangfei Gao
he value for running_req may be actually incorrect, > so use atomic64_t instead. > > Signed-off-by: John Garry > Reviewed-by: Xiang Chen Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [PATCH 07/11] hisi_sas: delete repeated configuration in free_device_v2_hw()

2016-11-15 Thread Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Delete repeated configuration items for hisi_sas_device() when > we free a device. These items are now only set in > hisi_sas_dev_gone(). > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry

Re: [PATCH 04/11] hisi_sas: fix port form bug in hisi_sas_port_notify_formed()

2016-11-15 Thread Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > When we form a wideport, we should use hardware PHY port_id instead > of sas_phy->id. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from

Re: [PATCH 02/11] hisi_sas: alloc queue id of slot according to device id

2016-11-15 Thread Zhangfei Gao
ame for consistency. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8] hisi_sas: add internal abort core code

2016-08-20 Thread zhangfei
On 2016年08月10日 21:19, John Garry wrote: Add core code for internal abort functionality. The internal abort features allows the host controller to abort commands which are still active in the controller but have not yet been sent to the slave device. Typically a command only spends a relativel

Re: how to test pscsi with vhost

2016-07-07 Thread Zhangfei Gao
Hi, Lingshan On Mon, Jul 4, 2016 at 10:02 PM, Zhu Lingshan wrote: > Hi Zhangfei, > > I am also interested in pscsi, you can try kvm, seems you can create a > virtualized pscsi device in kvm / virt-manager. I haven't tried that yet, > hope this can help. > Somehow I faile

how to test pscsi with vhost

2016-07-04 Thread Zhangfei Gao
I am testing with pscsi, but fail to find any block device under /dev to mount. The scsi_probe_lun seems can not return correctly, scsi scan: INQUIRY failes. Is this usage correct? /backstores/pscsi> create name=pscsi_backend dev=/dev/sdb Note: block backstore recommended for SCSI block devices C

Re: [PATCH 1/3] hisi_sas: add v2 hw ACPI support

2016-06-05 Thread zhangfei
: Zhangfei Gao Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hisi_sas: fix the inconsistent lock issue reported by CONFIG_PROVE_LOCKING

2016-06-05 Thread zhangfei
[] sas_discover_domain+0x4bc/0x564 [] process_one_work+0x1a0/0x3cc [] worker_thread+0x138/0x438 [] kthread+0xdc/0xf0 [] ret_from_fork+0x10/0x40 Signed-off-by: Wei Xu Signed-off-by: John Garry Reviewed-by: Zhangfei Gao -- To unsubscribe from this list: se

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

2016-04-13 Thread Zhangfei Gao
isi_sas: for v2 hw only set ITCT qw2 for SAS device > hisi_sas: update driver version to 1.4 For the series, Reviewed-by: Zhangfei Gao Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread zhangfei
On 10/27/2015 10:39 PM, Mark Rutland wrote: On Tue, Oct 27, 2015 at 01:09:15PM +, John Garry wrote: On 26/10/2015 14:45, Mark Rutland wrote: On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- ...

Re: [PATCH 02/25] devicetree: bindings: scsi: HiSi SAS

2015-10-19 Thread zhangfei
On 10/19/2015 06:48 PM, John Garry wrote: On 16/10/2015 14:47, Rob Herring wrote: + - reg : Address and length of the register sets for the device + - SAS controller registers + - SAS controller control registers + + - reset-reg : offset to reset, status, and clock registers in control

Re: [PATCH 03/25] scsi: hisi_sas: add initial bare driver

2015-10-15 Thread zhangfei
On 10/15/2015 05:23 PM, John Garry wrote: On 15/10/2015 09:49, Xinwei Kong wrote: +++ b/drivers/scsi/hisi_sas/hisi_sas.h @@ -0,0 +1,24 @@ +/* + * Copyright (c) 2015 Linaro Ltd. + * Copyright (c) 2015 Hisilicon Limited. + * + * This program is free software; you can redistribute it and/or

Re: [PATCH 09/25] scsi: hisi_sas: add phy SAS ADDR initialization

2015-10-14 Thread zhangfei
On 10/14/2015 11:18 PM, Arnd Bergmann wrote: On Wednesday 14 October 2015 16:05:21 John Garry wrote: OK, we can look at adding the ability to read the SAS HBA address from a FW image or EFI variables. The easiest way is usually to have a DT property that gets updated by the firmware. Ye

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread zhangfei
On 10/13/2015 08:20 PM, Arnd Bergmann wrote: On Tuesday 13 October 2015 17:47:02 zhangfei wrote: On 10/12/2015 11:21 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:19 John Garry wrote: +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) +{ + struct platform_device *pdev

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread zhangfei
On 10/12/2015 11:21 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:19 John Garry wrote: +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) +{ + struct platform_device *pdev = hisi_hba->pdev; + struct device *dev = &pdev->dev; + struct resource *res; + + res = pl

Re: [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools

2015-10-13 Thread zhangfei
Hi, Arnd On 10/12/2015 11:15 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:17 John Garry wrote: + interrupt_count = of_property_count_u32_elems(np, "interrupts"); + if (interrupt_count < 0) + goto err_out; + + if (of_property_read_u32(np, "#interrupt-c