Re: [2.6 patch] SCSI: cleanups

2005-03-31 Thread Adrian Bunk
On Mon, Mar 28, 2005 at 09:21:45AM -0600, James Bottomley wrote: > On Sun, 2005-03-27 at 22:21 +0200, Adrian Bunk wrote: > > This patch contains the following cleanups: > [..] > > No to all of this: > > > - remove the following unused functions: > > - scsi.h: print_driverbyte > > - scsi.h: pr

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 17:29 +0200, Arjan van de Ven wrote: > how about a CONFIG_SCSI_DRIVER_DEBUG ? In principle, that's fine ... in practice does the few bytes saved by this really justify adding yet another option? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread Arjan van de Ven
On Mon, 2005-03-28 at 09:21 -0600, James Bottomley wrote: \ > > - remove the following unused functions: > > - scsi.h: print_driverbyte > > - scsi.h: print_hostbyte > > - #if 0 the following unused functions: > > - constants.c: scsi_print_hostbyte > > - constants.c: scsi_print_driverbyte >

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread James Bottomley
On Sun, 2005-03-27 at 22:21 +0200, Adrian Bunk wrote: > This patch contains the following cleanups: [..] No to all of this: > - remove the following unused functions: > - scsi.h: print_driverbyte > - scsi.h: print_hostbyte > - #if 0 the following unused functions: > - constants.c: scsi_prin

[2.6 patch] SCSI: cleanups

2005-03-27 Thread Adrian Bunk
This patch contains the following cleanups: - make needlessly global code static - remove the following unused functions: - scsi.h: print_driverbyte - scsi.h: print_hostbyte - #if 0 the following unused functions: - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte - rem

[2.6 patch] SCSI: cleanups

2005-02-28 Thread Adrian Bunk
Updated patch: <-- snip --> This patch contains the following cleanups: - make needlessly global code static - remove the following unused functions: - scsi.h: print_driverbyte - scsi.h: print_hostbyte - #if 0 the following unused functions: - constants.c: scsi_print_hostbyte - constant