Re: [PATCH, RFC] blk-mq: use a delayed work item for timeouts

2015-10-12 Thread Jens Axboe
On 10/12/2015 02:22 PM, Christoph Hellwig wrote: On Mon, Oct 12, 2015 at 02:08:04PM -0600, Jens Axboe wrote: No that's definitely fine with me, imho most error handling callbacks should be in process context for ease of use in the driver. Took a closer look. The patch looks incomplete. The hot

Re: [PATCH, RFC] blk-mq: use a delayed work item for timeouts

2015-10-12 Thread Christoph Hellwig
On Mon, Oct 12, 2015 at 02:08:04PM -0600, Jens Axboe wrote: >> No that's definitely fine with me, imho most error handling callbacks >> should be in process context for ease of use in the driver. > > Took a closer look. The patch looks incomplete. The hot path for blk-mq is > blk_add_timer(), look

Re: [PATCH, RFC] blk-mq: use a delayed work item for timeouts

2015-10-12 Thread Jens Axboe
On 10/12/2015 01:34 PM, Jens Axboe wrote: On 10/12/2015 01:29 PM, Christoph Hellwig wrote: For some pending NVMe work I'd really love to be able to get my timeouts from process context. So far it seems only SCSI and NVMe use the blk-mq timeout handler, and both don't seem to be particularly exc

Re: [PATCH, RFC] blk-mq: use a delayed work item for timeouts

2015-10-12 Thread Jens Axboe
On 10/12/2015 01:29 PM, Christoph Hellwig wrote: For some pending NVMe work I'd really love to be able to get my timeouts from process context. So far it seems only SCSI and NVMe use the blk-mq timeout handler, and both don't seem to be particularly excited about being called from time context.

[PATCH, RFC] blk-mq: use a delayed work item for timeouts

2015-10-12 Thread Christoph Hellwig
For some pending NVMe work I'd really love to be able to get my timeouts from process context. So far it seems only SCSI and NVMe use the blk-mq timeout handler, and both don't seem to be particularly excited about being called from time context. Does anyone have an objection against the patch be