Re: [PATCH] Improve requeuing behavior

2017-08-24 Thread Bart Van Assche
On Thu, 2017-08-24 at 18:57 +0200, h...@lst.de wrote: > On Thu, Aug 24, 2017 at 04:14:22PM +, Bart Van Assche wrote: > > Commit ca18d6f769d2 ("block: Make most scsi_req_init() calls implicit") > > introduced the scsi_initialize_rq() function in such a way that it is not > > only > > called for

Re: [PATCH] Improve requeuing behavior

2017-08-24 Thread h...@lst.de
On Thu, Aug 24, 2017 at 04:14:22PM +, Bart Van Assche wrote: > Commit ca18d6f769d2 ("block: Make most scsi_req_init() calls implicit") > introduced the scsi_initialize_rq() function in such a way that it is not only > called for pass-through requests but also for FS requests. Because that commi

Re: [PATCH] Improve requeuing behavior

2017-08-24 Thread Bart Van Assche
On Thu, 2017-08-24 at 14:09 +0200, Christoph Hellwig wrote: > On Wed, Aug 23, 2017 at 02:05:35PM -0700, Bart Van Assche wrote: > > Requests are unprepared and reprepared when being requeued. Avoid > > that requeuing resets .jiffies_at_alloc and .retries by initializing > > these two member variable

Re: [PATCH] Improve requeuing behavior

2017-08-24 Thread Christoph Hellwig
On Wed, Aug 23, 2017 at 02:05:35PM -0700, Bart Van Assche wrote: > Requests are unprepared and reprepared when being requeued. Avoid > that requeuing resets .jiffies_at_alloc and .retries by initializing > these two member variables from inside blk_get_request() and by > preserving both member vari

[PATCH] Improve requeuing behavior

2017-08-23 Thread Bart Van Assche
Requests are unprepared and reprepared when being requeued. Avoid that requeuing resets .jiffies_at_alloc and .retries by initializing these two member variables from inside blk_get_request() and by preserving both member variables when preparing a request. This patch affects the requeuing behavior