Re: [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event

On Wed, Nov 1, 2017 at 8:00 PM, Tejun Heo wrote: > Hello, > > On Tue, Oct 31, 2017 at 08:52:44PM +0530, Rameshwar Sahu wrote: >> > probably should take both link and dev and use dev iff it's not NULL. >> > >> >> Instead of this would it be better to call trace_ata_eh_link_autopsy() if >> dev is no

Re: [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event

Hello, On Tue, Oct 31, 2017 at 08:52:44PM +0530, Rameshwar Sahu wrote: > > probably should take both link and dev and use dev iff it's not NULL. > > > > Instead of this would it be better to call trace_ata_eh_link_autopsy() if > dev is not NULL from ata error handler ?? Oh yeah, that'd work too

Re: [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event

Hello, On Wed, Oct 25, 2017 at 03:52:56PM +0530, Rameshwar Prasad Sahu wrote: > @@ -288,8 +289,8 @@ > ), > > TP_fast_assign( > - __entry->ata_port = dev->link->ap->print_id; > - __entry->ata_dev= dev->link->pmp + dev->devno; > + __entr

[PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event

When tracing ata link error event, the kernel crashes when the disk is removed due to NULL pointer access by trace_ata_eh_link_autopsy API. This occurs as the dev is NULL when the disk disappeared. Given that the trace routine requires only the link info, pass the link info instead of passing dev p