[PATCH] bnx2fc: Improve stats update mechanism

2014-06-23 Thread Neil Horman
Recently had this warning reported: [ 290.489047] Call Trace: [ 290.489053] [8169efec] dump_stack+0x19/0x1b [ 290.489055] [810ac7a9] __might_sleep+0x179/0x230 [ 290.489057] [816a4ad5] mutex_lock_nested+0x55/0x520 [ 290.489061] [a01b9905] ?

Re: [Open-FCoE] [PATCH] bnx2fc: Improve stats update mechanism

2014-06-03 Thread Neil Horman
On Sat, May 31, 2014 at 08:37:57AM -0400, Neil Horman wrote: On Sat, May 31, 2014 at 05:13:11AM +, Eddie Wai wrote: On May 30, 2014, at 7:48 PM, Neil Horman nhor...@tuxdriver.com wrote: On Fri, May 30, 2014 at 02:59:43PM -0700, Eddie Wai wrote: Thanks for fixing this. The

Re: [Open-FCoE] [PATCH] bnx2fc: Improve stats update mechanism

2014-06-03 Thread Eddie Wai
On Tue, 2014-06-03 at 10:54 -0400, Neil Horman wrote: On Sat, May 31, 2014 at 08:37:57AM -0400, Neil Horman wrote: On Sat, May 31, 2014 at 05:13:11AM +, Eddie Wai wrote: On May 30, 2014, at 7:48 PM, Neil Horman nhor...@tuxdriver.com wrote: On Fri, May 30, 2014 at

[PATCH] bnx2fc: Improve stats update mechanism

2014-05-30 Thread Neil Horman
Recently had this warning reported: [ 290.489047] Call Trace: [ 290.489053] [8169efec] dump_stack+0x19/0x1b [ 290.489055] [810ac7a9] __might_sleep+0x179/0x230 [ 290.489057] [816a4ad5] mutex_lock_nested+0x55/0x520 [ 290.489061] [a01b9905] ?

Re: [Open-FCoE] [PATCH] bnx2fc: Improve stats update mechanism

2014-05-30 Thread Eddie Wai
Thanks for fixing this. The patch generally looks good, but I do have a few comments. On Fri, 2014-05-30 at 11:01 -0400, Neil Horman wrote: Recently had this warning reported: [ 290.489047] Call Trace: [ 290.489053] [8169efec] dump_stack+0x19/0x1b [ 290.489055]

Re: [Open-FCoE] [PATCH] bnx2fc: Improve stats update mechanism

2014-05-30 Thread Eddie Wai
On May 30, 2014, at 7:48 PM, Neil Horman nhor...@tuxdriver.com wrote: On Fri, May 30, 2014 at 02:59:43PM -0700, Eddie Wai wrote: Thanks for fixing this. The patch generally looks good, but I do have a few comments. On Fri, 2014-05-30 at 11:01 -0400, Neil Horman wrote: Recently had this