Re: [PATCH] debloat aic7xxx and aic79xx drivers

2007-11-18 Thread Hannes Reinecke
Denys Vlasenko wrote: > Hi Matthew, Hannes, > > Any news on this? Where these patches stand now? > Are they accepted into linux-scsi? > > On Wednesday 14 November 2007 13:39, Denys Vlasenko wrote: >> hi Matthew, >> >> On Wednesday 14 November 2007 06:35, Hannes Reinecke wrote: >>> Matthew Wilcox

[PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-07-31 Thread Denis Vlasenko
Hi, Attached patch deinlines and moves big functions from .h to .c files in drivers/scsi/aic7xxx/*. I also had to add prototypes for ahc_lookup_scb and ahd_lookup_scb to .h files. No other code changes made. Compile-tested on i386 and x86-64. Total .text size reduction: ~60k in 64 bits, ~90k in

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-25 Thread Arjan van de Ven
On Sat, 25 Aug 2007 22:57:07 +0100 Denys Vlasenko <[EMAIL PROTECTED]> wrote: > Hi, > > Attached patch deinlines and moves big functions from .h to .c files > in drivers/scsi/aic7xxx/*. I also had to add prototypes for > ahc_lookup_scb and ahd_lookup_scb to .h files. > one question... how many o

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-26 Thread Denys Vlasenko
On Saturday 25 August 2007 22:57, Arjan van de Ven wrote: > On Sat, 25 Aug 2007 22:57:07 +0100 > > Denys Vlasenko <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Attached patch deinlines and moves big functions from .h to .c files > > in drivers/scsi/aic7xxx/*. I also had to add prototypes for > > ahc_l

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-26 Thread Adrian Bunk
On Sun, Aug 26, 2007 at 04:21:30PM +0100, Denys Vlasenko wrote: > On Saturday 25 August 2007 22:57, Arjan van de Ven wrote: >... > > Did you run the find static > > script or are you waiting for Adrian to do that ;-) > > $ find -name '*find*static*' > $ make namespacecheck > vda cu Adrian --

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-28 Thread Denys Vlasenko
On Monday 27 August 2007 03:03, Adrian Bunk wrote: > On Sun, Aug 26, 2007 at 04:21:30PM +0100, Denys Vlasenko wrote: > > On Saturday 25 August 2007 22:57, Arjan van de Ven wrote: > >... > > > > > Did you run the find static > > > script or are you waiting for Adrian to do that ;-) > > > > $ find -n

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-28 Thread Arjan van de Ven
On Tue, 28 Aug 2007 12:56:34 +010 Denys Vlasenko <[EMAIL PROTECTED]> wrote: > > > > make namespacecheck > > Thanks, nice tool. > > aic7xxx is kind of not very nice in this regard. > > See below what I get even on non-patched driver. > > I am willing to clean it up, but I still would like > "

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-28 Thread Denys Vlasenko
On Tuesday 28 August 2007 16:17, Arjan van de Ven wrote: > On Tue, 28 Aug 2007 12:56:34 +010 > > Denys Vlasenko <[EMAIL PROTECTED]> wrote: > > > make namespacecheck > > > > Thanks, nice tool. > > > > aic7xxx is kind of not very nice in this regard. > > > > See below what I get even on non-patched

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 20:55, Denys Vlasenko wrote: >> Fwiw I do like your debloat patch a lot; it's just only half the >> equation ... if you also do the namespace fixes, I bet the driver >> debloats even more... > >Yes, I know, and I am happy to do that too. I just don't know >whether patches will be ac

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 08:43:24PM +0200, Jan Engelhardt wrote: > On Aug 28 2007 20:55, Denys Vlasenko wrote: > >> Fwiw I do like your debloat patch a lot; it's just only half the > >> equation ... if you also do the namespace fixes, I bet the driver > >> debloats even more... > > > >Yes, I know, a

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 13:02, Matthew Wilcox wrote: >> >> Well, you can send it to Linus/Andrew, that will usually upset people and >> they >> start commenting on it. Or they don't, and everything is fine. >> (The "default y" approach so to speak ;-) > >The problem is that we don't really have a maintai

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-31 Thread Hannes Reinecke
Jan Engelhardt wrote: > On Aug 30 2007 13:02, Matthew Wilcox wrote: >>> Well, you can send it to Linus/Andrew, that will usually upset people and >>> they >>> start commenting on it. Or they don't, and everything is fine. >>> (The "default y" approach so to speak ;-) >> The problem is that we don'