Re: [PATCH] iscsi: Fix iscsi endpoints leak

2015-06-02 Thread Mike Christie
On 05/20/2015 04:38 AM, Sagi Grimberg wrote: > When creating a new endpoint, we look for a free id > for the new endpoint. We baisically loop on possible ids > and use the first id that class_find_device() returns NULL. > However, we are missing a reference put when class_find_device() > does find

Re: [PATCH] iscsi: Fix iscsi endpoints leak

2015-06-02 Thread Sagi Grimberg
On 5/20/2015 12:38 PM, Sagi Grimberg wrote: When creating a new endpoint, we look for a free id for the new endpoint. We baisically loop on possible ids and use the first id that class_find_device() returns NULL. However, we are missing a reference put when class_find_device() does find an existi

[PATCH] iscsi: Fix iscsi endpoints leak

2015-05-20 Thread Sagi Grimberg
When creating a new endpoint, we look for a free id for the new endpoint. We baisically loop on possible ids and use the first id that class_find_device() returns NULL. However, we are missing a reference put when class_find_device() does find an existing device for a given id. Reported-by: Alex L