Re: [PATCH] libata: don't try to pass through NCQ commands to non-NCQ devices

2018-02-12 Thread Tejun Heo
On Sat, Feb 03, 2018 at 08:33:51PM -0800, Eric Biggers wrote: > From: Eric Biggers > > syzkaller hit a WARN() in ata_bmdma_qc_issue() when writing to /dev/sg0. > This happened because it issued an ATA pass-through command (ATA_16) > where the protocol field indicated that NCQ should be used -- bu

[PATCH] libata: don't try to pass through NCQ commands to non-NCQ devices

2018-02-03 Thread Eric Biggers
From: Eric Biggers syzkaller hit a WARN() in ata_bmdma_qc_issue() when writing to /dev/sg0. This happened because it issued an ATA pass-through command (ATA_16) where the protocol field indicated that NCQ should be used -- but the device did not support NCQ. We could just remove the WARN() from