Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-03-01 Thread Martin K. Petersen
James, >> Cc: #4.4+ Ugh. > Martin, can you fix this up with a rebase and I'll resync my tree? Done and pushed. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-03-01 Thread James Bottomley
On Mon, 2018-02-12 at 10:28 -0800, Himanshu Madhani wrote: [...] > Cc: #4.4+ This is the wrong stable tag, which would lead to stable not picking up the patch automatically.  The correct stable address is Cc: #4.4+                  ^^

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-22 Thread Martin K. Petersen
Himanshu, > Can you please queue this patch for 4.16-rc3 Applied to 4.16/scsi-fixes with the missing Fixes: tag. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-22 Thread Madhani, Himanshu
Hi Martin, > On Feb 14, 2018, at 11:58 AM, Madhani, Himanshu > wrote: > > Hi John, > >> On Feb 13, 2018, at 2:54 AM, John Garry wrote: >> >> On 12/02/2018 18:28, Himanshu Madhani wrote: >>> This patch fixes NULL pointer crash due to

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-14 Thread Madhani, Himanshu
Hi John, > On Feb 13, 2018, at 2:54 AM, John Garry wrote: > > On 12/02/2018 18:28, Himanshu Madhani wrote: >> This patch fixes NULL pointer crash due to active timer running >> for abort IOCB. >> >>> From crash dump analysis it was discoverd that

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-14 Thread Johannes Thumshirn
On Tue, 2018-02-13 at 18:13 +, Madhani, Himanshu wrote: > Thanks for asking (I did not add fixes commit ID because it was pre > 4.x kernel)  > > Here’s commit id 4440e46d5db7b445a961a8849b2a31fa7fd1 which is > fixed by this patch. Thanks for the info. In general having a  Fixes:

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-13 Thread Madhani, Himanshu
Hi John, > On Feb 13, 2018, at 2:54 AM, John Garry wrote: > > On 12/02/2018 18:28, Himanshu Madhani wrote: >> This patch fixes NULL pointer crash due to active timer running >> for abort IOCB. >> >>> From crash dump analysis it was discoverd that

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-13 Thread Madhani, Himanshu
Hi Johannes, > On Feb 13, 2018, at 2:38 AM, Johannes Thumshirn wrote: > > Thanks Himanshu, > Reviewed-by: Johannes Thumshirn > > Do you happen to know which commit it actually fixes? > Thanks for asking (I did not add fixes commit ID because it was

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-13 Thread John Garry
On 12/02/2018 18:28, Himanshu Madhani wrote: This patch fixes NULL pointer crash due to active timer running for abort IOCB. From crash dump analysis it was discoverd that get_next_timer_interrupt() encountered a corrupted entry on the timer list. #9 [95e1f6f0fd40] page_fault at

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-13 Thread Johannes Thumshirn
Thanks Himanshu, Reviewed-by: Johannes Thumshirn Do you happen to know which commit it actually fixes? -- Johannes Thumshirn                                          Storage jthu msh...@suse.de                                +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5,

[PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

2018-02-12 Thread Himanshu Madhani
This patch fixes NULL pointer crash due to active timer running for abort IOCB. >From crash dump analysis it was discoverd that get_next_timer_interrupt() encountered a corrupted entry on the timer list. #9 [95e1f6f0fd40] page_fault at 914fe8f8 [exception RIP: