Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-03-01 Thread Tejun Heo
Hello, On Wed, Feb 28, 2018 at 03:18:39PM +0800, chenxiang (M) wrote: > If we can introduce a port flags such as ATA_LFLAG_DISABLED or > ATA_EHI_NO_RECOVERY before ata_eh_recover, > it will skip recovery. But we only get device status NODEV from > ata_do_reset which is after ata_eh_recover, i don'

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-02-27 Thread chenxiang (M)
Hi Tejun, 在 2018/2/28 2:19, Tejun Heo 写道: Hello, On Mon, Feb 26, 2018 at 07:45:37PM +0800, chenxiang (M) wrote: So, if there are real consequences, we can definitely add a way to short-circuit the recovery logic but let's do that by adding proper signaling rathr than testing for driver type.

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-02-27 Thread Tejun Heo
Hello, On Mon, Feb 26, 2018 at 07:45:37PM +0800, chenxiang (M) wrote: > >So, if there are real consequences, we can definitely add a way to > >short-circuit the recovery logic but let's do that by adding proper > >signaling rathr than testing for driver type. > > I am not familiar with ata recove

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-02-26 Thread chenxiang (M)
Hi Tejun, Sorry for my late reply as i have a vacation last week. 在 2018/2/13 22:27, Tejun Heo 写道: Hello, On Tue, Feb 13, 2018 at 09:44:53AM +0800, chenxiang (M) wrote: For those drivers using libsas, i think they have the same issue. It takes about 1 minute to recover but actually device is

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-02-13 Thread Tejun Heo
Hello, On Tue, Feb 13, 2018 at 09:44:53AM +0800, chenxiang (M) wrote: > For those drivers using libsas, i think they have the same issue. > It takes about 1 minute to > recover but actually device is gone, so this recover is useless for > this scenario (when enter EH, > all normal IOs are blocked

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-02-12 Thread chenxiang (M)
Hi Tejun, 在 2018/2/13 0:51, Tejun Heo 写道: Hello, On Wed, Jan 24, 2018 at 09:20:25PM +0800, chenxiang wrote: In ata_eh_reset, it will reset three times at most for sata disk. For some drivers through libsas, it calls sas_ata_hard_reset at last. When device is gone, function sas_ata_hard_reset w

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-02-12 Thread Tejun Heo
Hello, On Wed, Jan 24, 2018 at 09:20:25PM +0800, chenxiang wrote: > In ata_eh_reset, it will reset three times at most for sata disk. For > some drivers through libsas, it calls sas_ata_hard_reset at last. When > device is gone, function sas_ata_hard_reset will return -ENODEV. But > it will still

[PATCH] scsi: ata: don't reset three times if device is offline for SAS host

2018-01-24 Thread chenxiang
In ata_eh_reset, it will reset three times at most for sata disk. For some drivers through libsas, it calls sas_ata_hard_reset at last. When device is gone, function sas_ata_hard_reset will return -ENODEV. But it will still try to reset three times for offline device. This process lasts a long time