Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2018-01-16 Thread Martin K. Petersen
Bart, >> Applied to 4.15/scsi-fixes. Thanks! > > Since that patch fixes an issue that was introduced in kernel v4.14 > but did not have a "Cc: stable" tag, should this patch be sent to Greg > for inclusion in the kernel v4.14.x series? Yes. Hannes? -- Martin K. Petersen Oracle Linux Engin

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2018-01-16 Thread Bart Van Assche
On Mon, 2017-12-18 at 22:37 -0500, Martin K. Petersen wrote: > Hannes, > > > As it turned out device_get() doesn't use kref_get_unless_zero(), > > so we will be always getting a device pointer. > > So we need to check for the device state in __scsi_remove_target() > > to avoid tripping over delete

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-18 Thread Martin K. Petersen
Hannes, > As it turned out device_get() doesn't use kref_get_unless_zero(), > so we will be always getting a device pointer. > So we need to check for the device state in __scsi_remove_target() > to avoid tripping over deleted objects. Applied to 4.15/scsi-fixes. Thanks! -- Martin K. Petersen

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-18 Thread Ewan D. Milne
On Thu, 2017-12-14 at 17:10 -0500, Ewan D. Milne wrote: > On Thu, 2017-12-14 at 10:02 +0100, Hannes Reinecke wrote: > > On 12/14/2017 09:05 AM, Jason Yan wrote: > > > > > > On 2017/12/14 6:23, Bart Van Assche wrote: > > >> On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote: > > >>> As it tur

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-14 Thread Ewan D. Milne
On Thu, 2017-12-14 at 10:02 +0100, Hannes Reinecke wrote: > On 12/14/2017 09:05 AM, Jason Yan wrote: > > > > On 2017/12/14 6:23, Bart Van Assche wrote: > >> On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote: > >>> As it turned out device_get() doesn't use kref_get_unless_zero(), > >>> so we

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-14 Thread Hannes Reinecke
On 12/14/2017 09:05 AM, Jason Yan wrote: > > On 2017/12/14 6:23, Bart Van Assche wrote: >> On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote: >>> As it turned out device_get() doesn't use kref_get_unless_zero(), >>> so we will be always getting a device pointer. >>> So we need to check for

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-14 Thread Jason Yan
On 2017/12/14 6:23, Bart Van Assche wrote: On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote: As it turned out device_get() doesn't use kref_get_unless_zero(), so we will be always getting a device pointer. So we need to check for the device state in __scsi_remove_target() to avoid tripp

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-13 Thread Bart Van Assche
On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote: > As it turned out device_get() doesn't use kref_get_unless_zero(), > so we will be always getting a device pointer. > So we need to check for the device state in __scsi_remove_target() > to avoid tripping over deleted objects. > > Fixes: f

[PATCH] scsi: check for device state in __scsi_remove_target()

2017-12-13 Thread Hannes Reinecke
As it turned out device_get() doesn't use kref_get_unless_zero(), so we will be always getting a device pointer. So we need to check for the device state in __scsi_remove_target() to avoid tripping over deleted objects. Fixes: fbce4d9 ("scsi: fixup kernel warning during rmmod()") Signed-off-by: H