Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread Christoph Hellwig
On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote: --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig @@ -30,7 +30,7 @@ config SCSI_QLA_FC config TCM_QLA2XXX tristate TCM_QLA2XXX fabric module for Qlogic 2xxx

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread David Miller
From: Christoph Hellwig h...@infradead.org Date: Mon, 22 Sep 2014 07:42:13 -0700 On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote: --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig @@ -30,7 +30,7 @@ config SCSI_QLA_FC

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread David Miller
From: Christoph Hellwig h...@infradead.org Date: Mon, 22 Sep 2014 07:42:13 -0700 On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote: --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig @@ -30,7 +30,7 @@ config SCSI_QLA_FC

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Fri, 19 Sep 2014 16:50:59 -0700 From: Randy Dunlap rdun...@infradead.org Fix kconfig dependency warnings which can lead to build errors: warning: (SCSI_BNX2X_FCOE LIBFCOE TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread Christoph Hellwig
On Mon, Sep 22, 2014 at 11:56:58AM -0400, David Miller wrote: CONFIG_SCSI_QLA_FC currently selects SCSI_FC_ATTRS, so we shouldn't need this here. Also any reason not to switch that one over to a depends as well? Christoph, I understand your confusion now, in the networking tree

[PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-19 Thread Randy Dunlap
From: Randy Dunlap rdun...@infradead.org Fix kconfig dependency warnings which can lead to build errors: warning: (SCSI_BNX2X_FCOE LIBFCOE TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL SCSI SCSI_FC_ATTRS) warning: (FCOE FCOE_FNIC) selects LIBFCOE which has