Re: [PATCH] scsi: megaraid: fix ifnullfree.cocci warnings

2017-07-25 Thread James Bottomley
On Tue, 2017-07-25 at 23:40 +0800, kbuild test robot wrote: > drivers/scsi/megaraid/megaraid_sas_fusion.c:608:2-18: WARNING: NULL > check before freeing functions like kfree, debugfs_remove, > debugfs_remove_recursive or usb_free_urb is not needed. Maybe > consider reorganizing relevant code to avo

[PATCH] scsi: megaraid: fix ifnullfree.cocci warnings

2017-07-25 Thread kbuild test robot
drivers/scsi/megaraid/megaraid_mbox.c:1256:2-18: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/scsi/megaraid/megaraid_mbox.c:1265:2-1

[PATCH] scsi: megaraid: fix ifnullfree.cocci warnings

2017-07-25 Thread kbuild test robot
drivers/scsi/megaraid/megaraid_mm.c:1020:2-18: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is no

[PATCH] scsi: megaraid: fix ifnullfree.cocci warnings

2017-07-25 Thread kbuild test robot
drivers/scsi/megaraid/megaraid_sas_fusion.c:608:2-18: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/scsi/megaraid/megaraid_sas_fusion