Re: [PATCH] scsi: remove useless variable assignment

2017-06-10 Thread James Bottomley
On Thu, 2017-05-18 at 12:41 -0500, Gustavo A. R. Silva wrote: > Hi James, > > Quoting James Bottomley : > > > On Wed, 2017-05-17 at 19:30 -0500, Gustavo A. R. Silva wrote: > > > Remove this assignment once the value stored in variable _k_ is > > > overwritten after a few lines. > > > > > > Addre

[PATCH] scsi: remove useless variable assignment

2017-06-07 Thread Gustavo A. R. Silva
Remove both variable assignments once the value stored in variable _reqlen_ is overwritten at some point either by line 2321: reqlen = mptr - msg; or by line 2330: reqlen = 12; Addresses-Coverity-ID: 1226930 Addresses-Coverity-ID: 1226931 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/dpt

Re: [PATCH] scsi: remove useless variable assignment

2017-05-18 Thread Gustavo A. R. Silva
Hi James, Quoting James Bottomley : On Wed, 2017-05-17 at 19:30 -0500, Gustavo A. R. Silva wrote: Remove this assignment once the value stored in variable _k_ is overwritten after a few lines. Addresses-Coverity-ID: 1226927 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/qlogicfas408.c

Re: [PATCH] scsi: remove useless variable assignment

2017-05-17 Thread James Bottomley
On Wed, 2017-05-17 at 19:30 -0500, Gustavo A. R. Silva wrote: > Remove this assignment once the value stored in variable _k_ is > overwritten after a few lines. > > Addresses-Coverity-ID: 1226927 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/qlogicfas408.c | 1 - > 1 file changed, 1

[PATCH] scsi: remove useless variable assignment

2017-05-17 Thread Gustavo A. R. Silva
Remove both variable assignments once the value stored in variable _reqlen_ is overwritten at some point either by line 2321: reqlen = mptr - msg; or by line 2330: reqlen = 12; Addresses-Coverity-ID: 1226930 Addresses-Coverity-ID: 1226931 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/dpt_i

[PATCH] scsi: remove useless variable assignment

2017-05-17 Thread Gustavo A. R. Silva
Remove this assignment once the value stored in variable _k_ is overwritten after a few lines. Addresses-Coverity-ID: 1226927 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/qlogicfas408.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas