Re: [PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

2017-06-27 Thread Martin K. Petersen
Johannes, > libsas uses scsi_queue_work() to queue it's internal event > notifications. scsi_queue_work() can return -EINVAL if the work queue > doesn't exist and it does call queue_work() which can return false if > the work is already queued. Applied to 4.13/scsi-queue, thanks! -- Martin K.

Re: [PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

2017-06-14 Thread Johannes Thumshirn
On 06/14/2017 02:57 PM, John Garry wrote: > On 14/06/2017 12:52, Johannes Thumshirn wrote: >> libsas uses scsi_queue_work() to queue it's internal event >> notifications. scsi_queue_work() can return -EINVAL if the work queue >> doesn't exist and it does call queue_work() which can return false if

Re: [PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

2017-06-14 Thread John Garry
On 14/06/2017 12:52, Johannes Thumshirn wrote: libsas uses scsi_queue_work() to queue it's internal event notifications. scsi_queue_work() can return -EINVAL if the work queue doesn't exist and it does call queue_work() which can return false if the work is already queued. Hi Johannes, When

[PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

2017-06-14 Thread Johannes Thumshirn
libsas uses scsi_queue_work() to queue it's internal event notifications. scsi_queue_work() can return -EINVAL if the work queue doesn't exist and it does call queue_work() which can return false if the work is already queued. Make the SAS event code capable of returning errors up to the caller,