Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout

2014-09-19 Thread Ming Lei
On Fri, Sep 19, 2014 at 1:03 AM, Jens Axboe ax...@fb.com wrote: On 2014-09-18 10:35, Christoph Hellwig wrote: On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote: If there are two requests or more timed out, the dispatch queue is put into stopped state and never be recoverd, and there

Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout

2014-09-19 Thread Ming Lei
On Fri, Sep 19, 2014 at 9:07 PM, Ming Lei ming@canonical.com wrote: On Fri, Sep 19, 2014 at 1:03 AM, Jens Axboe ax...@fb.com wrote: On 2014-09-18 10:35, Christoph Hellwig wrote: On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote: If there are two requests or more timed out, the

Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout

2014-09-19 Thread Jens Axboe
On 09/19/2014 08:18 AM, Ming Lei wrote: On Fri, Sep 19, 2014 at 9:07 PM, Ming Lei ming@canonical.com wrote: On Fri, Sep 19, 2014 at 1:03 AM, Jens Axboe ax...@fb.com wrote: On 2014-09-18 10:35, Christoph Hellwig wrote: On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote: If there

[PATCH] scsi-mq: fix hw queue hang caused by timeout

2014-09-18 Thread Ming Lei
If there are two requests or more timed out, the dispatch queue is put into stopped state and never be recoverd, and there is no such problem in non-mq mode. This patch trys to recover the stopped queue when the queue becomes unbusy, then the following retries can move on. Basically this patch

Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout

2014-09-18 Thread Christoph Hellwig
On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote: If there are two requests or more timed out, the dispatch queue is put into stopped state and never be recoverd, and there is no such problem in non-mq mode. This patch trys to recover the stopped queue when the queue becomes unbusy,

Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout

2014-09-18 Thread Jens Axboe
On 2014-09-18 10:35, Christoph Hellwig wrote: On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote: If there are two requests or more timed out, the dispatch queue is put into stopped state and never be recoverd, and there is no such problem in non-mq mode. This patch trys to recover the