Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-05-12 Thread Martin K. Petersen
> "Fam" == Fam Zheng writes: Fam, Fam> This looks wrong to me, maybe I'm missing the obvious? Here sdkp-> Fam> opt_xfer_blocks is in block size unit, and rw_max is in byte sdkp-> Fam> unit. Oh, joy. It's the commit that keeps on giving! Back when the I/O topology was

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-05-12 Thread Tom Yan
On 12 May 2016 at 12:04, Fam Zheng wrote: > > Following is: > > else > rw_max = BLK_DEF_MAX_SECTORS; > > Which seems in sector unit, and is already making above change suspicious, and Yes BLK_DEF_MAX_SECTORS is in sector unit. It has been bumped from 1024

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-05-11 Thread Fam Zheng
On Wed, 01/20 11:01, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes to > block layer sectors. > > Signed-off-by: Martin K. Petersen > Reported-by:

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-22 Thread Greg Kroah-Hartman
On Wed, Jan 20, 2016 at 08:47:29AM -0800, James Bottomley wrote: > On Wed, 2016-01-20 at 11:40 -0500, Martin K. Petersen wrote: > > > > > > > "James" == James Bottomley < > > > > > > > james.bottom...@hansenpartnership.com> writes: > > > > James> We should mark the commit causing the problems,

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> We should mark the commit causing the problems, which went into James> 4.4 if I remember correctly: James> Fixes: ca369d51b3e1649be4a72addd6d6a168cfb3f537 Cc: James> sta...@vger.kernel.org # 4.4+ Reviewed-by:

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread James Bottomley
On Wed, 2016-01-20 at 11:01 -0500, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes > to > block layer sectors. > > Signed-off-by: Martin K. Petersen >

[PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Martin K. Petersen
Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length limits") accidentally switched optimal I/O size reporting from bytes to block layer sectors. Signed-off-by: Martin K. Petersen Reported-by: Christian Borntraeger ---

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Ewan Milne
On Wed, 2016-01-20 at 11:01 -0500, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes to > block layer sectors. > > Signed-off-by: Martin K. Petersen >

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Johannes Thumshirn
On Wed, Jan 20, 2016 at 11:01:23AM -0500, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes to > block layer sectors. > > Signed-off-by: Martin K. Petersen

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Matthew R. Ochs
Reviewed-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread James Bottomley
On Wed, 2016-01-20 at 11:40 -0500, Martin K. Petersen wrote: > > > > > > "James" == James Bottomley < > > > > > > james.bottom...@hansenpartnership.com> writes: > > James> We should mark the commit causing the problems, which went > into > James> 4.4 if I remember correctly: > > James> Fixes:

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Christian Borntraeger
On 01/20/2016 05:01 PM, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes to > block layer sectors. > > Signed-off-by: Martin K. Petersen > Reported-by: