Re: [PATCH] ses: fix error message in ses_intf_add()

2017-05-17 Thread Martin K. Petersen
Ewan, > This looks OK but I think we should consider suppressing these > messages. There are a lot of devices that return page 0 instead of > the correct page, we should either say something like "enclosure > services not supported", or else work with what we get instead of > logging a message o

Re: [PATCH] ses: fix error message in ses_intf_add()

2017-05-17 Thread Ewan D. Milne
On Wed, 2017-05-17 at 15:00 +0200, Maurizio Lombardi wrote: > The "result" variable contains a negative error code and > should not be logged as an hex value. > This fixes the following error message: > > [ 250.068869] scsi 8:0:2:254: Wrong diagnostic page; asked for 2 got 0 > [ 250.068872] scsi

[PATCH] ses: fix error message in ses_intf_add()

2017-05-17 Thread Maurizio Lombardi
The "result" variable contains a negative error code and should not be logged as an hex value. This fixes the following error message: [ 250.068869] scsi 8:0:2:254: Wrong diagnostic page; asked for 2 got 0 [ 250.068872] scsi 8:0:2:254: Failed to get diagnostic page 0xffea Signed-off-by: Mau