Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-17 Thread Boaz Harrosh
We should switch this topic to the scsi mailing list On 08/17/2012 01:49 PM, Boaz Harrosh wrote: > On 08/17/2012 01:12 AM, Nicholas A. Bellinger wrote: > >> On Thu, 2012-08-16 at 09:24 -0700, Roland Dreier wrote: >>> Actually I'm not sure removing cmd_spdtl is the right answer. >>> >>> If /dev/s

Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-17 Thread Nicholas A. Bellinger
(CC'ing linux-scsi as per request by Boaz) On Fri, 2012-08-17 at 13:49 +0300, Boaz Harrosh wrote: > On 08/17/2012 01:12 AM, Nicholas A. Bellinger wrote: > > > On Thu, 2012-08-16 at 09:24 -0700, Roland Dreier wrote: > >> Actually I'm not sure removing cmd_spdtl is the right answer. > >> > >> If /d

Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-17 Thread Nicholas A. Bellinger
On Fri, 2012-08-17 at 11:46 -0700, Roland Dreier wrote: > On Thu, Aug 16, 2012 at 3:12 PM, Nicholas A. Bellinger > wrote: > > diff --git a/drivers/target/target_core_transport.c > > b/drivers/target/target_core_transport.c > > index 0eaae23..63b3594 100644 > > --- a/drivers/target/target_core_tra

Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-18 Thread Roland Dreier
On Fri, Aug 17, 2012 at 6:02 PM, Nicholas A. Bellinger wrote: > No, or at least that is not what happens anymore with current target > core + iscsi-target code.. > > The se_cmd->data_length re-assignment here is what will be used by > iscsi-target fabric code for all iSCSI descriptor related alloc

Re: [PATCH] target: Remove unused se_cmd.cmd_spdtl

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 10:13 -0700, Roland Dreier wrote: > On Fri, Aug 17, 2012 at 6:02 PM, Nicholas A. Bellinger > wrote: > > No, or at least that is not what happens anymore with current target > > core + iscsi-target code.. > > > > The se_cmd->data_length re-assignment here is what will be used