Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
Hi, On Thu, 16 Nov 2017 07:40:08 +0900 James Bottomley wrote: > On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > > >   Because with several of these drives / lots of activity / > > occasional > > > >   issues, it looks like it will

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread James Bottomley
On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > >   Because with several of these drives / lots of activity / > occasional > > >   issues, it looks like it will be hard to catch (yes I can use > > > usbmon). > > >  > > > - It looks like there

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Alan Stern
On Wed, 15 Nov 2017, Jérôme Carretero wrote: > (Adding Tejun Heo who was assigned on still-open bugzilla #93581 which > is about SATA but seems terribly related.) > > On Wed, 15 Nov 2017 16:43:14 -0500 > Jérôme Carretero wrote: > > > Hi Hans, > > > > > > Tests are currently undergoing with dr

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
(Adding Tejun Heo who was assigned on still-open bugzilla #93581 which is about SATA but seems terribly related.) On Wed, 15 Nov 2017 16:43:14 -0500 Jérôme Carretero wrote: > Hi Hans, > > > Tests are currently undergoing with drives operating in plain USB mass > storage class. In a first time,

Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
Hi Hans, Tests are currently undergoing with drives operating in plain USB mass storage class. In a first time, I'm filling drives with data (uncontrolled corpus, just TBs that I have on hand). It looks like the drives with most usage history are the ones that drop most often. kernel: usb 3-4.1.

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-15 Thread Hans de Goede
Hi, On 15-11-17 10:06, Oliver Neukum wrote: Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede: Greg, please do no merge the 2 recent uas seagate quirks I send then. I will submit a patch with the new approach right away. Hi, I am afraid in that case we will need a way to overri

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-15 Thread Oliver Neukum
Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede: > > Greg, please do no merge the 2 recent uas seagate quirks I send > then. I will submit a patch with the new approach right away. Hi, I am afraid in that case we will need a way to override a quirk in the other direction, that is,

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-14 Thread Hans de Goede
Hi, On 11/14/2017 04:25 PM, Alan Stern wrote: On Tue, 14 Nov 2017, Hans de Goede wrote: Hi, On 14-11-17 15:00, Hans de Goede wrote: Just like all previous UAS capable Seagate disk enclosures, this one needs a US_FL_NO_ATA_1X quirk. Cc: sta...@vger.kernel.org # 3.16 Reported-by: Wido Signed

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-14 Thread Alan Stern
On Tue, 14 Nov 2017, Hans de Goede wrote: > Hi, > > On 14-11-17 15:00, Hans de Goede wrote: > > Just like all previous UAS capable Seagate disk enclosures, this > > one needs a US_FL_NO_ATA_1X quirk. > > > > Cc: sta...@vger.kernel.org # 3.16 > > Reported-by: Wido > > Signed-off-by: Hans de Goed

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-14 Thread Hans de Goede
Hi, On 14-11-17 15:00, Hans de Goede wrote: Just like all previous UAS capable Seagate disk enclosures, this one needs a US_FL_NO_ATA_1X quirk. Cc: sta...@vger.kernel.org # 3.16 Reported-by: Wido Signed-off-by: Hans de Goede So far we've been adding quirks for Seagate drives on a one by on

[PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-14 Thread Hans de Goede
Just like all previous UAS capable Seagate disk enclosures, this one needs a US_FL_NO_ATA_1X quirk. Cc: sta...@vger.kernel.org # 3.16 Reported-by: Wido Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/stora

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-13 Thread Jérôme Carretero
Hi Hans, On Mon, 13 Nov 2017 10:04:53 +0100 Hans de Goede wrote: > Hi, > > On 13-11-17 07:14, Jérôme Carretero wrote: > > On Mon, 13 Nov 2017 07:01:30 +0300 > > Andrey Astafyev <1...@246060.ru> wrote: > > > >> 13.11.2017 00:42, Jérôme Carretero пишет: > >>> Nov 12 16:20:59 Bidule kernel: s

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-13 Thread Hans de Goede
Hi, On 13-11-17 07:14, Jérôme Carretero wrote: On Mon, 13 Nov 2017 07:01:30 +0300 Andrey Astafyev <1...@246060.ru> wrote: 13.11.2017 00:42, Jérôme Carretero пишет: Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT [...] Do you see such

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-12 Thread Jérôme Carretero
On Mon, 13 Nov 2017 09:16:39 +0300 Andrey Astafyev <1...@246060.ru> wrote: > 13.11.2017 09:14, Jérôme Carretero пишет: > > For my devices, adding US_FL_NO_ATA_1X to unusual_uas.h didn't > > change anything, and while adding US_FL_IGNORE_UAS (using > > quirks=0bc2:ab34:u,0bc2:ab38:u) there are stil

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-12 Thread Andrey Astafyev
13.11.2017 09:14, Jérôme Carretero пишет: For my devices, adding US_FL_NO_ATA_1X to unusual_uas.h didn't change anything, and while adding US_FL_IGNORE_UAS (using quirks=0bc2:ab34:u,0bc2:ab38:u) there are still device resets, but they cause shorter hangs in system activity (~1 second when UAS was

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-12 Thread Jérôme Carretero
On Mon, 13 Nov 2017 07:01:30 +0300 Andrey Astafyev <1...@246060.ru> wrote: > 13.11.2017 00:42, Jérôme Carretero пишет: > > Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 > > uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT > > [...] > > Do you see such things? > > > Hi, I've seen dm

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-12 Thread Andrey Astafyev
13.11.2017 00:42, Jérôme Carretero пишет: Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 CDB: Write(16) 8a 00 00 00 00 00 20 00 08 00 00 00 00 08 00 00 Nov 12 16

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-12 Thread Jérôme Carretero
On Fri, 10 Nov 2017 16:13:44 +0100 Hans de Goede wrote: > Just like all previous UAS capable Seagate disk enclosures, this > one needs a US_FL_NO_ATA_1X quirk. > [...] > +/* Reported-by: Andrey Astafyev */ Hi Andrey, I notice that you have an external Seagate SMR drive, I am encountering some

[PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-10 Thread Hans de Goede
Just like all previous UAS capable Seagate disk enclosures, this one needs a US_FL_NO_ATA_1X quirk. Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Andrey Astafyev <1...@246060.ru> Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 7 +++ 1 file changed, 7 insertions(+) d