Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-07 Thread Vu Pham
Alex Turin wrote: On 12/6/2012 5:04 PM, Bart Van Assche wrote: On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the c

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-07 Thread Or Gerlitz
On Thu, Dec 6, 2012 at 4:27 PM, Or Gerlitz wrote: [...] > looking on the current locks in the system, we see that this kworker task > holds four locks, but none of them seems to be mutually held by another task, That was ofcourse a wrong assertion, as a lock can't be mutually held by two tasks..

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Alex Turin
On 12/6/2012 5:04 PM, Bart Van Assche wrote: On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the connection between SRP initiator a

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Or Gerlitz
On 06/12/2012 17:04, Bart Van Assche wrote: On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the connection between SRP initiator an

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Bart Van Assche
On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the connection between SRP initiator and target is unique, and by removing duplicat

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Or Gerlitz
On 06/12/2012 16:10, Bart Van Assche wrote: On 12/05/12 22:32, Or Gerlitz wrote: On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche wrote: [...] The only way to make I/O work reliably if a failure can occur at the transport layer is to use multipathd on top of ib_srp. If a connection fails for

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Bart Van Assche
On 12/05/12 22:32, Or Gerlitz wrote: On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche wrote: [...] The only way to make I/O work reliably if a failure can occur at the transport layer is to use multipathd on top of ib_srp. If a connection fails for some reason, then the SRP SCSI host will be rem

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Or Gerlitz
On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche wrote: [...] > The only way to make I/O work reliably if a failure can occur at the > transport layer is to use multipathd on top of ib_srp. If a connection fails > for some reason, then the SRP SCSI host will be removed after the SCSI error > handle

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Bart Van Assche
On 12/05/12 19:50, Bart Van Assche wrote: On 12/05/12 19:23, Or Gerlitz wrote: On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything up to aabfa852acd27

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Bart Van Assche
On 12/05/12 19:23, Or Gerlitz wrote: On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything up to aabfa852acd27962 at git://github.com/bvanassche/linux.gi

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Or Gerlitz
On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] > Modulo a few style issues (braces around one line if branches, etc.) and > having three state variables vs one, I can live with everything up to > aabfa852acd27962 at git://github.com/bvanassche/linux.git#srp-ha. Those > two are small th

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-29 Thread David Dillow
On Thu, 2012-11-29 at 12:21 -0800, Roland Dreier wrote: > On Mon, Nov 26, 2012 at 8:04 PM, David Dillow wrote: > > We can push it through James's tree if need be, but Bart's code is > > pretty self-contained, and going through the SCSI tree will introduce > > merge dependencies. It'd be much easie

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-29 Thread Roland Dreier
On Mon, Nov 26, 2012 at 8:04 PM, David Dillow wrote: > We can push it through James's tree if need be, but Bart's code is > pretty self-contained, and going through the SCSI tree will introduce > merge dependencies. It'd be much easier to push it all through the RDMA > tree, especially if we want

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-27 Thread Joseph Glanville
On 28 November 2012 03:34, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: >> >> Here is a first, UNTESTED, pass at preparing a merge of Bart's SRP HA >> work to upstream. It is not complete, as I have not yet added the >> transport layer error handling and related patches. It is a

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-27 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: Here is a first, UNTESTED, pass at preparing a merge of Bart's SRP HA work to upstream. It is not complete, as I have not yet added the transport layer error handling and related patches. It is also currently missing the patch to maintain a single connection

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Or Gerlitz
On 27/11/2012 06:04, David Dillow wrote: We can push it through James's tree if need be, but Bart's code is pretty self-contained, and going through the SCSI tree will introduce merge dependencies. It'd be much easier to push it all through the RDMA tree Yep, this makes sense to me even witho

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 09:57 +0200, Or Gerlitz wrote: > On Mon, Nov 26, 2012 at 6:44 AM, David Dillow wrote: > > One may also pull this series from github: > > git pull git://github.com/dillow/srp-initiator.git ha-merge-v1 > > Hi Dave, > > The kernel maintainers file specifies the followi

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 23:15 +0400, James Bottomley wrote: > On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > > - I think the srp_transport stuff should go through linux-scsi / > > James B. > >instead of my tree, esp. since it's shared with the IBM vscsi stuff > > (I think) > > - I se

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Roland Dreier
> I'm amenable to that, but we do need an agreed patch set, as Roland > says. I also hate to apply the pressure, but I suspect -rc7 was the > last -rc, so I'm expecting the merge window to open on 2/12. I think the srp_transport bits are all simple and non-controversial. So at least from my persp

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread James Bottomley
On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > - I think the srp_transport stuff should go through linux-scsi / > James B. >instead of my tree, esp. since it's shared with the IBM vscsi stuff > (I think) > - I see Bart had a few comments about a few of your patches, I'll > wait >

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Roland Dreier
> This series compiles, but is otherwise UNTESTED. I'll be working on that > over the next few days, with an eye on getting as much of Bart's work > into 3.8 as possible. Hi Dave, Great to have you back. Certainly I'd like to get this stuff into 3.8 too. A couple of comments: - I think the

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-25 Thread Or Gerlitz
On Mon, Nov 26, 2012 at 6:44 AM, David Dillow wrote: > One may also pull this series from github: > git pull git://github.com/dillow/srp-initiator.git ha-merge-v1 Hi Dave, The kernel maintainers file specifies the following tree git://git.kernel.org/pub/scm/linux/kernel/git/dad/srp-initi

[PATCH 00/11] First pass at merging Bart's HA work

2012-11-25 Thread David Dillow
Here is a first, UNTESTED, pass at preparing a merge of Bart's SRP HA work to upstream. It is not complete, as I have not yet added the transport layer error handling and related patches. It is also currently missing the patch to maintain a single connection for an I_T nexus. I swapped Ishai's cod