Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-28 Thread Martin K. Petersen
Steffen, As I said, I don't have a problem with having module parameters. > There's one more important thing that has performance impact: We need to > pack payload and protection data into the same queue of limited > length. So for the worst case with DIX, we have to use half the size for > sg_

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-22 Thread Steffen Maier
Hi Martin, On 11/21/2018 07:13 PM, Martin K. Petersen wrote: Sorry about the delay. Travel got in the way. No problem. BDI_CAP_STABLE_WRITES should take care of this. What's the configuration that fails? Apologies, if the commit description sounds unfair. I did not mean to blame anyone. It

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-21 Thread Martin K. Petersen
Hi Steffen, Sorry about the delay. Travel got in the way. >> BDI_CAP_STABLE_WRITES should take care of this. What's the configuration >> that fails? > > Apologies, if the commit description sounds unfair. I did not mean to > blame anyone. It's just the collection of issues we saw in distros ove

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-09 Thread Steffen Maier
Hi Martin, On 11/09/2018 03:07 AM, Martin K. Petersen wrote: There are too many unresolved issues with DIX outside of zfcp such as wrong protection data on writesame/discard (over device-mapper) We don't configure protected transfers for anything but read and write commands. There is currently

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-08 Thread Martin K. Petersen
Steffen, > There are too many unresolved issues with DIX outside of zfcp such as > wrong protection data on writesame/discard (over device-mapper) We don't configure protected transfers for anything but read and write commands. There is currently no protection information generated for WRITE SA

[PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-08 Thread Steffen Maier
From: Fedor Loshakov There are too many unresolved issues with DIX outside of zfcp such as wrong protection data on writesame/discard (over device-mapper) or due to unstable page writes. This can cause I/O stalls or endless loops or even kernel panics, or I/O errors due to erroneously failed logi