Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-05 Thread Shaun Tancheff
On Tue, Apr 5, 2016 at 9:08 AM, Martin K. Petersen wrote: >> "Shaun" == Shaun Tancheff writes: > > Shaun> Oh, okay. It became an issue in the next patch where some > Shaun> internal cmd_flags temporaries where stored in 32 bit values. > > Shaun> I will fix patch/subject. > > There's a pending

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-04 Thread Martin K. Petersen
> "Shaun" == Shaun Tancheff writes: Shaun> Oh, okay. It became an issue in the next patch where some Shaun> internal cmd_flags temporaries where stored in 32 bit values. Shaun> I will fix patch/subject. There's a pending patch set from Mike Christie that cleans all this up. Please use that

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-04 Thread Shaun Tancheff
On Mon, Apr 4, 2016 at 10:56 PM, Jeff Moyer wrote: > Shaun Tancheff writes: > >> In a few places a temporary value smaller than a cmd_flags >> is used to test for bits and or build up a new cmd_flags. >> >> Change to use explicit u64 values where appropriate. > > This is not a bug fix, so please

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-04 Thread Jeff Moyer
Shaun Tancheff writes: > In a few places a temporary value smaller than a cmd_flags > is used to test for bits and or build up a new cmd_flags. > > Change to use explicit u64 values where appropriate. This is not a bug fix, so please fix your subject. I'm not against cleaning up the mixing of 3

[PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-03 Thread Shaun Tancheff
In a few places a temporary value smaller than a cmd_flags is used to test for bits and or build up a new cmd_flags. Change to use explicit u64 values where appropriate. Signed-off-by: Shaun Tancheff --- block/blk-core.c | 17 ++--- block/blk-merge.c| 2 +- block/bl