Re: [PATCH 05/10] scsi: use per-cpu buffer for formatting sense

2014-11-05 Thread Hannes Reinecke
On 11/06/2014 08:33 AM, Christoph Hellwig wrote: >> +#define scmd_format_header(b, l, d, t) \ >> +sdev_format_header(b, l, (d) ? (d)->disk_name : NULL, t) > > I'd rather have a > > static inline const char *scmd_name(struct scsi_cmnd *scmd) > { > return scmd->request->rq_disk ? >

Re: [PATCH 05/10] scsi: use per-cpu buffer for formatting sense

2014-11-05 Thread Christoph Hellwig
> +#define scmd_format_header(b, l, d, t) \ > + sdev_format_header(b, l, (d) ? (d)->disk_name : NULL, t) I'd rather have a static inline const char *scmd_name(struct scsi_cmnd *scmd) { return scmd->request->rq_disk ? scmd->request->rq_disk->disk_name : NULL; } helper

[PATCH 05/10] scsi: use per-cpu buffer for formatting sense

2014-11-04 Thread Hannes Reinecke
Convert sense buffer logging to use the per-cpu buffer to avoid line breakup. Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c| 107 --- drivers/scsi/scsi_logging.c | 150 ++-- drivers/scsi/sd.c | 7 +-