Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it

2017-08-24 Thread Bart Van Assche
On Thu, 2017-08-24 at 11:05 +0200, Christoph Hellwig wrote: > I don't really see the point of doing more work in exactly the same > amount of code here, especially given that this is the fast path. > > Do you need this for any future patches? Hello Christoph, I will drop this patch. Bart.

Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it

2017-08-24 Thread Christoph Hellwig
I don't really see the point of doing more work in exactly the same amount of code here, especially given that this is the fast path. Do you need this for any future patches?

[PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it

2017-08-23 Thread Bart Van Assche
The functional changes in this patch for scsi_setup_fs_cmnd() are: - scsi_request.sense_len is cleared. This is OK since it is the responsibility of the LLD to set .sense_len before calling .scsi_done(). - scsi_request.cmd_len is changed to BLK_MAX_CDB. This is fine since scsi_driver.init_com