On Fri, Feb 07, 2014 at 03:43:55PM -0600, Mike Christie wrote:
> We need something like the attached patch which just prevents scsi-ml
> from creating a host pool when mq is used. Note that when
> scsi_destroy_command_freelist is called shost->cmd_pool will be NULL so
> it will return immediately s
On 02/07/2014 06:46 AM, Christoph Hellwig wrote:
> On Fri, Feb 07, 2014 at 03:35:00AM -0600, Mike Christie wrote:
>> It seems there is a issue with using the cmd_size to indicate the driver
>> has its own cmd pool and also using that for scsi mq enabled drivers to
>> indicate that we want the LLD's
On Fri, Feb 07, 2014 at 03:35:00AM -0600, Mike Christie wrote:
> It seems there is a issue with using the cmd_size to indicate the driver
> has its own cmd pool and also using that for scsi mq enabled drivers to
> indicate that we want the LLD's struct allocated by blk/scsi mq.
>
> If a driver set
On Fri, Feb 07, 2014 at 10:13:25AM +0100, Paolo Bonzini wrote:
> Il 05/02/2014 13:39, Christoph Hellwig ha scritto:
> >+pool = scsi_find_host_cmd_pool(shost);
>
> Should you have a WARN_ON somewhere if shost->hostt->cmd_size &&
> shost->unchecked_isa_dma?
Seems like we could support passing S
On 02/05/2014 06:39 AM, Christoph Hellwig wrote:
> -static struct scsi_host_cmd_pool *scsi_get_host_cmd_pool(gfp_t gfp_mask)
> +static struct scsi_host_cmd_pool *
> +scsi_find_host_cmd_pool(struct Scsi_Host *shost)
> {
> + if (shost->hostt->cmd_size)
> + return shost->hostt->cmd_po
Il 05/02/2014 13:39, Christoph Hellwig ha scritto:
+ pool = scsi_find_host_cmd_pool(shost);
Should you have a WARN_ON somewhere if shost->hostt->cmd_size &&
shost->unchecked_isa_dma?
Apart from this,
Reviewed-by: Paolo Bonzini
Paolo
+ if (!pool) {
+ pool = scsi
This allows drivers to specify the size of their per-command private
data in the host template and then get extra memory allocated for
each command instead of needing another allocation in ->queuecommand.
With the current SCSI code that already does multiple allocations for
each command this proba
7 matches
Mail list logo
