Re: [PATCH 06/19] Document which queue type a function is intended for

2017-08-25 Thread Hannes Reinecke
On 08/23/2017 11:39 PM, Bart Van Assche wrote: > Document which queue type a function is intended for if this is not > easy to derive from the function name. > > Signed-off-by: Bart Van Assche > Cc: Hannes Reinecke > Cc: Christoph Hellwig

Re: [PATCH 06/19] Document which queue type a function is intended for

2017-08-24 Thread Bart Van Assche
On Thu, 2017-08-24 at 18:58 +0200, h...@lst.de wrote: > On Thu, Aug 24, 2017 at 04:57:03PM +, Bart Van Assche wrote: > > Is something like the patch below perhaps what you had in mind? > > Yes. Except that I really don't like the sq naming - blk-mq can > also be used for single queues, so

Re: [PATCH 06/19] Document which queue type a function is intended for

2017-08-24 Thread h...@lst.de
On Thu, Aug 24, 2017 at 04:57:03PM +, Bart Van Assche wrote: > Is something like the patch below perhaps what you had in mind? Yes. Except that I really don't like the sq naming - blk-mq can also be used for single queues, so it's a rather confusing name Something like legacy or old seems to

Re: [PATCH 06/19] Document which queue type a function is intended for

2017-08-24 Thread Bart Van Assche
On Thu, 2017-08-24 at 11:05 +0200, Christoph Hellwig wrote: > On Wed, Aug 23, 2017 at 02:39:56PM -0700, Bart Van Assche wrote: > > Document which queue type a function is intended for if this is not > > easy to derive from the function name. > > How about adding mq and legacy to the function

Re: [PATCH 06/19] Document which queue type a function is intended for

2017-08-24 Thread Christoph Hellwig
On Wed, Aug 23, 2017 at 02:39:56PM -0700, Bart Van Assche wrote: > Document which queue type a function is intended for if this is not > easy to derive from the function name. How about adding mq and legacy to the function names instead?

[PATCH 06/19] Document which queue type a function is intended for

2017-08-23 Thread Bart Van Assche
Document which queue type a function is intended for if this is not easy to derive from the function name. Signed-off-by: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Johannes Thumshirn ---