[PATCH 09/20] qla2xxx: Change check_stop_free to always return 1

2015-12-07 Thread Himanshu Madhani
From: Quinn Tran change tcm_qla2xxx_check_stop_free to always return 1 to prevent transport_cmd_finish_abort from accidently taking extra kref_put. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/tcm_qla2xxx.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [PATCH 09/20] qla2xxx: Change check_stop_free to always return 1

2015-12-07 Thread Christoph Hellwig
On Mon, Dec 07, 2015 at 07:48:56PM -0500, Himanshu Madhani wrote: > From: Quinn Tran > > change tcm_qla2xxx_check_stop_free to always return 1 > to prevent transport_cmd_finish_abort from accidently > taking extra kref_put. This looks a bit fishy. Even if this was the right behavior it's someth

Re: [PATCH 09/20] qla2xxx: Change check_stop_free to always return 1

2015-12-08 Thread Hannes Reinecke
On 12/08/2015 01:48 AM, Himanshu Madhani wrote: > From: Quinn Tran > > change tcm_qla2xxx_check_stop_free to always return 1 > to prevent transport_cmd_finish_abort from accidently > taking extra kref_put. > > Signed-off-by: Quinn Tran > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/ql

Re: [PATCH 09/20] qla2xxx: Change check_stop_free to always return 1

2015-12-09 Thread Quinn Tran
On 12/8/15, 10:56 PM, "target-devel-ow...@vger.kernel.org on behalf of Hannes Reinecke" wrote: >On 12/08/2015 01:48 AM, Himanshu Madhani wrote: >> From: Quinn Tran >> >> change tcm_qla2xxx_check_stop_free to always return 1 >> to prevent transport_cmd_finish_abort from accidently >> taking ext