Re: [PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-18 Thread John Garry
Hi Arnd, Currently there is no pci device listed in the ACPI tables. What I am doing is declaring a fake device in the root of the System bus tree of the ACPI tables, and in the kernel driver finding it by matching the name. It is not the ACPI companion for the pci device. So I think that we

Re: [PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 6:45 PM, John Garry wrote: > On 17/05/2017 15:13, Arnd Bergmann wrote: >> On Wed, May 17, 2017 at 3:37 PM, John Garry wrote: >>> On 17/05/2017 13:37, Arnd Bergmann wrote: >>> As for your suggestion, in theory it could be ok to

Re: [PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-17 Thread John Garry
On 17/05/2017 15:13, Arnd Bergmann wrote: On Wed, May 17, 2017 at 3:37 PM, John Garry wrote: On 17/05/2017 13:37, Arnd Bergmann wrote: Since this uses the _DSD information that was introduced for compatibility between device tree and ACPI based data, why not write the

Re: [PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 3:37 PM, John Garry wrote: > On 17/05/2017 13:37, Arnd Bergmann wrote: >> Since this uses the _DSD information that was introduced for compatibility >> between device tree and ACPI based data, why not write the code so that >> it can work for both?

Re: [PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-17 Thread John Garry
On 17/05/2017 13:37, Arnd Bergmann wrote: On Wed, May 17, 2017 at 12:49 PM, John Garry wrote: > For a pci-based controller, retrieve the SAS address from the > ACPI tables. > > The retrieval is based on the ACPI device node name. Sample is > as follows: > Scope(_SB) > {

Re: [PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 12:49 PM, John Garry wrote: > For a pci-based controller, retrieve the SAS address from the > ACPI tables. > > The retrieval is based on the ACPI device node name. Sample is > as follows: > Scope(_SB) > { > Device(SAS0) { >

[PATCH 09/22] scsi: hisi_sas: retrieve SAS address for pci-based controller

2017-05-17 Thread John Garry
For a pci-based controller, retrieve the SAS address from the ACPI tables. The retrieval is based on the ACPI device node name. Sample is as follows: Scope(_SB) { Device(SAS0) { Name(_HID, "HISI0163") Name (_DSD, Package () {