Re: [PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-31 Thread Martin K. Petersen
Douglas, > On error, kthread_create() returns an errno-encoded pointer, not NULL. > The routine qla2x00_probe_one() detects the error case and jumps > to probe_failed, but has already assigned the return value from > kthread_create() to ha->dpc_thread. Then probe_failed checks to see > if ha->dp

Re: [PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-25 Thread Madhani, Himanshu
> On Oct 20, 2017, at 6:17 AM, Douglas Miller > wrote: > > On error, kthread_create() returns an errno-encoded pointer, not NULL. > The routine qla2x00_probe_one() detects the error case and jumps > to probe_failed, but has already assigned the return value from > kthread_create() to ha->dpc_th

Re: [PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-23 Thread Martin K. Petersen
Douglas, > On error, kthread_create() returns an errno-encoded pointer, not NULL. > The routine qla2x00_probe_one() detects the error case and jumps > to probe_failed, but has already assigned the return value from > kthread_create() to ha->dpc_thread. Then probe_failed checks to see > if ha->dp

[PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-20 Thread Douglas Miller
On error, kthread_create() returns an errno-encoded pointer, not NULL. The routine qla2x00_probe_one() detects the error case and jumps to probe_failed, but has already assigned the return value from kthread_create() to ha->dpc_thread. Then probe_failed checks to see if ha->dpc_thread is not NULL