Re: [PATCH 1/16] gdth: split out isa probing

2007-10-03 Thread Rolf Eike Beer
Boaz Harrosh wrote: (note: this is ontop of Jeff's pci cleanup patch) Split out isa probing into a helper of it's own. Error handling is cleaned up, but errors are not propagated yet. Also enclose the isa probe under the proper CONFIG_ISA symbol instead of the !IA64 hack. Signed-off-by:

Re: [PATCH 1/16] gdth: split out isa probing

2007-10-03 Thread Jeff Garzik
Rolf Eike Beer wrote: What we have here is cleanly not PCI memory as it's ISA initialisation. And for making things obvious passing NULL as first argument of dma_alloc_consistent() is IMHO the better way. While this is true, this is largely a code movement patch. It's up to Boaz/Christoph

[PATCH 1/16] gdth: split out isa probing

2007-09-30 Thread Boaz Harrosh
(note: this is ontop of Jeff's pci cleanup patch) Split out isa probing into a helper of it's own. Error handling is cleaned up, but errors are not propagated yet. Also enclose the isa probe under the proper CONFIG_ISA symbol instead of the !IA64 hack. Signed-off-by: Christoph Hellwig [EMAIL