Re: [PATCH 1/2] SRP transport: Move queuecommand() wait code to SCSI core

2016-11-29 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> On 11/25/16 15:21, Max Gurtovoy wrote: >> the arg is sdev. Bart> Good catch. Bart> Martin, do you want me to repost this patch or do you want me to Bart> post a fix-up patch? I fixed it up. -- Martin K. Petersen Oracle Linux Engineering -- T

Re: [PATCH 1/2] SRP transport: Move queuecommand() wait code to SCSI core

2016-11-29 Thread Bart Van Assche
On 11/25/16 15:21, Max Gurtovoy wrote: > On 11/23/2016 2:17 AM, Bart Van Assche wrote: >> + >> +/** >> + * scsi_wait_for_queuecommand() - wait for ongoing queuecommand() calls >> + * @shost: SCSI host pointer. > > the arg is sdev. Good catch. Martin, do you want me to repost this patch or do you

Re: [PATCH 1/2] SRP transport: Move queuecommand() wait code to SCSI core

2016-11-26 Thread Max Gurtovoy
On 11/23/2016 2:17 AM, Bart Van Assche wrote: Additionally, rename srp_wait_for_queuecommand() into scsi_wait_for_queuecommand() and add a comment about the queuecommand() call from scsi_send_eh_cmnd(). Note: this patch changes scsi_internal_device_block from a function that did not sleep into

[PATCH 1/2] SRP transport: Move queuecommand() wait code to SCSI core

2016-11-22 Thread Bart Van Assche
Additionally, rename srp_wait_for_queuecommand() into scsi_wait_for_queuecommand() and add a comment about the queuecommand() call from scsi_send_eh_cmnd(). Note: this patch changes scsi_internal_device_block from a function that did not sleep into a function that may sleep. This is fine for all c