Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-29 Thread Martin Wilck
ge...@hp.com; > > linux- > > s...@vger.kernel.org; jbottom...@odin.com; h...@lst.de; h...@suse.de > > ; > > Martin Wilck > > Subject: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when > > unloading > > > > EXTERNAL EMAIL > > > > >

RE: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-28 Thread Don Brace
de; > Martin Wilck > Subject: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when > unloading > > EXTERNAL EMAIL > > > When the hpsa module is unloaded using rmmod, dangling > symlinks remain under /sys/class/sas_phy. Fix this by > calling sas_phy_delete() rather t

Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-22 Thread Johannes Thumshirn
On Mon, Nov 21, 2016 at 10:47:20PM -0500, Martin K . Petersen wrote: > > "Johannes" == Johannes Thumshirn writes: > > Johannes> I don't think the SUSE bugzilla tag is of relevance upstream. > > Nope. I'd rather have really comprehensive patch descriptions. > > Johannes>

Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-21 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> I don't think the SUSE bugzilla tag is of relevance upstream. Nope. I'd rather have really comprehensive patch descriptions. Johannes> But for sake of completeness we could add a Link: Johannes>

Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-21 Thread Martin Wilck
On Mon, 2016-11-21 at 15:13 +0100, Johannes Thumshirn wrote: > On Mon, Nov 21, 2016 at 03:04:28PM +0100, Martin Wilck wrote: > > When the hpsa module is unloaded using rmmod, dangling > > symlinks remain under /sys/class/sas_phy. Fix this by > > calling sas_phy_delete() rather than sas_phy_free

Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-21 Thread Johannes Thumshirn
On Mon, Nov 21, 2016 at 03:04:28PM +0100, Martin Wilck wrote: > When the hpsa module is unloaded using rmmod, dangling > symlinks remain under /sys/class/sas_phy. Fix this by > calling sas_phy_delete() rather than sas_phy_free (which, > according to comments, should not be called for PHYs that >

[PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-21 Thread Martin Wilck
When the hpsa module is unloaded using rmmod, dangling symlinks remain under /sys/class/sas_phy. Fix this by calling sas_phy_delete() rather than sas_phy_free (which, according to comments, should not be called for PHYs that have been set up successfully, anyway). References: bsc#1010946.