Re: [PATCH 1/2] libiscsi: Fix locking in __iscsi_conn_send_pdu

2016-10-26 Thread Lee Duncan
On 10/12/2016 11:38 PM, Jitendra Bhivare wrote: > The code at free_task label in __iscsi_conn_send_pdu can get executed > from blk_timeout_work which takes queue_lock using spin_lock_irq. > back_lock taken with spin_unlock_bh will cause WARN_ON_ONCE. > The code gets executed either with bottom half

Re: [PATCH 1/2] libiscsi: Fix locking in __iscsi_conn_send_pdu

2016-10-17 Thread Chris Leech
On Thu, Oct 13, 2016 at 12:08:48PM +0530, Jitendra Bhivare wrote: > The code at free_task label in __iscsi_conn_send_pdu can get executed > from blk_timeout_work which takes queue_lock using spin_lock_irq. > back_lock taken with spin_unlock_bh will cause WARN_ON_ONCE. > The code gets executed eithe

Re: [PATCH 1/2] libiscsi: Fix locking in __iscsi_conn_send_pdu

2016-10-17 Thread Hannes Reinecke
On 10/13/2016 08:38 AM, Jitendra Bhivare wrote: > The code at free_task label in __iscsi_conn_send_pdu can get executed > from blk_timeout_work which takes queue_lock using spin_lock_irq. > back_lock taken with spin_unlock_bh will cause WARN_ON_ONCE. > The code gets executed either with bottom half

[PATCH 1/2] libiscsi: Fix locking in __iscsi_conn_send_pdu

2016-10-12 Thread Jitendra Bhivare
The code at free_task label in __iscsi_conn_send_pdu can get executed from blk_timeout_work which takes queue_lock using spin_lock_irq. back_lock taken with spin_unlock_bh will cause WARN_ON_ONCE. The code gets executed either with bottom half or IRQ disabled hence using spin_lock/spin_unlock for b